Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-855595 ] CSKILL not additive
|
From: SourceForge.net <no...@so...> - 2005-03-11 02:55:54
|
Bugs item #855595, was opened at 2003-12-06 20:46 Message generated for change (Comment added) made by ericbeaudoin You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=855595&group_id=25576 Category: Skill Support Group: None Status: Open Resolution: None Priority: 5 Submitted By: David R. Bender (papa_drb) Assigned to: Devon Jones (soulcatcher) Summary: CSKILL not additive Initial Comment: CSKILL is supposed to be ADDITIVE and it is not working that way with CLASS/SUBCLASS. The following is in my test_classes.lst SOURCELONG:Custom|SOURCESHORT:Custom CLASS:George HD:10 TYPE:Base.PC ABB:Grg HASSUBCLASS:YES CLASS:George STARTSKILLPTS:2 CSKILL:Concentration|TYPE.Craft|Handle Animal SUBCLASS:John ABB:John COST:0 CSKILL:Balance|Spot Create a character, and select George class. John pops up and I can select it. Go to skills and *only* Balance and Spot are shown as Class skills. This is in PCGen 5.5.2 200312041214 Plambert build. WindowsXP Pro. -- david (aka Papa-DRB) OS/Data Tracker Monkey ---------------------------------------------------------------------- >Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-03-10 21:55 Message: Logged In: YES user_id=324612 More like .lst revision. It used to be that a second CSKILL would overwrite the first one, no add to it. If we change the default behavior, we would have unwanted result for the cases when the author really wanted to overwrite. I guess we could do a one time conversion that would change all the SUBCLASS CSKILL:xxx to CSKILL:.CLEAR|xxx but that not ideal expecialy since many ppl used to think that the CSKILL tag was additive. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-03-10 12:11 Message: Logged In: YES user_id=208239 Eric, why will this need a LST conversion? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-03-10 10:23 Message: Logged In: YES user_id=252169 Shouldn't it be moved to FREQs then? :-) ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2004-12-13 21:12 Message: Logged In: YES user_id=324612 This is a code FREQ that will require a .lst conversion (or at least revision). Thus, it is not for 5.8. ---------------------------------------------------------------------- Comment By: Reed Thornton (rthornton13) Date: 2004-12-13 16:38 Message: Logged In: YES user_id=1001978 Is this something for 5.8, 5.10, or 6.0? This seems to me like something that is pretty basic (not saying it's easy). Reed QA SB ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2004-09-09 20:43 Message: Logged In: YES user_id=324612 Let's make it additive and allow CSKILL:.CLEAR to clear all and CSKILL:.CLEAR|<list of skills> to remove a particular list of skills from the CSKILL list. This is how everybody expects the CSKILL tag to work. ---------------------------------------------------------------------- Comment By: Michael Beaver (michaelbeaver) Date: 2004-09-09 12:41 Message: Logged In: YES user_id=23904 Devon, Can we verify this one. If it is valid... lets put it on the list and change it to a freq. ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2004-07-11 21:54 Message: Logged In: YES user_id=324612 Devon and Tir, I've been away to long to know what's best to do here. Me gut feelling tells me that is should be additive and we use the .CLEAR syntax if we want to replace. Assinging to Doug for comment. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2004-02-25 23:29 Message: Logged In: YES user_id=252169 OK, but this is correct as per the current documentation? If it _is_ I suggest we raisea high P freq for what you really wanted ;p K TM SB ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2004-02-25 23:14 Message: Logged In: YES user_id=324612 Well, way back when, I did some specs for SUBCLASS tags. I don't remember which tags exactly except that they were spell related. When Bryan implemented them, he didn't follow my specs entirely and the new tags in SUBCLASS ended up replacing the values instead of adding to them. At the time, I asked Bryan why and never got an answer. My understanding is that the SUBCLASS tags replace the CLASS tags instead of adding to them and that this is by design. Whether it is because other tags were already that way and/or it was easier to code that way, I do not know. Changing this behavior now would require a massive convertion of the CLASS files but it could be scripted. I say we wait until after 5.6 to decide. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2004-02-25 22:55 Message: Logged In: YES user_id=252169 Eric, can you comment on this? Is the syntax correct? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2004-02-11 20:43 Message: Logged In: YES user_id=252169 Oh, this isn't good, bumping priority up. ---------------------------------------------------------------------- Comment By: David R. Bender (papa_drb) Date: 2004-01-10 14:34 Message: Logged In: YES user_id=684040 fails under 5.5.6 also, with only the RSRD loaded ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=855595&group_id=25576 |