[Pcgen-trackers] [ pcgen-Bugs-988351 ] BONUS:WIELDCATEGORY not working

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #988351, was opened at 2004-07-09 21:59
Message generated for change (Comment added) made by soulcatcher
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=988351&group_id=25576

Category: Equipment/Weaponprof Support
Group: None
Status: Open
Resolution: None
Priority: 7
Submitted By: Chris Chandler (barako)
Assigned to: Enrico Canardi (theforken)
Summary: BONUS:WIELDCATEGORY not working

Initial Comment:
I'm trying to use the tag in the subject line and it does not 
appear to be working for me.

I'm trying to code up the Cloud Giant's "Oversize 
Weapon" ability (which lets him use a Gargantuan weapon 
without penalty).  I used 
BONUS:WIELDCATEGORY|TwoHanded|-1" in the race file. 

If I'm reading the docs correctly, this should enable him 
(SIZE:L) to use a Gargantuan two handed weapon in two 
hands.

However, when equipping the gargantuan piece of 
equipment, my only two choices are "carried" and "not 
carried".

----------------------------------------------------------------------

>Comment By: Devon Jones (soulcatcher)
Date: 2005-02-27 19:55

Message:
Logged In: YES 
user_id=107647

Good work Enrico, thanks for taking care of this bug :)

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-27 16:57

Message:
Logged In: YES 
user_id=1200673

That's why I've just commented it, please check if there are 
problems. 
Anyway I did a preliminary test and I've found out that with the 
commented code the bastard sword can be wielded only with 
both hands. 
Turning off the comment, the sword can be correctly wielded 
as primary, secondary and both, but in both cases (comment 
off/on) It's impossible to wield a LARGE Bastard Sword 
because the routine that allows/deny an object to be wielded 
blocks it before the check of the locations (it's considered as 
a 2handed weapon). Tomorrow I'll try to fix this part for 
[Hands] objects.

GoodNight
TheForken

----------------------------------------------------------------------

Comment By: Chris Chandler (barako)
Date: 2005-02-27 12:19

Message:
Logged In: YES 
user_id=607889

IIRC, [HANDS] is used by both the bastard sword and the 
dwarven waraxe...

yep, from the melee.lst:

Sword (Bastard)
OUTPUTNAME:Sword, Bastard
PROFICIENCY:Sword (Bastard/[Hands])	
...

and

Waraxe (Dwarven)
OUTPUTNAME:Waraxe, Dwarven	
PROFICIENCY:Waraxe (Dwarven/[Hands])
...

So removing that check might not have been such a good 
idea.  :p

I have to leave for a bit, but I'll pull and build and test when I 
get back home.

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-27 11:35

Message:
Logged In: YES 
user_id=1200673

Here is the bug :
Globals.java method handsRequired()

// Exotic weapons with [Hands] in tag
if (wp.getHands() < wCat.getHands())
{
	iHands = wp.getHands();
}

Commenting this lines solves the bug but I'm sure that there 
is a reason to have this test in the code. Anyway I've just 
found 1 weapon with "[Hands] in tag" which is the Crossbow 
hand. Following the code I'm getting another issue on 
InfoEquiping which checks the weapon-wielder size only for 
melee weapons and not for ranged ones so i'm adding a fix 
also for this.
Sorry for my english but i'm quite tired :-)
Please check the new source uploaded to cvs which should 
fix the bug.

----------------------------------------------------------------------

Comment By: Chris Chandler (barako)
Date: 2005-02-27 11:27

Message:
Logged In: YES 
user_id=607889

Ok, did a fresh pull/build and the only issue remaining 
appears to be what forken said.  :)

I created a human fighter and then customized a longsword 
from within the program to be Large and gave it to him.  He 
should only be able to wield it two handed but he's offered all 
options when you go to equip it.

If I can provide any other info let me know.

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-27 10:44

Message:
Logged In: YES 
user_id=1200673

I confirm, the only problem in the last cvs source is that it 
should allow you to wield (let's say for a medium chararcter) a 
large longsword only as a two handed weapon.

> Enrico, do you think you will be able to close this by weds?

If you mean by "wednesday" I don't know, I'll check the code.

TheForken

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-02-27 10:20

Message:
Logged In: YES 
user_id=107647

Chris, I just tested on the current code, and a medium sized
guy could *not*  equip anything over large weapons.

This is on the current CVS code

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-02-27 10:06

Message:
Logged In: YES 
user_id=107647

Enrico, do you think you will be able to close this by weds?

----------------------------------------------------------------------

Comment By: Chris Chandler (barako)
Date: 2005-02-27 07:56

Message:
Logged In: YES 
user_id=607889

NO.

This tag is still not working properly.

The Cloud giant wields a Gargantuan Morningstar 
*TwoHanded*.

Using the RSRD I put 
in "BONUS:WEAPONPROF=Morningstar|WIELDCATEGORY|
-1" fo rthe race and created a Gargantuan Morningstar (which 
is a one handed weapon for a Gargantuan creature).  The 
WIELDCATEGORY bonus should make it usable in Two 
handed mode only by the Cloud Giant (since it would be 
considered one size category up from his Large size).  

This does not happen.  He is offered ALL methods of 
equipping it (one hand primary, one hand off, two handed, etc).

*sigh*  Ok further testing reveals that the program is no longer 
restricting your method of equipping based on weapon size.  
Create a Medium PC and a Gargantuam anythign and equip 
it... it lets you....  should this be another bug tracker???  then 
when that's fixed we can test this one again?

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-27 06:52

Message:
Logged In: YES 
user_id=1200673

So, shall we delete this bug ??

TheForken

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-02-27 05:16

Message:
Logged In: YES 
user_id=208239

Off the top of my head....

BONUS:COMBAT|TOHIT.TwoHanded|2

Add whatever PRExxx you want there as well....  We want SOME
form of BONUS:COMBAT|TOHIT

Tir Gwaith
LST Chimp

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-02-26 18:56

Message:
Logged In: YES 
user_id=886893

Fair enough. Do we have a BONUS that can do that or is this something 
ww will need to work up a spec for?

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-02-26 18:03

Message:
Logged In: YES 
user_id=208239

Tag is not designed to nullify the -2 penalty, and I don't
think it should.  You could have an ability that allows the
usage, but still with the penalty (i.e. you can use it, just
not well) and another one that allows usage and removes
penalty (i.e. you can use it like a normal weapon of proper
size).

The nullifying a penalty I think should be a separate BONUS
statement.

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-02-26 16:53

Message:
Logged In: YES 
user_id=886893

Barak, you will need to use BONUS:WIELDCATEGORY|TwoHanded|-2 for 
you example above because Gargantuan is 2 sizes up from Large. I've just 
tested a medium sized creature with this tag and it did allow him to wield a 
large twohanded weapon when a normal medium creature could not. So it 
apears this tag is doing what it's supposed to.

However we have an additional issue, though it allows him to wield the 
weapon it still does so with the -2 penalty due to size. I'm not sure if this 
tag is supposed to counter that or if some other tag needs to do that but I 
don't know if there is another tag which can.

If this is the case this may turn into a freq as the tag may not have been 
designed to nullify the size penalties. Someone more familiar with the 3.5 
weapon size coding may need to coment on this.

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-26 14:39

Message:
Logged In: YES 
user_id=1200673

In fact as defined in the miscinfo.lst :

# Light weapon vs PC size changes
WIELDCATEGORY:Light	
	PREVARLTEQ:EQUIP.SIZE.INT,PC.SIZE.INT-1
	SWITCH:ToSmall
WIELDCATEGORY:Light	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT+1
	SWITCH:OneHanded
WIELDCATEGORY:Light	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT+2
	SWITCH:TwoHanded
WIELDCATEGORY:Light	
	PREVARGTEQ:EQUIP.SIZE.INT,PC.SIZE.INT+3
	SWITCH:ToLarge

# OneHanded weapon vs PC size changes
WIELDCATEGORY:OneHanded	
	PREVARLTEQ:EQUIP.SIZE.INT,PC.SIZE.INT-2
	SWITCH:ToSmall
WIELDCATEGORY:OneHanded	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT-1
	SWITCH:Light
WIELDCATEGORY:OneHanded	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT+1
	SWITCH:TwoHanded
WIELDCATEGORY:OneHanded	
	PREVARGTEQ:EQUIP.SIZE.INT,PC.SIZE.INT+2
	SWITCH:ToLarge

# TwoHanded weapon vs PC size changes
WIELDCATEGORY:TwoHanded	
	PREVARLTEQ:EQUIP.SIZE.INT,PC.SIZE.INT-3
	SWITCH:ToSmall
WIELDCATEGORY:TwoHanded	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT-2
	SWITCH:Light
WIELDCATEGORY:TwoHanded	
	PREVAREQ:EQUIP.SIZE.INT,PC.SIZE.INT-1
	SWITCH:OneHanded
WIELDCATEGORY:TwoHanded	
	PREVARGTEQ:EQUIP.SIZE.INT,PC.SIZE.INT+1
	SWITCH:ToLarge

If I understand well reading this file having 
BONUS:WIELDCATEGORY|ALL|-1
 allows the character to wield large light weapon only. To 
equip a oneHanded weapon you should have a -2 and -3 for a 
twohanded weapon

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-26 14:13

Message:
Logged In: YES 
user_id=1200673

Ok it seems that you can wield only large light Martial 
Weapons, no Simple and no one or two handed Martial 
Weapons.

Btw PCG 5.7.13 has much more problems with weapons 
size. Maybe someone fixed an old bug and tested it only with 
a light Martial Weapon.

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-02-20 16:51

Message:
Logged In: YES 
user_id=886893

I've attached a zip with a half giant character and an updated 
rsrd_races__base_psionic.lst file. The race has been given this bonus:

BONUS:WIELDCATEGORY|ALL|-1

Which should allow it to wield large weapons. Instead, when trying to 
equip a weapon like a large longsword, the only options given are carried 
and not carried.

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-20 09:17

Message:
Logged In: YES 
user_id=1200673

Could you please provide me a character to test it?

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2005-02-20 08:54

Message:
Logged In: YES 
user_id=208239

"WIELDCATEGORY:" by itself is a GameMode tag, specifically
in Miscinfo.lst - check out the 35e GameMode files.

"BONUS:WIELDCATEGORY|" is a tag to adjust the category for
different races, feats, etc.  Adjusts for ability to wield
for larger weapons, and different BONUSes for weapon size.

One place to start checking around is
"pcgen\src\java\pcgen\core\bonus\WeildCategory.java"

Tir Gwaith

----------------------------------------------------------------------

Comment By: Enrico Canardi (theforken)
Date: 2005-02-19 12:05

Message:
Logged In: YES 
user_id=1200673

Sorry boys but I can't find any WIELDCATEGORY tag in 
standards .lst is this the correct tag to do the "Oversizing" ??

TheForken

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-01-23 15:35

Message:
Logged In: YES 
user_id=107647

I could swear this was fixed some time ago.  Is this bug
actually still valid?

Devon

----------------------------------------------------------------------

Comment By: Paul W. King (kingpaul)
Date: 2005-01-23 12:18

Message:
Logged In: YES 
user_id=277877

This needs to be fixed due to various creatures in the xRDs. 
Increasing priority.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=988351&group_id=25576

[Pcgen-trackers] [ pcgen-Bugs-988351 ] BONUS:WIELDCATEGORY not working

RPG character generator for RPG d20 systems.

[Pcgen-trackers] [ pcgen-Bugs-988351 ] BONUS:WIELDCATEGORY not working