Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1112572 ] Negative Bonuses not stacking correctly
|
From: SourceForge.net <no...@so...> - 2005-02-18 04:33:32
|
Bugs item #1112572, was opened at 2005-01-30 10:05 Message generated for change (Comment added) made by ericbeaudoin You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1112572&group_id=25576 Category: None Group: None Status: Open Resolution: None Priority: 7 Submitted By: Eddy Anthony (eddyanthony) Assigned to: Nobody/Anonymous (nobody) Summary: Negative Bonuses not stacking correctly Initial Comment: When a typed bonus such as this: BONUS: COMBAT|AC|4|TYPE=Dodge is applied more then once PCGen will only apply the higher value. If the number is negative however PCGen will keep subtracting it regardless of type. Example: BONUS:COMBAT|AC|-4|TYPE=Dodge|PREAPPLY:ANYPC When this is applied multiple times it keeps adding up, the same bonus line with a positive number only grants it once. I had thought this was because of some game rule I wasn't aware of but Eric suggests this is indeed a bug. Originaly I discovered this working with Temporary Bonuses but I've tested it as standard bonuses granted by appying a template and I get the same results. This renders all negative bonuses essentially typeless. Assigning to Paul to set priority ---------------------------------------------------------------------- >Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-02-17 23:33 Message: Logged In: YES user_id=324612 Just to make this a bit clearer, Circonstance and Dodge types stack because they are defined in the system\specials\bonusstacks.lst file. You could also have the Luck bonus stack by using TYPE=Luck.STACK. I never encountered a typed negative bonus but if we ever do, we can always use a variable to have the "worst one" win the stack as in: DEFINE:NegBonus|0 BONUS:COMBAT|AC|-NegBonus BONUS:VAR|NegBonus|2|TYPE=BadLuck BONUS:VAR|NegBonus|4|TYPE=BadLuck The result of this example would be a AC negative bonus of - 4. I really don't think we should bother for a special syntax for bonus that stack in reverse until we really need it. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-02-17 18:52 Message: Logged In: YES user_id=886893 You are combining the problems, TYPE=Circumstance should stack. to test all situations do this: 1) Change both bonuses to positive numbers, they should stack because it is TYPE=Circumstance 2) change to TYPE=Dodge, they should still stack because TYPE=Dodge is also supposed to stack, at one point I found this was not staking and if its still not then thats a problem. 3) change to TYPE=Luck, now it should NOT stack but take the best one. 4) still with TYPE=Luck change to negative numbers, it should not stack but take the best one but I think you will find that it adds them together. The negative number with a non-stakablt type is a problem. ---------------------------------------------------------------------- Comment By: Enrico Canardi (theforken) Date: 2005-02-17 17:57 Message: Logged In: YES user_id=1200673 Erik's Bracers of Armor +1 TYPE:Magic.Wondrous.Bracer COST:1000 WT:1 SLOTS:2 SOURCEPAGE:MagicItemsV.rtf BONUS:COMBAT|AC|-1|TYPE=Circumstance Erik's Amulet of Armor +4 TYPE:Magic.Wondrous.Amulet COST:1000 WT:1 SLOTS:2 SOURCEPAGE:MagicItemsV.rtf BONUS:COMBAT|AC|-1|TYPE=Circumstance Sorry But I don't get this two stacked, are there any errors in my lst? ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-02-17 17:55 Message: Logged In: YES user_id=886893 and no I'm not sure how they should stack, I'm going by what's in the docs at this point. It says with like bonuses PCGen will take the highest bonus, it follows that a -1 is higher than a -5. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-02-17 17:52 Message: Logged In: YES user_id=886893 In game mechanics all penalties in 3.5 (negative bonuses) are typeless, so to set this properly in LST we don't use a type for those. This is probably not the case for all d20 games however. This is less a question of game mechanics than what the data monkeys expect PCGen to do, there may be times when adding a type to a penalty solves a problem that has more to do with how thing are do in PCGen than how the mechanics work. ---------------------------------------------------------------------- Comment By: Enrico Canardi (theforken) Date: 2005-02-17 17:46 Message: Logged In: YES user_id=1200673 Ok, got the problem, but are you sure that in the negative case should "win" the -1 ?? I mean these are malus not bonus so the worst one should prevail not the best. TheForken ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-02-17 17:33 Message: Logged In: YES user_id=886893 There are at least to problems here, they may be distinct or they may be related. I can only tell you how the program behaves, I don't code. Problem #1 negative typed bonuses should not stack. Example: BONUS:COMBAT|AC|-1|TYPE=Luck BONUS:COMBAT|AC|-4|TYPE=Luck BONUS:COMBAT|AC|-8|TYPE=Luck If a PC had all these from various sources he should get only a -1 because that is the highest one and TYPE=Luck should not stack, If the bonuses were positive like so: BONUS:COMBAT|AC|1|TYPE=Luck BONUS:COMBAT|AC|4|TYPE=Luck The result would be 4, becuase it is the highest. In fact when the bonuses are positive it does work this way but when they are negative the get stacked as if there were no type. So the first three bonuses produce a result of -13 instead of -1. Problem #2 Bonuses for the specials\bonusstacks.lst should stack but are not. BONUS:COMBAT|AC|2|TYPE=Dodge BONUS:COMBAT|AC|4|TYPE=Dodge If a PC has these 2 bonuses they should stack even though they are typed because Dodge is in the bonusstacks.lst file. These types always stack but in my testing i found that they did not and were behaving like other typed bonuses. Oddly I found TYPE=Circumstance, which also is in that file, was stacking the way it should. ---------------------------------------------------------------------- Comment By: Enrico Canardi (theforken) Date: 2005-02-17 14:14 Message: Logged In: YES user_id=1200673 So, wrapping up The problem is just that positive bonus doesn't stack as they should ?? TheForken ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2005-01-30 10:46 Message: Logged In: YES user_id=886893 Just my luck I pick Dodge to test with :p As it happens I tested three bonuses, one of which uses TYPE=Dodge. The other two use TYPE=Temporary and yielded the same results, positive - doesn't stack, negative - stacks. On your suggestion I checked the dodge stacking, its seems we have a larger problem. A positive Dodge bonus did not stack as it should have. Tested with the 5.7.14 release. Thanks Eric, your message was not misleading at all, I'd forgotten about the special stacking types. ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-01-30 10:28 Message: Logged In: YES user_id=324612 You didn't mention Dodge in the original message Eddy (or I didn't see it). Dodge stack by default. (see specials\bonusstacks.lst) So, we have a bug here only if for some reason Dodge stoped stacking with positive numbers. The fact that it stack with negative normal is the expected behavior. I'm sorry if I mislead you. I'm putting the status to pending until you can verify this Eddy. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1112572&group_id=25576 |