[Pcgen-github] [PCGen/pcgen] 51e808: fix: Export & OptionsPath dialog layout + localiza...

[Vest <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/PCGen/pcgen
  Commit: 51e808a9b62d30fd7b1c60c993aa5584b28a0c0d
      https://github.com/PCGen/pcgen/commit/51e808a9b62d30fd7b1c60c993aa5584b28a0c0d
  Author: Vest <Ve...@us...>
  Date:   2026-08-31 (Mon, 31 Aug 2026)

  Changed paths:
    M code/src/java/pcgen/gui3/dialog/OptionsPathDialogController.java
    M code/src/resources/pcgen/gui3/dialog/ExportDialog.fxml
    R code/src/resources/pcgen/gui3/dialog/OptionsPathDialog.css
    M code/src/resources/pcgen/gui3/dialog/OptionsPathDialog.fxml
    M code/src/resources/pcgen/lang/LanguageBundle.properties

  Log Message:
  -----------
  fix: Export & OptionsPath dialog layout + localization (#7719)

* UI: Refactor ExportDialog layout, fix padding, and correct entireParty localization

(cherry picked from commit 1670011ca52af13c0d774ad2431d3f09a32d1bf0)

* i18n: move Export dialog labels into LanguageBundle

Replace the hardcoded Select Character / Entire Party / Export To label
text with %in_export* keys resolved from LanguageBundle, so the dialog is
localizable. English defaults live in the base bundle; other locales fall
back to it until translated.

* UI+i18n: restructure OptionsPathDialog and localize its text

Pin all inputs to the top and the OK button to the bottom via AnchorPane
anchors (replacing the BorderPane whose sizeToScene clipped the button),
tighten spacing, and move the label/radio/OK text into LanguageBundle
%in_optionsPath* keys. English defaults live in the base bundle; other
locales fall back until translated.

* UI: rework OptionsPathDialog layout, fix toggle group, enforce min size

Switch the root from AnchorPane to BorderPane so the OK button (bottom)
can never overlap the inputs (center) at any window size, fixing the
button clipping.

- Collapse the duplicated directoryGroup ToggleGroup back to a single
  $directoryGroup reference so all five radios share one group and stay
  mutually exclusive.
- Enforce the FXML root min size on the Stage (JavaFX applies a node's
  minWidth/minHeight to layout only, not the window) via a controller
  hook measured in onShown.
- Drop OptionsPathDialog.css: its only rule drew a stray border box
  around the prompt label; padding/spacing stay inline in the FXML to
  match the other dialogs.

* UI: simplify OptionsPathDialog by removing unnecessary fx:id from RadioButton

* UI: unify dialog spacing at 6px and trim FXML comments

Normalize ExportDialog and OptionsPathDialog to a uniform 6px spacing
so the two dialogs share one visual rhythm, and drop the changelog-style
FXML comments plus condense the min-size controller comments.

---------

Co-authored-by: Clayton Stence <cps...@gm...>



To unsubscribe from these emails, change your notification settings at https://github.com/PCGen/pcgen/settings/notifications