[Pcgen-github] [PCGen/pcgen] d3d8a1: build.gradle, reporting.gradle: small cleanups (#7...

[Vest <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/PCGen/pcgen
  Commit: d3d8a1f41388d5aec030ebaa3d3aff3ff4dafb5a
      https://github.com/PCGen/pcgen/commit/d3d8a1f41388d5aec030ebaa3d3aff3ff4dafb5a
  Author: Vest <Ve...@us...>
  Date:   2026-06-06 (Sat, 06 Jun 2026)

  Changed paths:
    M build.gradle
    M code/gradle/reporting.gradle

  Log Message:
  -----------
  build.gradle, reporting.gradle: small cleanups (#7584)

* build.gradle: drop stray println debug statements

Four leftover debug printlns from earlier work, all firing in tasks
where Gradle's own logging already covers the same information. The
last one ("Args for for") also has a typo and fires once per JavaCompile
invocation, making it the loudest of the four.

* build.gradle: fix stale 'Developer build' header comment

'gradle' with no args runs the help task (default since Gradle 7), not
a developer build, since no defaultTasks is declared. Replace the
misleading line with 'gradle tasks' to point at the actual discovery
command.

* reporting.gradle: load Spotbugs Confidence via Class.forName, not findLoadedClass

ClassLoader.findLoadedClass returns null if the class hasn't already
been loaded by some other code path -- a race waiting to happen for
'reportLevel = SpotBugsConfidence.LOW'. Class.forName(name, true, loader)
actively triggers loading, so the lookup is deterministic.

A bare 'import com.github.spotbugs.snom.Confidence' won't work: this
file is applied via 'apply from:', so it's compiled before the
spotbugs plugin's classes are visible to it.

* build.gradle: keep compiler-args println (without the typo)

Restore the line dropped in 06c505789b for the JavaCompile configurator.
It prints the resolved --module-path / --add-modules / --add-exports
list per source set, which is genuinely useful when a JavaFX or
mods/lib path stops resolving. The other three printlns dropped in
that commit (copyToLibs, downloadJavaFXLocal, extractJavaFXLocal) stay
gone -- they were pure 'I'm here' markers that --info already covers.

Also fixes the original 'for for' typo.



To unsubscribe from these emails, change your notification settings at https://github.com/PCGen/pcgen/settings/notifications