[Pcgen-trackers] [ pcgen-Bugs-849432 ] Levelling Down does not remove Hidden feats

[SourceForge.net <no...@so...>]

Bugs item #849432, was opened at 2003-11-25 23:49
Message generated for change (Comment added) made by ericbeaudoin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=849432&group_id=25576

Category: Feat Support
Group: 5.6.0 RC 3
Status: Open
Resolution: None
Priority: 7
Submitted By: Martijn Verburg (karianna)
Assigned to: Eric Beaudoin (ericbeaudoin)
Summary: Levelling Down does not remove Hidden feats

Initial Comment:
RE:[TM] [pcgen] [Bug] Calculations do not take in all 
caster levels and removing prestige class does not 
remove hidden feats.

----------------------------------------------------------------------

>Comment By: Eric Beaudoin (ericbeaudoin)
Date: 2004-09-09 20:41

Message:
Logged In: YES 
user_id=324612

This is not a style issue. FEATAUTO (AUTO:FEAT and FEAT), 
and ADD:FEAT do not have the same role and cannot be used 
interchansibly. The ADD:* tags display a chooser, the 
AUTO:* do not.

There were a few places in the .lst that ADD:* was  used 
intead of the non-chooser version but that was done to work 
around limitations or bugs in PCGEN.

----------------------------------------------------------------------

Comment By: Michael Beaver (michaelbeaver)
Date: 2004-09-09 12:34

Message:
Logged In: YES 
user_id=23904

OK this seems like a style issue.  We need to Identify which
sets use ADD:FEAT vs.  FEATAUTO and schedule them to be
fixed and tested.

----------------------------------------------------------------------

Comment By: Frugal (frugal)
Date: 2004-07-29 06:58

Message:
Logged In: YES 
user_id=4807

Ah! I see the problem. 

If you use FEATAUTO then the feat is never added to the
Character directly it is always retrieved from the
appropriate class level. 

If you use ADD:FEAT then you are adding a feat to the
character directly. The newly added feat has no way of
knowing that it came from a class level, therefore there is
no way of removing the feat when the class level is removed...

What we need to do is either: 

- have a mechanism for associating every object (A) assigned
to a character with the object (B) that assigned it. That
way, when we remove object (B) we can look at every object
in the PlayerCharacter and remove object (A)

- or never add secondary objects directly to the
PlayerCharacter. If a class level adds a feat then it should
be stored inside the level object, not the character object...

Warning: Here be Dragons!!! This will not be an easy change
to do.

----------------------------------------------------------------------

Comment By: Andrew McDougall (tir-gwaith)
Date: 2004-07-28 21:16

Message:
Logged In: YES 
user_id=208239

Concrete example:

Add Ftr1
Add Cleric 1.
Remove Cleric 1.
Note that the Feats number isn't back down, and that the 
Turning SA is still there (albeit with zeros since the BONUS 
statements evaluate to zero now).
Remove Ftr 1.  
Note that the feats stuff has totally reset.  So when all class 
levels are gone, everything is taken care of.  Just not some 
of the times when doing partial leveling down.  


----------------------------------------------------------------------

Comment By: Frugal (frugal)
Date: 2004-07-26 09:54

Message:
Logged In: YES 
user_id=4807

Created a Ftr1 character with RSRD. Added a level of Monk.
AC went up due to hidden "Monk AC" feat added via FEATAUTO.
Remoevd level of monk. AC went down again...

Seems to work for me. Unless anyone can provide a concrete
example this tracker should be closed as fixed.

----------------------------------------------------------------------

Comment By: Paul W. King (kingpaul)
Date: 2004-05-31 06:26

Message:
Logged In: YES 
user_id=277877

Is this still a valid tracker?

Paul W. King
OGL SB, PL Chimp, Data Tamarin, TM Lemur, BoD

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2004-02-25 22:47

Message:
Logged In: YES 
user_id=252169

OK, this is still a problem under RC3.

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2004-02-11 20:41

Message:
Logged In: YES 
user_id=252169

We _almost_ have levelling down working perfectly, lets knock 
this over!

----------------------------------------------------------------------

Comment By: Thunder Denton (thunderdenton)
Date: 2003-11-26 11:05

Message:
Logged In: YES 
user_id=918226

I added a seperate issue for the calculations.  This issue may 
take a few versions to get fixed and the other one is more 
important and worked at one time.

This issue:

Work arounds I use are:
Unhide hidden feats to allow them to be removed.  
Edit the character pcg file to remove the feats.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=849432&group_id=25576