[Pcgen-github] [PCGen/pcgen] 8d90d5: [codequal] minor java QoL improvements (#6592)

[Eitan A. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/PCGen/pcgen
  Commit: 8d90d51e463cee2c1c0c60f77feb5788040b38b0
      https://github.com/PCGen/pcgen/commit/8d90d51e463cee2c1c0c60f77feb5788040b38b0
  Author: Eitan Adler <433...@us...>
  Date:   2021-09-23 (Thu, 23 Sep 2021)

  Changed paths:
    M code/src/java/pcgen/cdom/facet/base/AbstractCNASEnforcingFacet.java
    M code/src/java/pcgen/cdom/helper/ClassSkillChoiceActor.java
    M code/src/java/pcgen/core/BonusManager.java
    M code/src/java/pcgen/core/character/SpellBook.java
    M code/src/java/pcgen/gui2/doomsdaybook/NameGenPanel.java
    M code/src/java/pcgen/gui2/facade/Gui2InfoFactory.java
    M code/src/java/pcgen/io/PCGVer2Creator.java
    M code/src/test/pcgen/persistence/lst/DataTest.java
    M code/src/utest/pcgen/cdom/formula/testsupport/AbstractModifier.java

  Log Message:
  -----------
  [codequal] minor java QoL improvements (#6592)

- prefer enhanced for over while
- prefer pattern variables where possible
- prefer EnumMap where possible