Menu
▾
▴
[Pcgen-team-content] [JIRA] (DATA-3651) Undoing a "Race Builder" Race Selection
|
From: JIRA (f. S. S. ) <ji...@pc...> - 2018-05-16 12:13:45
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"> <base href="https://pcgenorg.atlassian.net"> <title>Message Title</title> </head> <body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429"> <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> <!-- header here --> <tbody> <tr> <td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px"> <table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/de7fa14f8d91bd8d7b626b8d485f033f?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2Fde7fa14f8d91bd8d7b626b8d485f033f%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td> <td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="bdragon" id="email_bdragon" href="https://pcgenorg.atlassian.net/secure/ViewProfile.jspa?name=bdragon" style="color:#3b73af;; color: #3b73af; text-decoration: none">Simone Spinozzi</a> <strong>created</strong> an issue </td> </tr> </tbody> </table> </td> </tr> <tr> <td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px"> <table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate"> <tbody> <tr> <!-- there needs to be content in the cell for it to render in some clients --> <td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://pcgenorg.atlassian.net/browse/DATA" style="color: #3b73af; text-decoration: none">Data</a> / <a href="https://pcgenorg.atlassian.net/browse/DATA-3651" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-efc492f7-6fa7-43cd-9858-974cf87cb6b9" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://pcgenorg.atlassian.net/browse/DATA-3651" style="color: #3b73af; text-decoration: none">DATA-3651</a> </td> </tr> <tr> <td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://pcgenorg.atlassian.net/browse/DATA-3651" style="color: #3b73af; text-decoration: none">Undoing a "Race Builder" Race Selection</a> </span> </td> </tr> </tbody> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff"> <table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th> <td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-efc492f7-6fa7-43cd-9858-974cf87cb6b9" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"> Bug </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Affects Versions:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 6.07.08 </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Components:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Pathfinder Game System </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 16/May/18 5:13 AM </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Environment:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Microsoft Windows [Version 10.0.16299.431] <br> java version "1.8.0_172" <br> Java(TM) SE Runtime Environment (build 1.8.0_172-b11) <br> Java HotSpot(TM) 64-Bit Server VM (build 25.172-b11, mixed mode) </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th> <td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-minor-024dd452-6682-4dd9-8307-ea83af2f7768" height="16" width="16" border="0" align="absmiddle" alt="Minor" style="vertical-align: text-bottom"> Minor </td> </tr> <tr> <th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th> <td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="bdragon" id="email_bdragon" href="https://pcgenorg.atlassian.net/secure/ViewProfile.jspa?name=bdragon" style="color:#3b73af;; color: #3b73af; text-decoration: none">Simone Spinozzi</a> </td> </tr> </tbody> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff"> <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px"> <tbody> <tr> <td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0">How to reproduce:</p> <ul class="alternate" type="square"> <li>Build character and selecting "race builder", make a few choices then save</li> <li>reload character</li> <li>change race to another race</li> </ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">this tends to corrupt the new race by undoing several things. Examples follow:</p> <ul class="alternate" type="square"> <li>if the old race had no constitution (such as constructs or undead selections from the race builder) the new race will be assigned an undead template</li> <li>if the old race had a humanoid subtype which was cleared the new race will not have the new subtype if it is the same subtype (if the old race had humanoid/human subtype and the new race is human, it will not have the human subtype)</li> <li>other problems similar to the above</li> </ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">At first glance, given what kind of errors i get i think it is a problem based on how templates are cleared when the "race builder" race is involved. It seems that PCGen does the following (based on how it behaves)</p> <ul class="alternate" type="square"> <li>removes the "Race builder race" and its templates, but not what the templates have called as part of their construction (such as lack of constitution in case of a construct or undead selection).</li> <li>adds the new race</li> <li>parses everything for inconsistencies removing anything that is "doubled" (in my example above the "human" subtype).</li> <li>makes a few decisions based on what it finds (adding a the very first undead template it finds if no constitution is present such as in the example above).</li> <li>then everything else from the old race gets cleared (such as the "humanoid/human" piece which results missing after all the above is cleared).</li> </ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I might be wrong but it seems to me that this order of events is what creates the problem.</p> </td> </tr> </tbody> </table> </td> </tr> <tr> <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json"> { "@context": "http://schema.org", "@type": "EmailMessage", "description": "View Issue", "potentialAction": { "@type": "ViewAction", "target": "https://pcgenorg.atlassian.net/browse/DATA-3651?inbox=true&", "name": "View Issue" }, "publisher": { "@type": "Organization", "name": "Atlassian", "url": "https://www.atlassian.com" } } </script> <table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <tbody> <tr> <td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0"> <table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://pcgenorg.atlassian.net/browse/DATA-3651#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-10718e54-854c-4090-bb00-9a3600b003fd" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td> <td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://pcgenorg.atlassian.net/browse/DATA-3651#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> </td> </tr> <!-- there needs to be content in the cell for it to render in some clients --> <tr> <td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td> </tr> </tbody> </table> </td> </tr> <tr> <td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px"> <table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a> <hr> </td> </tr> <tr> <td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100085-<span title="b975c1b22340f6f935f00b2b36266fa2062a88b0" data-commit-id="b975c1b22340f6f935f00b2b36266fa2062a88b0}">sha1:b975c1b</span>)</span> </td> <td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top"> <table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> <tbody> <tr> <td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-067f7bc7-dd0f-42c7-882a-501f17371fc8" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> </td> </tr> </tbody> </table> <img src="https://u4043402.ct.sendgrid.net/wf/open?upn=m-2Brq8F6BKB5IDp23hK0JJjZqcdUOX7eBuAN1kM4g0NvOexBNBxoAr0IjrxWHqnGj6hRXpjXoYFeJOwwoq5neN5IYUblv-2FYzAsVzH3cnwy9-2BHX0UgN9YwCLa0B1lUCb-2F7xr7S7vYaAwlRAeKRW2tIYksu2Y0SSaoZ7BtfF91z9FP-2BOCRKC6aP9M-2BaeOmheFyaZwlGIX114hKFuiuZjlvvWd-2FfgFOQG71Hg4WWc-2FZIjS2JY3zcn2BvKp0OQ0sC0-2BbfVc5TY2e60LjP2IxPLerSlRrFHEnELhOg-2BL98x9St5W01kbGdv3aOuzbrQssUCKik4qezjX9P4Nrz5XkE5wssNHhgxTLO3QsWZHOV2kZYGZ-2BBaPcpgy5vqvim7IRsQYTjQBJrnRjSZDNObN-2FpdTU8CklIBrJM8VsoJLoiy4CxJBOGstTP7K6pc9s311GCPYeWG92qZ-2F2IFdEy0nj7sdrughPht00Viisu81s6CFtJnO0-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/> </body> </html> |