Menu
▾
▴
[Pcgen-trackers] [JIRA] (CODE-1580) Font doesn't look good
|
From: JIRA (f. V. L. ) <ji...@pc...> - 2012-09-06 13:44:00
|
<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?avatarId=10135" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="masaru20100" id="email_masaru20100" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=masaru20100" style="color:#3c78b5;">Vincent Lhote</a>
commented on <img src="http://jira.pcgen.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-1580'>CODE-1580</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/CODE-1580"><strong>Font doesn't look good</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">I recommend avoiding doing some complex font selection. Instead use the logical font name provided in Java by the font class. If the user want to change the font used, the font configuration file of Java can be edited. That means using SANS_SERIF instead of "Verdana".
<br/>
<br/>
Another reason to avoid that is because fonts are also Look and Feel dependent. I found out why I felt it didn’t looked good when I changed l&f, it’s because the font in the panel doesn’t change along with the rest. The problem was not really Verdana but the Dialog font used in many classes. This logical font, Dialog, is used on the (old) Java L&F. If I use Nimbus or System L&F, Dialog is not used and everything looks good, except the summary tab.
<br/>
<br/>
To solve the problem, I would recommend removing setting the font, and keeping the l&f default.
<br/>
Another solution would be to remove them, and use Font.deriveFont to change the size or style of fonts when needed. I think you need really good reason to change those value from the default l&f ones.
<br/>
I did some test commenting those font changes, and found out that the summary tab is better looking. I could provide a clean patch removing those, but I have a feeling that you might not want to do that.
<br/>
<br/>
By the way the only font I have on that list is DejaVu Sans and it is not used in my graphical environment.</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->
|
