Menu
▾
▴
[Pcgen-trackers_code] [JIRA] (CODE-1236) Button that act on list have to be disabled when there is no item selected in the list
|
From: JIRA (f. V. L. ) <ji...@pc...> - 2012-02-10 16:20:58
|
<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#114070" style="background-color:#114070;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="http://jira.pcgen.org/secure/useravatar?ownerId=masaru20100&avatarId=10421" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="masaru20100" id="email_masaru20100" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=masaru20100" style="color:#3c78b5;">Vincent Lhote</a>
created <img src="http://jira.pcgen.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#3c78b5;text-decoration:none;' href='http://jira.pcgen.org/browse/CODE-1236'>CODE-1236</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style="color:#3c78b5;text-decoration:none;" href="http://jira.pcgen.org/browse/CODE-1236"><strong>Button that act on list have to be disabled when there is no item selected in the list</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="http://jira.pcgen.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> Bug
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Versions:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
CDOM UI Beta 4, CDOM UI Beta 3 </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Assignee:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
Unassigned </td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Components:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
NewUI </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Created:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
11/Feb/12 3:20 AM
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
In many places in the UI, there is two list (usually tree table, tree...) where one is a list of element to select from, and the other the selected items. There is usually buttons to move one or more item from one list to the other. The problem is that when no item are selected pressing the button doesn't do anything. Buttons that do nothing should be avoided, it confuses users.
<br/>
One solution is to disable the button when it would do nothing and enable it when it would. On those list, it means enable when an element is selected.
<br/>
Another less preferable option is a pop-up that explain that an element must be selected. Generally pop-up are considered bad design in general, that's why it's less preferable.
<br/>
Another option is to provide a list to choose from, so it means reproducing the previous screen. I don't believe it's a good idea either.
<br/>
<br/>
An example of such a screen is the Races tab panel. The template tab panel is another, so is feats, racial abilities, traits, probably archetype (no data in there in ui beta 4), domains, spells, and inventory.
<br/>
For some reason, the Classes tab works a bit differently, the add level is disabled if nothing is selected in the list. On a character without class level, the remove level button is enable, which it shouldn't as there is no level to remove. The button should not be labelled remove level, but "remove latest level" because you can't select which level to remove, which doesn't work the same way as the same kind of screen.
<br/>
<br/>
Also note that when an element in a tree can not be moved, like the Feat category or Adaptability Bonus Feat category (used for Half-Elf in Pathfinder), the button should not be enabled either, or it should remove all the child. Same for feats gained automatically by class levels, they are not removable so the button should not be doing nothing.
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Project:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a style="color:#3c78b5;" href="http://jira.pcgen.org/browse/CODE">Code</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Priority:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="http://jira.pcgen.org/images/icons/priority_major.gif" height="16" width="16" border="0" align="absmiddle" alt="Major"> Major
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Reporter:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="masaru20100" id="email_masaru20100" href="http://jira.pcgen.org/secure/ViewProfile.jspa?name=masaru20100" style="color:#3c78b5;">Vincent Lhote</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#3c78b5;' href='http://jira.pcgen.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#3c78b5;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->
|
![http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png"](http://jira.pcgen.org/s/en_US6dz1xo/664/4/_/images/jira111x30.png"){kind=link}
![http://jira.pcgen.org/images/icons/bug.gif"](http://jira.pcgen.org/images/icons/bug.gif"){kind=link}
![http://jira.pcgen.org/images/icons/priority_major.gif"](http://jira.pcgen.org/images/icons/priority_major.gif"){kind=link}