[pcgen-commit-svn] SF.net SVN: pcgen:[15548] Trunk/content/notfordistribution/ dreamscarredpress/psionicsexpanded/unlimited_possibilities

[<dis...@us...>]

Revision: 15548
          http://pcgen.svn.sourceforge.net/pcgen/?rev=15548&view=rev
Author:   distant-scholar
Date:     2011-11-17 18:27:47 +0000 (Thu, 17 Nov 2011)
Log Message:
-----------
Responses to comments made.
Issue#: NEWSOURCE-129

Added Paths:
-----------
    Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/11-17-2011_Data_Review_Response.txt

Removed Paths:
-------------
    Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/pe_unlimited_possibilities_equipmods.lst

Added: Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/11-17-2011_Data_Review_Response.txt
===================================================================
--- Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/11-17-2011_Data_Review_Response.txt	                        (rev 0)
+++ Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/11-17-2011_Data_Review_Response.txt	2011-11-17 18:27:47 UTC (rev 15548)
@@ -0,0 +1,45 @@
+> *_powers:
+> This makes no sense - 'Conceal Thoughts.COPY=Conceal Thoughts	KEY:Conceal Thoughts Talent'  Rinse Repeat. If you want to do something that SHOULD be
+> Conceal Thoughts.COPY=Conceal Thoughts Talent
+> Conceal Thoughts Talent.MOD  <> New Things; instead it looks like you're making an entirely new ability. Suggestion - Just make the new Ability and skip the .COPY. 
+
+This makes perfect sense to me.  The Conceal Thoughts 0-level power (or "spell" in PCGen terms) is almost exactly like the already-existing Conceal Thoughts 1st-level power.  Why not use copy, since it's nearly exactly the same?  For someone who isn't using the 0-level "Talents" rules, Conceal Thoughts still needs to be available as a 1st-level power.  Since the two can't have exactly the same name, the KEY: tag is needed.
+
+If we are to use .COPY on a line by itself, and then later .MOD it, why does .COPY have the additional functionality?
+
+If we are to make a new ability and skip the .COPY when two abilities are very close to each other, why have .COPY at all?
+
+
+> *_Equipmods is blank, why do we have a blank file?
+
+I removed the file; I don't know why you still saw it.  Maybe I don't know how to remove files with SVN.
+
+
+
+[Some comments rearranged for ease of response.]
+
+> *_class: Split this into a 'MOD' file for the existing classes with mods.
+
+I will do this.
+
+
+> *_abilities_favored_class:  I'm not sure this will work as intended 'BONUS:COMBAT|AC|0.25|TYPE=Armor.STACK' did it actually work for you? If Not, I recommend 'BONUS:COMBAT|AC|BonusAstralSuitAC|TYPE=Armor.STACK' and then DEFINE:BonusAstralSuitAC|0 and BONUS:VAR|BonusAstralSuitAC|count("ABILITIES","CATEGORY=Special Ability","KEY=Bonus Astral Suit AC")/4
+
+I don't remember if I actually tested this ability.  I'm not sure why I'm getting grief for this; most, if not all, of the similar abilities in the APG don't do anything at all.  I guess I'll follow the current model and remove the attempt at functionality.
+
+
+> *_equipment: Path choice could be by abilitypool as a suggestion, otherwise you'll have to code an item per path.
+
+See next response.
+
+> *_abilities_classes:
+> Craftsman - This needs to be in an abilitypool, you have a CHOICE ability that is messing up a saved character due to how it was added. If you change to granting the class an Abilitypool instead that should resolve that issue.
+
+I know I have a CHOICE ability that is messing up the saved character.  I thought I put that in the comments.
+Adding an abilitypool for these items (the equipment and the craftsman ability) seems, at best, awkward.  For the item, it would mean that anyone who wants to add a new warrior's path would have to know (and remember) that the item exists, and to add a new ability for the ability pool.  For the Craftsman ability, it would mean that anyone who adds a new Craft skill would have to add a new ability; for such writers, they might not even realize that psionics exists!
+
+
+> * alternate race traits:
+> Lots of entries about having issue saving after a choose, which choose is failing and do you a JIRA for the bug?
+
+These have (or I assumed would have) the same issue that Craftsman has above; I assumed there was already a JIRA for it since otherwise I wouldn't have recognized what was going on.  I'll see if I can track down which one it is.

Deleted: Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/pe_unlimited_possibilities_equipmods.lst
===================================================================
--- Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/pe_unlimited_possibilities_equipmods.lst	2011-11-17 17:33:49 UTC (rev 15547)
+++ Trunk/content/notfordistribution/dreamscarredpress/psionicsexpanded/unlimited_possibilities/pe_unlimited_possibilities_equipmods.lst	2011-11-17 18:27:47 UTC (rev 15548)
@@ -1,5 +0,0 @@
-# CVS $Revision: $ $Author: $ -- Sun Jul 31 16:53:43 2011 -- reformated by prettylst.pl v1.39 (build )
-SOURCELONG:Psionics Expanded - Unlimited Possibilities	SOURCESHORT:PEUP	SOURCEWEB:http://dreamscarredpress.com/dragonfly/index.php	SOURCEDATE:2011-09
-
-# ORIGINAL ENTRY: Douglas Limmer
-# ORIGINAL ENTRY DATE: 2011/

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.