[Pcgen-trackers] [JIRA] Commented: (CODE-391) TEST-47 Bug Report

[Tom P. (JIRA) <ji...@pc...>]

    [ http://jira.pcgen.org/browse/CODE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11334#action_11334 ] 

Tom Parker commented on CODE-391:
---------------------------------

Underlying issue was persistent format for CHOOSE:FEATSELECTION and AUTO:FEAT (which must be the same).
They were using AbilitySelection's persistent format, which makes things a bit ugly.  For example:
Abil <> MULT:YES <> CHOOSE:FEATSELECTION|TYPE=Foo
Tgt <> TYPE:Foo
Owner <> VFEAT:Abil(Tgt)
...should be valid.  However, using AbilitySelection's persistent format, it would be:
Owner <> VFEAT:Abil(CATEGORY=FEAT|NATURE=Normal|Tgt)
(The Nature could be any valid nature and would be ignored)
This is obviously UGLY.
Thus, the persistent format for CHOOSE:FEATSELECTION and AUTO:FEAT should be changed to be the "full ability key".  Thus:
Owner <> VFEAT:Abil(Tgt)
becomes legal.

Of course, this does raise how CHOOSE:ABILITYSELECTION will work once that is implemented - it will, by its nature, have an unpleasant persistent format.



> TEST-47 Bug Report
> ------------------
>
>                 Key: CODE-391
>                 URL: http://jira.pcgen.org/browse/CODE-391
>             Project: Code
>          Issue Type: Bug
>    Affects Versions: Not Released
>         Environment: TEST-47 Bug
>            Reporter: Andrew Maitland
>            Assignee: Tom Parker
>
> 21:43:44.585 SEVERE AWT-EventQueue-1 InfoAbility:691 Failed to add ability due to
> java.lang.IllegalArgumentException: String in getAbilitySelectionFromPersistentFormat must start with CATEGORY=, found: NoChooseFeat
>         at pcgen.cdom.helper.AbilitySelection.getAbilitySelectionFromPersistentFormat(AbilitySelection.java:257)
>         at plugin.lsttokens.auto.FeatToken.apply(FeatToken.java:256)
>         at pcgen.core.PlayerCharacter.addAssociation(PlayerCharacter.java:11697)
>         at pcgen.core.PlayerCharacter.processFeatListOnAdd(PlayerCharacter.java:11311)
>         at pcgen.core.PlayerCharacter.processAddition(PlayerCharacter.java:12564)
>         at pcgen.cdom.facet.ObjectAdditionFacet.dataAdded(ObjectAdditionFacet.java:44)
>         at pcgen.cdom.facet.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:153)
>         at pcgen.cdom.facet.AbstractSourcedListFacet.add(AbstractSourcedListFacet.java:92)
>         at pcgen.cdom.facet.CDOMObjectConsolidationFacet.add(CDOMObjectConsolidationFacet.java:39)
>         at pcgen.cdom.facet.CDOMObjectConsolidationFacet.dataAdded(CDOMObjectConsolidationFacet.java:56)
>         at pcgen.cdom.facet.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:153)
>         at pcgen.cdom.facet.AbstractSourcedListFacet.add(AbstractSourcedListFacet.java:92)
>         at pcgen.cdom.facet.CharacterConsolidationFacet.dataAdded(CharacterConsolidationFacet.java:34)
>         at pcgen.cdom.facet.AbstractDataFacet.fireDataFacetChangeEvent(AbstractDataFacet.java:153)
>         at pcgen.cdom.facet.ActiveAbilityFacet.add(ActiveAbilityFacet.java:66)
>         at pcgen.core.PlayerCharacter.addRealAbility(PlayerCharacter.java:10245)
>         at pcgen.core.PlayerCharacter.addFeat(PlayerCharacter.java:10812)
>         at pcgen.core.AbilityUtilities.modFeat(AbilityUtilities.java:599)
>         at pcgen.gui.tabs.InfoAbility.addAbility(InfoAbility.java:680)
>         at pcgen.gui.tabs.ability.AvailableAbilityPanel$2.run(AvailableAbilityPanel.java:143)
>         at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
>         at java.awt.EventQueue.dispatchEvent(EventQueue.java:461)
>         at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:2934)
>         at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:242)
>         at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:163)
>         at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:157)
>         at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:149)
>         at java.awt.EventDispatchThread.run(EventDispatchThread.java:110)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira