[Pcgen-trackers] [ pcgen-Bugs-2723877 ] PRE/REQ conflict: Child remains after parent removed

[SourceForge.net <no...@so...>]

Bugs item #2723877, was opened at 2009-04-01 07:33
Message generated for change (Settings changed) made by jdempsey
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2723877&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Feat Support
>Group: To be Fixed for 6.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: LegacyKing (amaitland)
Assigned to: Nobody/Anonymous (nobody)
Summary: PRE/REQ conflict: Child remains after parent removed

Initial Comment:
Discovered an odd bug. The NaturalAttacks remains after the removal of the granting ability.

To duplicate this:
My Ability <> CATEGORY:Special Ability <> TYPE:SpecialAttack <> NATURALATTACKS:Claws,Weapon.Melee.Slashing,*2,1d4

My Template <> ABILITY:Special Ability|AUTOMATIC|My Ability|PREVAREQ:MyVariable,1 <> DEFINE:MyVariable|0 <> BONUS:VAR|MYVariable|1|PREAPPLY:ANYPC

Add the My Template to the PC, then Apply the Template in temp modifiers. You gain the NaturalAttacks on the Character sheet. Remove the Temp Mod, Natural Attack remains on the PC.

This appears to be Parent > Child issue, with the Child remaining behind after the parent is gone.


(Tested with both AUTOMATIC and VIRTUAL natures). The Variable is bonusing correctly 1 with mod, 0 without mod.



----------------------------------------------------------------------

Comment By: Tom Parker (thpr)
Date: 2009-04-05 02:44

Message:
While this is poor behavior, it is rooted in the ambiguous definition of
PRExxx in PCGen 5.x.

In one sense, this is a problem because one could argue My Ability should
never be applied (if operating as a true Prerequisite, then the test will
fail when My Template is applied, and the PC should never receive My
Ability)

In another sense, this is a problem because one could argue My Ability
should be applied and removed, as the PRExxx serves as a Requisite (rather
than a PRE Requisite), and thus should be removed when the Ability is
removed.

Either way, the current behavior is incorrect.

Unfortunately, the 5.x core really isn't built to handle this situation,
and this Bug only goes to highlight the conflicts that drove the
architecture behind the PRE/REQ proposal (FREQ 1782186)


----------------------------------------------------------------------

Comment By: LegacyKing (amaitland)
Date: 2009-04-01 11:16

Message:
Further testing -
NATURALATTACKS token remains after the Ability granting it is removed.

The actual ability is removed (Per proper BONUS).



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2723877&group_id=25576