Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1891140 ] EQ.%.NAME.MAGIC~bt~at~bf~af converting < to <
|
From: SourceForge.net <no...@so...> - 2009-03-14 04:12:11
|
Bugs item #1891140, was opened at 2008-02-12 00:30 Message generated for change (Settings changed) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1891140&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Export Character >Group: To be fixed For 5.16.1 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Martijn Verburg (karianna) Assigned to: Martijn Verburg (karianna) Summary: EQ.%.NAME.MAGIC~bt~at~bf~af converting < to < Initial Comment: Equipment section shows: "1 x <b>Sword +1 (Short/Speed)</b> grants 1 extra attack when full attacking at highest bonus,does not stack with other speed effects" As opposed to bolding the text. Invetigating ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2009-02-27 20:14 Message: Well I ripped the ExportHandler apart (its much improved now) but we've got a Chicken and Egg situation with this particular bug. In order to 'fix' this I then break the allowing HTML in certain sections functionality that aspen introduced all that time ago. I'm going to take a fresh look again next week, it's not a showstopper for 5.16.0 though, so can be moved to 5.16.1 if I can't solve it in time. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2009-02-27 18:06 Message: Hi Kar, Is this one looking likely to be resolvable in the next couple of weeks, i.e. in time for 5.16.0? Cheers, James. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-11-04 04:32 Message: OK, even when stripping the ~<b>~</b> from the string being encoded we still get the 'wrong' result, in that the item is not bolded, I think it's time to start ripping ExportHandler apart :) ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-11-04 03:50 Message: I've dug a little deeper. ExportHandler 2412 makes a call to FileAccess.encodeWrite which in turn applies the filter rehtm.lst (which indeed has a mapping for '<' & '>' to be changed to < and >). Now it only does this if the encoding is set to true (which it always is as EqToken isEncoding() always returns true). Chuck is probably correct in that we're sending too much to the encoder, I'll try playing around a bit but don't hold your collective breath :) ---------------------------------------------------------------------- Comment By: Chuck Pint (chuckpint) Date: 2008-08-23 12:28 Message: Logged In: YES user_id=901169 Originator: NO This behavior sounds really familiar. Sounds like the entire string is going thru the "quoted" output. Only the string that is returned by the EQ tag should be quoted. The combined string of the added text plus the EQ tag text should not be quoted. I hope that makes some sense to the code monkeys. This is similar to the problem that was fixed some time ago about the problem with \n in notes. ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2008-08-23 08:50 Message: Logged In: YES user_id=208239 Originator: NO This isn't an Output sheet bug, as a Code bug in the OS code. the < > stuff is being converted to < and > when it should not be by the Token resolution mech. BTW: Docs don't mention the required ~ deliminated before true, after true, before false, after false requirements for the token (just says that .MAGIC will return BOLD - it will actually do anything, so long as it is in the before true, after true pattern - one could put ~<i>~</i> after it, and it will Italicize all the .MAGIC items. |EQ.%.NAME.MAGIC~<i>~</i>~<b>~</b>| would italicize all magic items, and bold all non-magic items.) This all happens around line 69 of EqToken.java. I hope I've shed some light on it for the better code monkeys. Somewhere the < stuff is getting turned into < when exporting, but I'm not sure where in that loop the conversion is happening. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-02-12 01:20 Message: Logged In: YES user_id=252169 Originator: YES Hmm, the code here is strange, there's an attempt at substitution going on with: x \EQ.%.NAME.MAGIC~<b>~</b>\ e.g. 1 x \EQ.2.NAME.MAGIC~<b>~</b>\ I think the replacement is then supposed to have this result: e.g. 1 x <b>EQ.2.NAME.MAGIC<\b> But unfortunately it comes out as: e.g. 1 x <b>EQ.2.NAME.MAGIC<\b> I'm not sure what process performs this substitution so I don't know where to change this behaviour, hopefully some one else can shed some light - K ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1891140&group_id=25576 |