Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-2483029 ] Stack Overflow when WeaponProf DisplayName is also a Type
|
From: SourceForge.net <no...@so...> - 2009-01-31 02:17:49
|
Bugs item #2483029, was opened at 2009-01-02 18:50 Message generated for change (Comment added) made by thpr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2483029&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: To be fixed For 5.16.0 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Kevin W. Patterson (kwp) Assigned to: Tom Parker (thpr) Summary: Stack Overflow when WeaponProf DisplayName is also a Type Initial Comment: When adding the war domain for homebrew deity, the Weapon Proficiency is granted from a selection widgit, but Weapon Focus is not grated. The Weapon Focus feat does not appear in the Feat menu as a Virtual Feat either, but Martial Weapon Prof for the selected weapon does. ---------------------------------------------------------------------- >Comment By: Tom Parker (thpr) Date: 2009-01-30 20:50 Message: Committed revision 9167. ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2009-01-30 19:30 Message: Due to recursive use of addWeaponProfToList, this is a problem. Example where this is a problem is "Dagger" which is TYPE:Dagger This causes a recursive situation. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2009-01-22 13:50 Message: This is a code bug, the tag syntax however strange was not deprecated and so should be made to work unless replacement tags are made available. ---------------------------------------------------------------------- Comment By: Maredudd (maredudd800) Date: 2009-01-03 00:48 Message: Are we sure this is a data bug? There has been no official change in the syntax, at least none that I am aware of, but as James pointed ut to me on IM, the recent rewrite of the parser may have effected the syntax. If the syntax has changed we need to identify what the new syntax is and document it. If the old 'weird' syntax no longer works, we need to decide how we will handle the deprecation warning issue. Fix the bug and make the old syntax work just long enough to deprecate it? Thats like moving backwards only to move forwards three months down the road . . . ---------------------------------------------------------------------- Comment By: Fluxxdog (fluxxdog) Date: 2009-01-02 20:47 Message: >From the docs: Special Case: CHOOSE:WEAPONPROF|1|DEITYWEAPON[WEAPONPROF][FEAT=Weapon Focus] * I cannot explain how this tag works but it does. * This tag is used in the War Domain to grant proficiency in, and the Weapon Focus feat of, the dieties Favored Weapon to the cleric that has selected that domain. * The syntax using brackets ([]) will be changed in PCGen 6.0. Looks like it time to update the syntax. Moving to Data Bugs ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2483029&group_id=25576 |