Menu
▾
▴
[Pcgen-trackers_Data] [ pcgen-Data Bugs-2155487 ] Occupation TYPEs are confused
|
From: SourceForge.net <no...@so...> - 2008-10-12 12:12:35
|
Data Bugs item #2155487, was opened at 2008-10-10 05:07 Message generated for change (Settings changed) made by jdempsey You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=750091&aid=2155487&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: For 5.16.0 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Eddy Anthony (eddyanthony) >Assigned to: Eddy Anthony (eddyanthony) Summary: Occupation TYPEs are confused Initial Comment: If found a bug while working with the MSRD. To reproduce create a character and go to the Feats & Abilities/Background sub tab and select the Occupation pool. Instead of have just the list of occupations the list also contains all the occupation skill abilities which are supposed to appear in other pools set by the choice of occupation. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2008-10-12 20:35 Message: Error on TYPE in parent added in http://pcgen.svn.sourceforge.net/pcgen/?rev=8051&view=rev I agree that the second fix is probably the best one. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2008-10-12 16:37 Message: Thanks for the explanation, I understand the situation now. There are 2 way to fix the data, both break PC's and one in an interesting way. The first is as you suggest create a new child category for the actual occupations and take out the TYPE in the parent ability. This does work but it causes a strange glitch with preexisting characters, when a PC is opened with a pre-existing occupation already selected it does not appear in the occupation pool (which is expected) but it also does not appear on the list in the left panel. The only way to fix this is to edit the pcg file and remove the occupations selections. The second fix is to create a new parent category with a different name, I used "Starting Occupation". This also works and allows the pool name to stay the same but it is more work since it means that the category for all these abilities will need to be changed to Starting Occupation. With the category changed these effectively become new abilities and when a pre-existing PC is loaded PCGen reports that the preselected abilities cannot be found and the user can then re-add the abilities in the GUI. I think we'll need to go with the second fix since it is easier on the end user. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2008-10-12 12:18 Message: This is actually working as intended sorry. Type filters are ignored on parent categories. The current MSRD ability category defs are something like the following: ABILITYCATEGORY:Occupation CATEGORY:Occupation TYPE:Occupation DISPLAYLOCATION:Background ABILITYCATEGORY:Academic Occupation Skills CATEGORY:Occupation TYPE:Academic_Skills DISPLAYLOCATION:Background The second is a child of the first. The parent contains all abilities and will display all (visible) abilities. The child is where the type can be used to filter what is displayed. Adding support for types in parents would make the categories even more complex to understand than they currently are as the parent would then be supporting a dual purpose - container for all abilities and display for some. It is far simpler to have a dedicated child category to track this group. As a result I would suggest the following actions. 1. Create a separate child category for the occupations. It may be worth renaming the parent category so that the child can be called occupation. 2. Change the code to report an error if a type is defined on a parent category. 3. Update the docs for TYPE to record the restriction. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=750091&aid=2155487&group_id=25576 |