[Pcgen-trackers] [ pcgen-Bugs-2003884 ] CHOOSE:EQBUILDER.SPELL|Arcane, Divine, Psionic|0|0 fails

[SourceForge.net <no...@so...>]

Bugs item #2003884, was opened at 2008-06-27 05:06
Message generated for change (Comment added) made by thpr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2003884&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: To be fixed For 5.14.1
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Martijn Verburg (karianna)
Assigned to: Tom Parker (thpr)
Summary: CHOOSE:EQBUILDER.SPELL|Arcane,Divine,Psionic|0|0 fails

Initial Comment:
Well, in 5.14, the crank is turned up too high on import, just tests for , and barfs if it finds it, which is incorrect... so that's Bug #1, assign to me, please.

Then I don't know about the second issue. A quick glance shows it should work, but it requires some investigation (and I'm out of time for this eve), so that's Bug #2. I assume you tested in 5.14?

TP.

--- In pc...@ya..., "Barak" <barak@...> wrote:
>
>
> I'm not sure if this is a code bug or a documentation bug.
>
> In the equipmod data:
> CHOOSE:EQBUILDER.SPELL|Arcane,Divine,Psionic|0|0
>
>
> In the docs (edited for brevity):
> Tag Name: CHOOSE:EQBUILDER.SPELL|w|x|y|z
>
> Variables Used (w): Text (Spell Type, i.e. Arcane, Divine, Psionic, ANY)
>
> - Filtering by multiple types may be done joining several types using a
> comma (,), logical AND function, or a pipe (|), logical OR function.
>
>
> Upon load:
> SEVERE plugin.lsttokens.equipmentmodifier.choose.EqBuilderSpellToken
> CHOOSE:EQBUILDER.SPELL arguments may not contain , :
> Arcane,Divine,Psionic|0|0
>
>
> So, is the bug in the docs, in the warning upon load or in the code
itself
> (I'm leaning towards the last here as a guess)?
>
> Testing the code is interesting, when I go to apply the equipmod,
the only
> type available in the chooser is Divine. I would have expected to
see the
> first or the last TYPE in the line.
>
> Barak
>

----------------------------------------------------------------------

>Comment By: Tom Parker (thpr)
Date: 2008-06-28 19:15

Message:
Logged In: YES 
user_id=1037926
Originator: NO

picklists confirmed as working as designed


----------------------------------------------------------------------

Comment By: Tom Parker (thpr)
Date: 2008-06-28 13:36

Message:
Logged In: YES 
user_id=1037926
Originator: NO

I believe bug #2 is working as designed, just may not have been intuitive
as to what is displayed in the spell type picklist... will wait to see
Barak's response on pcgen list.


----------------------------------------------------------------------

Comment By: Tom Parker (thpr)
Date: 2008-06-28 13:24

Message:
Logged In: YES 
user_id=1037926
Originator: NO

partial fix Committed revision 6926

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=2003884&group_id=25576