[Pcgen-trackers] [ pcgen-Feature Requests-1967662 ] [5.15] FAVCLASS:CHOOSE improvements

[SourceForge.net <no...@so...>]

Feature Requests item #1967662, was opened at 2008-05-19 22:46
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1967662&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Code Related (Add/Del/Improve)
Group: For 5.16.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: LegacyKing (amaitland)
Assigned to: Stefan Radermacher (zaister)
Summary: [5.15] FAVCLASS:CHOOSE improvements

Initial Comment:
Tom's Final Proposal Ammendment:
FAVCLASS:Any currently performs an automatic choice of the highest
level class of the PC, which is potentially confusing given other uses
of "Any" and "All" in our data.  This should be changed to be consistent.

In Pathfinder, the Human race doesn't use the "Any" format (above),
but gets to choose "any one class as their favored class".  PCGen
currently cannot support this feature.

FAVCLASS:CHOOSE:<blah> is not consistent with other CHOOSE: tokens,
which are of the form:
CHOOSE:SUBTOKEN|<choices>
...and which is extracted into other tokens using items like %LIST, e.g.:
TOKEN:%LIST

This proposal impacts the following tokens:
FAVCLASS (Race)
FAVOREDCLASS (Template)

This proposal drives the creation of:
CHOOSE:CLASS|x,x

Current syntax on FAVCLASS is:
FAVCLASS:x|x.y
FAVCLASS:CHOOSE:x|x.y

Current syntax on FAVOREDCLASS is:
FAVOREDCLASS:x|x.y

Proposal:

The first syntax of FAVCLASS will be expanded to add a %LIST argument.
 This %LIST argument will insert all of the items selected on the
current Race into the Player Character's Favored Class list.

The first syntax of FAVCLASS, which currently supports FAVCLASS:ANY to
perform a choice of the highest class on a PC will be changed to
FAVCLASS:HIGHESTLEVELCLASS

The second syntax (FAVCLASS:CHOOSE:x|x.y) will be deprecated, to be
replaced by a separate CHOOSE token and the enhanced FAVCLASS (above)

FAVOREDCLASS will be expanded to add a %LIST argument.  This %LIST
argument will insert all of the items selected on the current object
(Template) into the Player Character's Favored Class list.

CHOOSE:CLASS|x,x

A new Chooser will be added to PCGen, allowing the choice of classes.
Valid entries for x will be:
ANY (any Class)
TYPE=y (specifies a type, can be chained to perform AND, e.g. TYPE=y.y)
x (any primitive class, e.g. Fighter)
x.y (any specific subclass, e.g. Wizard.Illusionist)

The sole use of x for any Class with Subclasses (e.g. Wizard) allows
the use of the "base" class in addition to ALL of the subclasses of
that base class.  To specify only a single subclass (or the single
base class) the x.y syntax is used: e.g. Wizard.Wizard.  This matches
the existing syntax for FAVCLASS.

Conversion Plan:

Automatic conversion of the FAVCLASS:CHOOSE syntax for data between
5.16 and a subsequent revision of PCGen can be performed.  The
conversion follows the pattern:
FAVCLASS:ANY
...becomes...
FAVCLASS:HIGHESTLEVELCLASS

FAVCLASS:CHOOSE:x,y,z.a
...becomes...
CHOOSE:CLASS:x,y,z.a
FAVCLASS:%LIST

There is a risk of races already having a CHOOSE.  This is why the
FAVOREDCLASS (Template) enhancement is required to be performed at the
same time.  Thus any Race which already contains a CHOOSE can be
converted into a Race with a hidden template, e.g.:

FAVCLASS:CHOOSE:x,y,z.a
...becomes...
TEMPLATE:RaceFooFavoredClass

RaceFooFavoredClass
CHOOSE:CLASS:x,y,z.a
FAVOREDCLASS:%LIST

Notes:
FAVCLASS:Any will be deprecated in PCGen 5.16 and prohibited in the
subsequent release (tokens must have one release deprecated and one
release where they are guaranteed to fail before they can be reused). 

As a note of a minor constraint on future enhancement, in order to
have "any" as the favored classes (no XP penalty ever, even with n
classes of arbitrary level), it would require one of:
- Fully deprecate FAVCLASS in Race and replace with something like
FAVOREDCLASS
- Use a separate token, e.g. XPPENALTY (set to NO for the Race)


TP.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1967662&group_id=25576