From: SourceForge.net <no...@so...> - 2008-04-12 00:09:29
|
Bugs item #1903158, was opened at 2008-02-27 11:04 Message generated for change (Comment added) made by thpr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1903158&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Skill Support Group: To be fixed For 5.14 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Martijn Verburg (karianna) Assigned to: Tom Parker (thpr) Summary: CHOOSE:NONCLASSSKILLLIST broken Initial Comment: 15:57:07.427 SEVERE AWT-EventQueue-1 PCGen_Frame1:2820 Uncaught error - ignoring java.lang.NullPointerException at pcgen.core.chooser.SkillListNonClassChoiceManager.getChoices(SkillListNonClassChoiceManager.java:99) at pcgen.core.chooser.ChooserUtilities.modChoices(ChooserUtilities.java:261) at pcgen.core.Domain.setIsLocked(Domain.java:168) at pcgen.gui.tabs.InfoDomain.selectDomainIndex(InfoDomain.java:1337) at pcgen.gui.tabs.InfoDomain.access$13(InfoDomain.java:1264) at pcgen.gui.tabs.InfoDomain$6.actionPerformed(InfoDomain.java:927) The offending line of code is at SkillListNonClassChoiceManager.java (~99): final boolean rootArrayContainsRootName = rootArrayList.contains(rootName); Basically rootArrayList is never initialised in the entire code base as far as I can tell. - K ---------------------------------------------------------------------- >Comment By: Tom Parker (thpr) Date: 2008-04-11 20:09 Message: Logged In: YES user_id=1037926 Originator: NO Committed revision 5905. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-03-31 07:39 Message: Logged In: YES user_id=252169 Originator: YES I'm pretty sure this is a case for fixing (although Tom may need to start a discussion in _exp over it), Tom? ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2008-03-31 07:15 Message: Logged In: YES user_id=558288 Originator: NO What do we want to do here? Fix it or deprecate it? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2008-02-27 17:00 Message: Logged In: YES user_id=252169 Originator: YES If it helps it's not used in any PCGen datasets that we currently distribute, but I understand a few third parties would definitely like to have it working.... ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-02-27 11:15 Message: Logged In: YES user_id=1037926 Originator: NO Sorry, that wasn't the thread I wanted... I have to find the more recent thread on the CHOOSE issues of the CHOOSES that are dependent on the no-longer-used ROOT: token ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2008-02-27 11:11 Message: Logged In: YES user_id=1037926 Originator: NO Is this is being used in a real dataset? I'm curious to know a revision of PCGen where this worked (meaning was successful, not silently failed). >From what I can read in the code, I don't believe it has since at least 5.10. I'm trying to remove this as a result. See http://tech.groups.yahoo.com/group/pcgen_experimental/message/7752 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1903158&group_id=25576 |