Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1669300 ] Fix OS tokens so that they return new line if given no txt
|
From: SourceForge.net <no...@so...> - 2007-03-08 21:11:40
|
Bugs item #1669300, was opened at 2007-02-26 17:17 Message generated for change (Settings changed) made by karianna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1669300&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Export Character Group: To be fixed For 5.12 >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Martijn Verburg (karianna) >Assigned to: apsen (apsen) Summary: Fix OS tokens so that they return new line if given no txt Initial Comment: See OS bug [1385649 ] [PDF] Preserve spacing between paragraphs Date: 2007-02-24 04:28 Sender: eddyanthonySourceForge.net SubscriberProject Admin Logged In: YES user_id=886893 Originator: YES There is an open bug tracker for the second issue which is apparently caused by incorrect processing of the <> characters: [ 1613234 ] Processing > and < characters in PDF wrong <https://sourceforge.net/tracker/index.php?func=detail&aid=1613234&group_id=25576&atid=384719> there is no code bug tracker for the issue of returns on empty lines. This effects several tokens which return text entered into the various predefined notes on the description tab, BIO and NOTE appear to output returns as long as there is text on the line. MISC.MAGIC, FUNDS and COMPANIONS do not appear to output any returns at all. Date: 2007-02-24 02:07 Sender: eddyanthonySourceForge.net SubscriberProject Admin Logged In: YES user_id=886893 Originator: YES Kar, I see two issues here, both code bugs not outputsheet formatting bugs. My tests tonight show that gawaine42's info below is correct, the BIO tag is outputing returns correctly now... but not returns on lines with nothing else on them. So the cod needs to be made to output a return on an otherwise empty line. Second problem: the Docs say BIO followed by a comma should output any text which follows at the ned of each new line. So |BIO,Text| will append "Text" to the end of every line. Here's the problem I found: the standard html sheet has |BIO,<br />| in it. It would seem that someone tried to solve the new line issue that way. on output <br /> does indeed get output, but it appears on the page, it is not recognised as an html tag. When I looked at the page source I found that this is because <br /> is coded as <br /> which is how you print something that would ordinarily be recognised as code. I'm not sure if this is a bug or a feature but I'm pretty sure we don't need to use it if the code can be made to output the empty returns. So two things to do, on the code side fix it so the line with just a return on then are output. On the OS side check all the BIO tags (and other note style tags) and remove any extra formatting which is attemoting to solve the same problem. Might be good to open a code bug and assing this back to me for the OS work, ---------------------------------------------------------------------- >Comment By: Martijn Verburg (karianna) Date: 2007-03-08 21:11 Message: Logged In: YES user_id=252169 Originator: YES Apsen has reported the code fix is complete, there is an existing tracker on the OS side [1385649] [PDF] Preserve spacing between paragraphs - K ---------------------------------------------------------------------- Comment By: apsen (apsen) Date: 2007-03-07 20:38 Message: Logged In: YES user_id=1376183 Originator: NO Since some tokens are using StringTokenizer to split strings sequential newlines are treated as one so |BIO,1| would insert 1 only on non empty lines. StringTokenizer needs to be replaced with String.split (it could also be handled by making StringTokenizer to return separators and creating empty tokens on your own). ---------------------------------------------------------------------- Comment By: apsen (apsen) Date: 2007-03-07 20:24 Message: Logged In: YES user_id=1376183 Originator: NO I've checked several token and they generate correct number of empty lines. The problem seems to be on OS (at least that's the case with pdf export). If anyone know of the token that is eating newlines please list them. ---------------------------------------------------------------------- Comment By: apsen (apsen) Date: 2007-03-07 20:23 Message: Logged In: YES user_id=1376183 Originator: NO I've checked several token and they generate correct number of empty lines. The problem seems to be on OS (at least that's the case with pdf export). If anyone know of the token that is eating newlines please list them. ---------------------------------------------------------------------- Comment By: apsen (apsen) Date: 2007-03-07 15:47 Message: Logged In: YES user_id=1376183 Originator: NO Fixed in code for MISC.MAGIC, FUNDS and COMPANIONS but note that OS should be able to output empty lines. For example pdf export does not output visible space for the block that is empty. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1669300&group_id=25576 |