From: SourceForge.net <no...@so...> - 2007-03-06 19:23:53
|
Bugs item #1368839, was opened at 2005-11-28 23:52 Message generated for change (Comment added) made by apsen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1368839&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Export Character Group: To be fixed For 5.12 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Steven Bethard (bediviere) Assigned to: Nobody/Anonymous (nobody) Summary: Export to Letter in PDF needs to be disabled in preferences Initial Comment: fantasy_master_std.xslt hard-codes the paper size A4: <!-- PAGE DEFINITIONS --> <fo:layout-master-set> <fo:simple-page-master master-name="Portrait 2 Column" page-height="297mm" page-width="210mm" margin-top="10mm" margin-bottom="15mm" margin-left="6mm" margin-right="6mm"> <fo:region-body region-name="body" column-count="2" column-gap="2mm" margin-bottom="7mm"/> <fo:region-after region-name="footer" extent="0.25in"/> </fo:simple-page-master> <fo:simple-page-master master-name="Portrait" page-height="297mm" page-width="210mm" margin-top="10mm" margin-bottom="15mm" margin-left="6mm" margin-right="6mm"> <fo:region-body region-name="body" margin-bottom="7mm"/> <fo:region-after region-name="footer" extent="0.25in"/> </fo:simple-page-master> </fo:layout-master-set> Note the page-height and page-width settings. This means that even when I select "Letter" as my paper size in the PCgen preferences, I still get A4 output when I export to PDF. Sorry I don't understand the internals of PCgen's export mechanism to provide a patch! ---------------------------------------------------------------------- >Comment By: apsen (apsen) Date: 2007-03-06 14:23 Message: Logged In: YES user_id=1376183 Originator: NO There's no need in two versions (A4/Letter) of OS. Just all the calculations should refer to /character/export/paperinfo/height instead of using hardcoded values. BTW ="/character/export/paperinfo/margins seem not to get correct values out of |PARERINFO.MARGIN*| tokens. I may take a look at modifying OS given I ever get that much time :-) ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2007-02-22 08:04 Message: Logged In: YES user_id=252169 Originator: NO This is another great one for a new dev. - K ---------------------------------------------------------------------- Comment By: David Jorgenson (daveguy) Date: 2006-07-06 13:25 Message: Logged In: YES user_id=161491 Would it be possible, in the installer, to ask for the paper size, and install an appropriate fantasy_master_std.xslt? I know it's kind of a brute force method, but could be a method to get this working. I've tried modifying fantasy_master_std.xslt myself, and it's worked with no problems. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2006-02-11 05:58 Message: Logged In: YES user_id=252169 Sorry, I wasn't clear, yes I agree with you, we just have to find the best way of swapping the sections out (because we'd want to have US Letter (and other formats) supported for all templates) - Thanks for providing us this info!! K ---------------------------------------------------------------------- Comment By: Steven Bethard (bediviere) Date: 2006-02-10 12:39 Message: Logged In: YES user_id=945502 I don't know about "in principle" or not, but by changing the file as I explained, everything just worked. I didn't have to modify any code -- just the fantasy_master_std.xslt file. So I think the only question should be, is this the right way to support non-A4? And does it work on other machines like it does on mine? ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2006-02-10 09:30 Message: Logged In: YES user_id=252169 Chuck, it looks like he's asking to parameterise the height and width settings etc. In principle is that possible on your end? I could then work on sending through the variables... - K ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-12-05 05:05 Message: Logged In: YES user_id=252169 possibly :-). I'll take a look @ this (although it's likely I won't really have time to deal with it until the new year) - K ---------------------------------------------------------------------- Comment By: Steven Bethard (bediviere) Date: 2005-11-30 15:23 Message: Logged In: YES user_id=945502 I took a closer look at this. Can't it just be fixed by changing the code in my original post to:: <fo:layout-master-set> <fo:simple-page-master master-name="Portrait 2 Column"> <xsl:attribute name="page-height"> <xsl:value-of select="/character/export/paperinfo/height" /> </xsl:attribute> <xsl:attribute name="page-width"> <xsl:value-of select="/character/export/paperinfo/width" /> </xsl:attribute> <xsl:attribute name="margin-top"> <xsl:value-of select="/character/export/paperinfo/margins/top" /> </xsl:attribute> <xsl:attribute name="margin-bottom"> <xsl:value-of select="/character/export/paperinfo/margins/bottom" /> </xsl:attribute> <xsl:attribute name="margin-left"> <xsl:value-of select="/character/export/paperinfo/margins/left" /> </xsl:attribute> <xsl:attribute name="margin-right"> <xsl:value-of select="/character/export/paperinfo/margins/right" /> </xsl:attribute> <fo:region-body region-name="body" column-count="2" column-gap="2mm" margin-bottom="7mm"/> <fo:region-after region-name="footer" extent="0.25in"/> </fo:simple-page-master> <fo:simple-page-master master-name="Portrait"> <xsl:attribute name="page-height"> <xsl:value-of select="/character/export/paperinfo/height" /> </xsl:attribute> <xsl:attribute name="page-width"> <xsl:value-of select="/character/export/paperinfo/width" /> </xsl:attribute> <xsl:attribute name="margin-top"> <xsl:value-of select="/character/export/paperinfo/margins/top" /> </xsl:attribute> <xsl:attribute name="margin-bottom"> <xsl:value-of select="/character/export/paperinfo/margins/bottom" /> </xsl:attribute> <xsl:attribute name="margin-left"> <xsl:value-of select="/character/export/paperinfo/margins/left" /> </xsl:attribute> <xsl:attribute name="margin-right"> <xsl:value-of select="/character/export/paperinfo/margins/right" /> </xsl:attribute> <fo:region-body region-name="body" margin-bottom="7mm"/> <fo:region-after region-name="footer" extent="0.25in"/> </fo:simple-page-master> </fo:layout-master-set> I tried this out, and it seemed to work okay for me, but I'm not sure how to test it thorougly... ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-11-30 06:31 Message: Logged In: YES user_id=252169 This is a duplicate of a FREQ. However the preferences dialog should have the Letter option removed, re labelling the bug - K ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1368839&group_id=25576 |