From: SourceForge.net <no...@so...> - 2006-11-12 21:38:28
|
Bugs item #1594925, was opened at 2006-11-11 22:13 Message generated for change (Comment added) made by thpr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1594925&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Feat Support Group: To be fixed For 5.12 >Status: Closed >Resolution: Fixed Priority: 7 Private: No Submitted By: James Dempsey (jdempsey) Assigned to: Tom Parker (thpr) Summary: Bonus feat every 3rd level not added to loaded character Initial Comment: PCGen v 5.11.2-DEV SVN Rev: 1637 Java: 1.5.0_09-b03 OS: Windows 2000 GameMode: 35e Sources: 3.5 RSRD If you create a first level character, save it, level it to third it will receive a bonus feat, as in the number of remaining feats at the bottom right of the Feats page increases by 1. Close the character, open the saved first level character and then level it to third. No bonus feat is granted. ---------------------------------------------------------------------- >Comment By: Tom Parker (thpr) Date: 2006-11-12 16:38 Message: Logged In: YES user_id=1037926 In 1648 ---------------------------------------------------------------------- Comment By: Tom Parker (thpr) Date: 2006-11-12 02:09 Message: Logged In: YES user_id=1037926 Very specifically: The Bonus FEAT PCPOOL is not being set upon character import. The checkin that contains this Bonus (and the code that is gating the set) is 1382 The method from PCClass.java is: public void setLevel(final int newLevel, final PlayerCharacter aPC) { final int curLevel = level; if (newLevel >= 0) { level = newLevel; } if (level == 1) { if (level > curLevel) { ^^^^^^^ This level > curLevel IF is never being passed, as level == 1 on import, but is not > curLevel... thus nothing in that IF is executed, which includes setting of FEAT PCPOOL. While I'm getting familiar with PCClass, the addLevel items is what I've spent the least amount of time on... and given the context to the Ability Object project, I won't claim to know enough of what is going on to be able to fix this without other consequences to the Ability setup. With that caveat, it MAY be as easy as adding: || aPC.isImporting() To that level > gate. Literally make line 3043 of PCClass: if (level > curLevel || aPC.isImporting()) { That SEEMS to work for me, but I didn't want to check it in due to concerns over other consequences to Abilities... This gives you a potential solution, up to James on whether to do before or after 5.11.2 release. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1594925&group_id=25576 |