Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-1280838 ] VFEAT not applying feats with choices
|
From: SourceForge.net <no...@so...> - 2006-04-04 20:55:36
|
Bugs item #1280838, was opened at 2005-09-02 17:19 Message generated for change (Comment added) made by nuance You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1280838&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Feat Support Group: To be fixed For 5.10 Status: Open Resolution: None Priority: 7 Submitted By: Eddy Anthony (eddyanthony) >Assigned to: Eddy Anthony (eddyanthony) Summary: VFEAT not applying feats with choices Initial Comment: This was discovered trying to reproduce this bug: [ 1198888 ] [SRD] Weapon finnese feat seems not to work for animals <http://sourceforge.net/tracker/index.php? func=detail&aid=1198888&group_id=25576&atid=750091> It was found that this tag did not grant the feat benefits VFEAT:Weapon Finesse(Claws) But this does: FEAT:Weapon Finesse(Claws) And hear is an additional problem, when multiples are to be granted the syntax used in the past has been: FEAT:Weapon Finesse(Bite,Claw) This was changed to this format in the last release: FEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) This was the tracker: [ 1253214 ] can't set more than 1 MULT:YES feats in race lines <https://sourceforge.net/tracker/index.php? func=detail&aid=1253214&group_id=25576&atid=384719> This was specifically for MFEAT but it seems to work this way for FEAT as well. Please confirm if this last syntax is what we must use, if this is the case there will need to be much updating done in the repository. It would be nice if both were valid. ---------------------------------------------------------------------- >Comment By: Andrew Wilson (nuance) Date: 2006-04-04 20:55 Message: Logged In: YES user_id=41667 http://svn.sourceforge.net/viewcvs.cgi/pcgen? rev=609&view=rev Fix bug. ---------------------------------------------------------------------- Comment By: Eddy Anthony (eddyanthony) Date: 2006-04-02 00:21 Message: Logged In: YES user_id=886893 he he, I tested it anyway, built at revision 561 with SRD Cat (changed the FEAT tag to a VFEAT): VFEAT:Weapon Finesse(Bite,Claw) - Works VFEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) - Only displays Bite in the feat tab, not Claw. The feat effects however are being applied to both when checked in the preview tab VFEAT:Weapon Finesse(Bite) VFEAT:Weapon Finesse(Claw) - Same as above, only displays Bite in the feat tab, not Claw. The feat effects however are being applied to both when checked in the preview tab ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2006-04-01 18:23 Message: Logged In: YES user_id=41667 Sorry Eddy, forget that, I'm talking nonsense. I forgot I'd undone my changes to the SRD so I wouldn't accidentally commit them. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2006-04-01 18:20 Message: Logged In: YES user_id=41667 I've just tried this again and it seems to be applying the fat correctly tonight. Eddy I think this is fixed, if it isn't can you bounce it back to me please? ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2006-03-31 20:00 Message: Logged In: YES user_id=41667 Ok I've had quick look and I've fixed the broken syntax. VFEAT:Weapon Finesse(Bite,Claw) and VFEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) are now both adding the feat as they should. It's still not applying the feat properly which is a separate problem. I'm still looking into that. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2006-03-31 18:50 Message: Logged In: YES user_id=41667 Ok I've had quick look and I've fixed the broken syntax. VFEAT:Weapon Finesse(Bite,Claw) and VFEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) are now both adding the feat as they should. It's still not applying the feat properly which is a separate problem. I'm still looking into that. ---------------------------------------------------------------------- Comment By: Michael Osterlie (darth_sidious) Date: 2005-10-12 19:51 Message: Logged In: YES user_id=1334694 I did a little bit of looking, and the feat is being loaded correctly. When creating a new character with a VFEAT:Weapon Finesse(Claws), the feat appears correctly on the Feats tab (Weapon Finesse in Magenta, Claws listed under Choices), it's just not being applied to the Claws. For testing, I just copied the Raven and changed the FEAT to VFEAT for Weapon Finesse(Claws). I did little bit more looking, but at this point I'm sure someone else could fix it a lot quicker then me, so I'm assigning this back to you. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-12 08:33 Message: Logged In: YES user_id=252169 Hey dude, This might be another '()' related problem, dump it back to me if it ain't :-) - K ---------------------------------------------------------------------- Comment By: Andrew McDougall (tir-gwaith) Date: 2005-09-07 13:43 Message: Logged In: YES user_id=208239 FEAT:Weapon Finesse(Bite,Claw) and FEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) Are both correct syntax. Same as CLASSES:Sorcerer,Wizard=4 and CLASSES:Sorcerer=4|Wizard=4 are both correct. I really hate to have to go to the longer syntax. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-09-07 11:00 Message: Logged In: YES user_id=252169 Hi Tir, Syntax Q on the 2nd half FEAT:Weapon Finesse(Bite,Claw) vs FEAT:Weapon Finesse(Bite)|Weapon Finesse(Claw) Which one should we be using? K PS: Note to self, a coder was around this area recently (PreFeat with () problems, might be a good one for him/her). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1280838&group_id=25576 |