Menu
▾
▴
[Pcgen-trackers] [ pcgen-Feature Requests-1262313 ] Ability Object: Fix feat tags to only add feat ability objs
|
From: SourceForge.net <no...@so...> - 2006-01-06 01:13:55
|
Feature Requests item #1262313, was opened at 2005-08-17 17:07 Message generated for change (Comment added) made by nuance You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262313&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 8 Submitted By: Devon Jones (soulcatcher) Assigned to: Andrew Wilson (nuance) Summary: Ability Object: Fix feat tags to only add feat ability objs Initial Comment: Alter ADD:FEAT, and FEATAUTO and all other tags that can assign a feat to a character so that they can only add objects of category feat. This freq depends on 1262306 If you need any guidance, contact me. Devon ---------------------------------------------------------------------- >Comment By: Andrew Wilson (nuance) Date: 2006-01-06 01:13 Message: Logged In: YES user_id=41667 There is more to do on this. Probably a lot more, I'll need to dig through the code to see exactly what is still to do. I'll try to do that this weekend. ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2006-01-04 02:44 Message: Logged In: YES user_id=558288 Andrew, Is there any work remaining on this request, or can it be closed? Cheers, James. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-25 01:21 Message: Logged In: YES user_id=41667 src/java/pcgen/core/levelability/LevelAbilityClassSkills.java 1.3 src/java/pcgen/core/levelability/LevelAbilityEquipment.java 1.5 src/java/pcgen/core/levelability/LevelAbilityFeat.java 1.5 src/java/pcgen/core/levelability/LevelAbilityLanguage.java 1.5 src/java/pcgen/core/levelability/LevelAbilityList.java 1.5 src/java/pcgen/core/levelability/LevelAbilitySkill.java 1.3 src/java/pcgen/core/levelability/LevelAbilitySpecial.java 1.5 src/java/pcgen/core/levelability/LevelAbilityWeaponBonus.java 1.3 Refactored some large unweildly methods in LevelAbilityFeat to make them easier to understand, added javadoc Changed the access level of some methods from public to package ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-20 22:19 Message: Logged In: YES user_id=41667 src/java/pcgen/core/AbilityInfo.java 1.6 src/java/pcgen/core/AbilityStore.java 1.3 src/java/pcgen/core/AbilityUtilities.java 1.4 src/java/pcgen/core/CategorisableStore.java 1.4 src/java/pcgen/core/Globals.java 1.707 src/java/pcgen/core/Kit.java 1.78 src/java/pcgen/core/kit/KitAbilities.java 1.3 Fixed lots of silly typos Fixed the bugs that were preventing feats with choices from being added by kits. Moved removeChoicesFromName from Globals to AbilityUtil Added a static method to AbilityUtil that uses an Ability's KeyName to retrieve from Globals, but tries with and without choices. use the new AbilityUtilities.retrieveAbilityKeyed in AbilityInfo to get the Ability that it represents and in AbilityStore when Adding the Ability. Fixed the call in kits that adds abilities to use the KeyName of the AbilityInfo object instead of the choice it got back from the chooser, since we have already used the choice to identify the correct AbilityInfo object. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-19 22:23 Message: Logged In: YES user_id=41667 src/java/pcgen/core/LevelAbility.java 1.139 src/java/pcgen/core/LevelAbilityFeat.java 1.88 src/java/pcgen/core/LevelAbilitySpellCaster.java 1.1 Refactored lots of overly large methods in LevelAbility.java Moved logic out of the general methods of LevelAbility.java into LevelAbilityFeat.java where it belonged (which allowed for the removal of some logic that was checking for feat in LevelAbility.java) Extracted the logic to deal with adding a level of Spell Caster out into a separate class. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-14 23:54 Message: Logged In: YES user_id=41667 src/java/pcgen/core/AbilityStore.java 1.1 src/java/pcgen/core/CategorisableStore.java 1.3 src/java/pcgen/core/Domain.java 1.136 src/java/pcgen/core/PlayerCharacter.java 1.1530 src/java/pcgen/core/kit/KitAbilities.java 1.2 src/java/pcgen/persistence/lst/DomainLoader.java 1.33 src/java/pcgen/persistence/lst/KitLoader.java 1.32 src/test/pcgen/core/DomainTest.java 1.5 Added new class AbilityStore, this is a subclss of Categorisable Store, it has one extra public method for parsing FEAT and ABILITY tags. it is intended for use in every object that needs to store Abilities (or AbilityInfos). The aim is to get as much of the Ability parsing code using this class as possiblein stead of having lots of similar code scattered across all of the objects in the system. Made some modifications to kits to use this new method of parsing its tags. changed domains to be able to parse ABILITY tags. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-13 23:42 Message: Logged In: YES user_id=41667 src/java/gmgen/plugin/PlayerCharacterOutput.java 1.20 src/java/pcgen/core/CategorisableStore.java 1.2 src/java/pcgen/core/CharacterDomain.java 1.58 src/java/pcgen/core/Globals.java 1.701 src/java/pcgen/core/LevelAbilityFeat.java 1.83 src/java/pcgen/core/PCClass.java 1.673 src/java/pcgen/core/PObject.java 1.729 src/java/pcgen/core/PObjectUtilities.java 1.9 src/java/pcgen/core/PlayerCharacter.java 1.1527 src/java/pcgen/core/VariableProcessorPC.java 1.13 src/java/pcgen/gui/filter/FilterFactory.java 1.105 src/java/pcgen/gui/tabs/InfoFeats.java 1.71 src/java/pcgen/io/ExportHandler.java 1.554 src/java/pcgen/io/PCGIOHandler.java 1.90 src/java/pcgen/io/PCGVer2Creator.java 1.128 src/java/pcgen/io/PCGVer2Parser.java 1.174 src/test/pcgen/core/PlayerCharacterTest.java 1.19 src/test/pcgen/core/prereq/PreMultTest.java 1.8 Properly encapsulated the featList field of PlayerCharacter This is the ArrayList that holds all the "Real" (not virtual or auto) Feats that the character has. All access to it now goes through accessor/mutator methods rather than returning it and directly fiddling with it. I renamed a few methods which were basically accessor for the featList and moved them together with all the new methods. Javadoced all the new methods. Eventually featList will be replaced with a CategorisableStore. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-12 22:08 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.13 src/java/pcgen/core/AbilityInfo.java 1.4 src/java/pcgen/core/Categorisable.java 1.1 src/java/pcgen/core/CategorisableStore.java 1.1 src/java/pcgen/core/Globals.java 1.698 New Interface Categorisable, for objects that can be stored and retrieved by Category. Made Ability and AbilityInfo objects Categorisable. Extract all the logic that stores Ability objects out of Globals and make a new class CategorisableStore. Use the new class to reimplement the methods in Globals. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-06 03:06 Message: Logged In: YES user_id=41667 src/java/pcgen/core/EquipmentChoice.java 1.3 src/java/pcgen/core/EquipmentModifier.java 1.146 Refactored buildEquipmentChoice() from EquipmentModifier.java into 13 - 14 smaller methods in EquipmentChoice.java where this logic belongs. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-04 23:48 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.10 src/java/pcgen/core/AbilityUtilities.java 1.2 src/java/pcgen/core/CharacterDomain.java 1.56 src/java/pcgen/core/Constants.java 1.72 src/java/pcgen/core/Deity.java 1.147 src/java/pcgen/core/GameMode.java 1.89 src/java/pcgen/gui/editor/EditorMainForm.java 1.135 src/java/pcgen/gui/prop/LanguageBundle.properties 1.107 src/java/pcgen/gui/prop/LanguageBundle_de.properties 1.5 src/java/pcgen/gui/prop/LanguageBundle_es.properties 1.6 src/java/pcgen/gui/prop/LanguageBundle_fr.properties 1.4 src/java/pcgen/gui/prop/LanguageBundle_it.properties 1.6 src/java/pcgen/gui/prop/LanguageBundle_pt.properties 1.5 src/java/pcgen/gui/tabs/InfoFeats.java 1.69 src/java/pcgen/gui/tabs/InfoSpecialAbilities.java 1.2 src/java/pcgen/gui/tabs/InfoSummary.java 1.94 src/java/pcgen/persistence/lst/AbilityLoader.java 1.3 src/java/pcgen/persistence/lst/FeatLoader.java 1.46 system/Languages/LanguageBundle.properties 1.10 system/Languages/LanguageBundle_en_US.properties 1.9 system/gameModes/35e/miscinfo.lst 1.18 system/gameModes/3e/miscinfo.lst 1.17 system/gameModes/Deadlands/miscinfo.lst 1.5 system/gameModes/Modern/miscinfo.lst 1.30 system/gameModes/Sidewinder/miscinfo.lst 1.8 system/gameModes/Spycraft/miscinfo.lst 1.11 system/gameModes/Xcrawl/miscinfo.lst 1.7 Extensive changes in Ability.java almost completely eradicated all mention of feats. Added some more javadoc and rewraped the code (using Jalopy). All of the Symbolic Constants have been renamed to ABILITY constants. Filtered the changes in Ability through to all other affected files. Was about to start changing the Feat tab in the GUI to be make room for an ability tab, but there's already an ability tab. Annoyingly we don't have two things in the system called ability, we have three. Renamed some of the property strings to do with Language, Weapon profs, etc. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-03 18:30 Message: Logged In: YES user_id=41667 src/java/pcgen/gui/AddSpecialAbility.java 1.10 src/java/pcgen/gui/CharacterInfo.java 1.172 src/java/pcgen/gui/PCGen_Frame1.java 1.471 src/java/pcgen/gui/prop/LanguageBundle.properties 1.105 src/java/pcgen/gui/prop/LanguageBundle_de.properties 1.4 src/java/pcgen/gui/prop/LanguageBundle_es.properties 1.5 src/java/pcgen/gui/prop/LanguageBundle_fr.properties 1.3 src/java/pcgen/gui/prop/LanguageBundle_it.properties 1.5 src/java/pcgen/gui/prop/LanguageBundle_pt.properties 1.4 src/java/pcgen/gui/tabs/InfoClasses.java 1.63 src/java/pcgen/gui/tabs/InfoEquipping.java 1.98 src/java/pcgen/gui/tabs/InfoSpecialAbilities.java 1.1 src/java/pcgen/gui/tabs/InfoSummary.java 1.93 src/java/pcgen/gui/tabs/InfoTempMod.java 1.76 Appartenly PCGen already has something called Ability. Well, actually it's really called SpecialAbility various programers have at various times abbreviated this to just Ability. This change renames some Stuff that should have been SpecialAbility to actually be SpecialAbility. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-03 15:56 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.9 src/java/pcgen/core/PlayerCharacter.java 1.1515 src/java/pcgen/gui/tabs/InfoFeats.java 1.68 src/java/pcgen/gui/utils/PObjectNode.java 1.36 src/java/pcgen/persistence/lst/utils/FeatParser.java 1.5 Changed all the symbolic constants with FEAT in their name to have ABILITY instaed Lined up some variable declarations. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-08-17 17:12 Message: Logged In: YES user_id=107647 this also depends on 1262309 ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-08-17 17:10 Message: Logged In: YES user_id=107647 Couple notes, this also depends on 1262317, and really, it should probably under the covers be calling the new ability functions, and jsut hard code the category parameter. The person who does this really should be the same person that does 1262317. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262313&group_id=25576 |
