[Pcgen-trackers] [ pcgen-Bugs-1213573 ] Price rounding problem with equipmods

[SourceForge.net <no...@so...>]

Bugs item #1213573, was opened at 2005-06-02 16:29
Message generated for change (Comment added) made by karianna
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1213573&group_id=25576

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Equipment/Weaponprof Support
>Group: To be fixed For 5.10
Status: Open
Resolution: None
Priority: 7
Submitted By: Reed Thornton (rthornton13)
Assigned to: Nobody/Anonymous (nobody)
Summary: Price rounding problem with equipmods

Initial Comment:
From [PCGenListFileHelp] Problem with Cost after 
equip mods

************
That's not quite true. Try applying the Dragonhide armor 
eqmod.
Dragonhide armor costs twice what a masterwork 
version of the type
would cost. The eqmod uses COST:BASECOST+300 
(normal MW armor costs
150 more than standard).

Leather....................10gp
MW Leather.............160gp
Dragonhide Leather...320gp

BASECOST doesn't appear to be the problem to me so 
much as the item
customiser/eqmod cost calculation. I just ran a test 
where a created a
new armor that was leather but a different name and the 
cost was 10.5
and did the same comparison with it.

Regular....................10.5
Masterwork..............161       <--- Should be 160.5 (10.5 
+ 150)
Dragonhide................321.5    <--- Should be 321    
(10.5 + 10.5 + 300)

Created the same items by hand in the lst file using 
BASEITEM and
EQMOD and saw the exact same prices.

My conclusion is that BASECOST is actually working 
just fine, but that
the code to apply the price changes is rounding things 
up *before*
applying the eqmod price change. The reason that I 
think this from
looking at the MW version of the 10.5 cost armor. The 
MW eqmod for
armor just adds a straight 150 gp to the cost, but the 
final cost
comes out rounded up. But if you look at MW arrows, 
the pricing is
wrong.

1 arrow.............. 0.05 (note that I haven't seen any 
reference to
this in the RSRD)
1 MW arrow....... 6.05 (should be 7, but eqmod works 
as expected)
20 arrows.......... 1
20 MW arrows... 121 (Should be 140, but again base 
price isn't set to 1gp/arrow)
50 arrows.......... 2.5 (again, I don't see a direct 
reference to qty 50)
50 MW arrows... 302.5 (Should be 350, but base price 
isn't set to 1 gp/arrow)

Reed
QA Silverback


----------------------------------------------------------------------

>Comment By: Martijn Verburg (karianna)
Date: 2005-12-06 13:37

Message:
Logged In: YES 
user_id=252169

Contacting dev list for a cm - K

----------------------------------------------------------------------

Comment By: Martijn Verburg (karianna)
Date: 2005-09-09 15:16

Message:
Logged In: YES 
user_id=252169

Bug's still exist, although it seems to round down, not up. - K

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1213573&group_id=25576