From: SourceForge.net <no...@so...> - 2005-09-02 05:14:34
|
Feature Requests item #1262306, was opened at 2005-08-17 11:01 Message generated for change (Comment added) made by soulcatcher You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262306&group_id=25576 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tag modification Group: None Status: Closed Resolution: Fixed Priority: 8 Submitted By: Devon Jones (soulcatcher) Assigned to: Andrew Wilson (nuance) Summary: Ability Object: Add Tag Category Initial Comment: Category would probably just be a standard string property. Just something to keep the ability objects segregated. CATEGORY:[NAME] It may be a good idea to alter the storage of loaded ability objects to instead of keeping them in one lsit, keep a hashmap of lists with the category as the key to the hashmap. If you need any guidance, contact me. Devon ---------------------------------------------------------------------- >Comment By: Devon Jones (soulcatcher) Date: 2005-09-01 23:14 Message: Logged In: YES user_id=107647 Sweeeeet good job Andrew :) Devon ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-01 19:23 Message: Logged In: YES user_id=41667 And We're done (part one anyway). ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-01 19:22 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.8 src/java/pcgen/core/Globals.java 1.695 src/test/pcgen/core/GlobalsTest.java 1.13 Fixed clone in Ability so that it copies Category. Implemented all the methods in globals that that do all that lovely category stuff. Enhanced GlobalsTest so it tests the new functionality. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-09-01 18:44 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Globals.java 1.694 src/java/pcgen/io/IOConstants.java 1.48 src/java/pcgen/persistence/lst/AbilityLoader.java 1.1 src/java/pcgen/persistence/lst/FeatLoader.java 1.45 This is a mostly tidying up commit Lined up some stuff in Globals. Added TAG_FEAT_CATEGORY to IO_Constants. I was going to make changes to the character loader but they turned out not to be necessary at this point. When we actually have more than one category of Ability the change will be necessary (i.e. really soon now). Moved FeatLoader to AbilityLoader and made FeatLoader a very small subclass of AbilityLoader. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-28 22:50 Message: Logged In: YES user_id=41667 src/java/pcgen/core/CustomData.java 1.51 src/java/pcgen/core/EquipmentModifier.java 1.144 src/java/pcgen/core/Globals.java 1.693 src/java/pcgen/core/PlayerCharacter.java 1.1510 src/java/pcgen/gui/ChooseSpellDialog.java 1.64 src/java/pcgen/gui/LstEditorMain.java 1.51 src/java/pcgen/gui/editor/ClassLevelPanel.java 1.61 src/java/pcgen/gui/editor/EditorMainForm.java 1.133 src/java/pcgen/gui/editor/FeatBasePanel.java 1.22 src/java/pcgen/gui/tabs/InfoFeats.java 1.66 src/java/pcgen/gui/tabs/InfoTempMod.java 1.75 src/java/pcgen/persistence/lst/FeatLoader.java 1.44 src/test/pcgen/core/PlayerCharacterTest.java 1.16 src/test/pcgen/persistence/lst/utils/FeatParserTest.java 1.4 Globals.java ============ Added a line to addAbility so it now sort the list after an Ability is added. Added a getUnmodifiableAbilityList() method to globals for those rare classes that do actually need a list of Abilities, not an iterator. Removed getFeatList() PlayerCharacter.java ==================== Added canSelectAbility(anAbility, autoQualify) method to PlayerCharacter. Used new method to simplify getAvailableFeatNames(). Rewrote getAvailableFeatNames to use an Ability itertor instead of directly accessing the global feat list. Other files =========== Converted all other calls to Globals.getFeatList() into and appropriate call to addAbility(), removeAbility(), getAbilityKeyIterator() or getUnmodifiableAbilityList() as appropriate. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-28 19:27 Message: Logged In: YES user_id=41667 src/java/pcgen/io/PCGVer2Parser.java 1.171 Missed this one in the previous commit change. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-28 18:43 Message: Logged In: YES user_id=41667 src/java/pcgen/core/CharacterDomain.java 1.55 src/java/pcgen/core/Globals.java 1.692 src/java/pcgen/core/Kit.java 1.68 src/java/pcgen/core/LevelAbilityFeat.java 1.80 src/java/pcgen/core/LevelAbilitySpecial.java 1.53 src/java/pcgen/core/LevelAbilityWeaponBonus.java 1.46 src/java/pcgen/core/PObject.java 1.725 src/java/pcgen/core/PObjectUtilities.java 1.8 src/java/pcgen/core/PlayerCharacter.java 1.1509 src/java/pcgen/gui/LstEditorMain.java 1.50 src/java/pcgen/gui/tabs/InfoFeats.java 1.65 src/java/pcgen/gui/tabs/InfoSpells.java 1.77 src/java/pcgen/io/PCGVer0Parser.java 1.177 src/java/pcgen/io/PCGVer2Parser.java 1.170 src/java/pcgen/persistence/lst/FeatLoader.java 1.43 src/java/pcgen/persistence/lst/utils/FeatParser.java 1.4 Converted all occurrences of Globals.getFeatNamed() to Globals.getAbilityNamed("FEAT"). Deleted getFeatNamed() FROM Globals. Renamed all variables that had Feat in their name and were holding the result of getFeatNamed to have Ability in their name. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-27 20:33 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.5 src/java/pcgen/core/GameMode.java 1.86 src/java/pcgen/core/Globals.java 1.691 src/java/pcgen/gui/tabs/InfoFeats.java 1.64 src/java/pcgen/persistence/lst/CampaignLoader.java 1.69 src/java/pcgen/persistence/lst/GameModeLoader.java 1.60 Converted all the FeatTypeHidden methods and calls into AbilityTypeHidden methods and calls. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-27 20:03 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Globals.java 1.690 src/java/pcgen/core/PObject.java 1.724 src/java/pcgen/io/PCGVer0Parser.java 1.176 src/java/pcgen/io/PCGVer2Parser.java 1.169 Eliminated getFeatKeyed from Globals.java and every class that called it. Replaced with calls to Globals.getAbilityKeyed ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-27 10:29 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Globals.java 1.689 src/java/pcgen/core/LevelAbilitySpecial.java 1.52 src/java/pcgen/core/PObjectUtilities.java 1.7 src/java/pcgen/core/PlayerCharacter.java 1.1508 src/java/pcgen/gui/tabs/InfoFeats.java 1.63 Added canSelectAbility to PlayerCharacter.java to factor out some common tests from PObjectUtilities.java and LevelAbilitySpecial.java Eliminated methods getFeatListFeat and getFeatListFeatString from Globals.java and everywhere that called them. Renamed some varibles in LevelAbilitySpecial.java and InfoFeats.java to make the code clearer. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-25 21:26 Message: Logged In: YES user_id=41667 src/test/pcgen/PCGenTestCase.java 1.5 src/test/pcgen/core/GlobalsTest.java 1.9 src/test/pcgen/util/testchecker/CompareGreaterOrEqual.java 1.1 src/test/pcgen/util/testchecker/CompareLessOrEqual.java 1.1 Did actually need >= and <= tests, so added Testchecker classes to deal with them. Made relevant changes to PCGenTestCase.java. Converted exisiting pcgen/core/GlobalsTest.java to use is instead of assertTrue since the diagnostic messages are better. Added tests for the new methods to handle Abilities in Globals. Although these are not he final versions of these methods, their interface should be stable and these test should continue to work. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-25 21:15 Message: Logged In: YES user_id=41667 src/java/pcgen/core/Ability.java 1.4 src/java/pcgen/core/Globals.java 1.688 Added very simple setter getter methods for category to Ability. This still needs The loaders (LST and Character) modified to handle the category. Added interim implementations of the new Ability methods to Globals.java. These still use the ArrayList, when all of the code that access the ArrayList directly has been rewritten, these will be converted to use HashMaps. ---------------------------------------------------------------------- Comment By: Andrew Wilson (nuance) Date: 2005-08-25 16:48 Message: Logged In: YES user_id=41667 committed first change for this pcgen/src/java/pcgen/core/Ability.java 1.3 basic tidying of Ability. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384722&aid=1262306&group_id=25576 |