*PCD_parser_update_parse_status should be called for mandatory arguments.
*In parser.h, parser keywords have to be re-organized to list all mandatory arguments first, followed by the non-mandatory ones, without which the parser fails.
*Using PCD_STATUS_OK instead of IPC_STATUS_OK generated compile errors. These have been changed.
*Fixed a pointer casting issue in process.c
*REG_EIP is unavailable for x86 without a #define __USE_GNU. Not sure if this is required for PowerPc, I don’t have a system to confirm.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi PCD gurus,
How can I submit a fix/patch to the PCD project?I downloaded Marc Leforestier's patch from https://sourceforge.net/projects/pcd/files/patch/,( download link http://sourceforge.net/projects/pcd/files/patch/patch_pcd_marc_leforestier.patch/download ). It is a great feature but I had to make some small fixes for it to work. I would like to submit this patch upstream so others can benefit, can you please let me know what the procedure is? Right now I am unable to create a ticket for patches.
A description the fixes I made are below.
Thanks,
Gaurav
*PCD_parser_update_parse_status should be called for mandatory arguments.
*In parser.h, parser keywords have to be re-organized to list all mandatory arguments first, followed by the non-mandatory ones, without which the parser fails.
*Using PCD_STATUS_OK instead of IPC_STATUS_OK generated compile errors. These have been changed.
*Fixed a pointer casting issue in process.c
*REG_EIP is unavailable for x86 without a #define __USE_GNU. Not sure if this is required for PowerPc, I don’t have a system to confirm.
Hi, you can send me an email and I'll upload your patch.
Please noet that I am not actively maintaining this software anymore.
I'm attaching the modified patch here. It should be applied directly instead of this one:
http://sourceforge.net/projects/pcd/files/patch/patch_pcd_marc_leforestier.patch/download