[Pcb-bugs] [Bug 1659061] Re: Compile warnings when DEBUG symbol is defined

[Bert T. <16...@bu...>]

** Changed in: pcb
    Milestone: pcb-4.1.0 => pcb-4.0.1

-- 
You received this bug notification because you are a member of PCB Bug
Team, which is subscribed to pcb.
https://bugs.launchpad.net/bugs/1659061

Title:
  Compile warnings when DEBUG symbol is defined

Status in pcb:
  Fix Committed

Bug description:
  When the DEBUG symbol is defined, there are a whole bunch of compile
  warnings. See below:

  action.c: In function 'ActionElementList':
  action.c:7189:7: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
         int er, pr, i;
         ^~~
  action.c: In function 'tempfile_unlink':
  action.c:7492:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     int e, rc2 = 0;
     ^~~

  copy.c: In function 'CopyElement':
  copy.c:295:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     ElementType *element = CopyElementLowLevel (PCB->Data, Element,
     ^~~~~~~~~~~

  edif.y:3916:8: warning: return type defaults to 'int' [-Wimplicit-int]
   static Stack(char * str, int typ)
          ^~~~~
  edif.y:3932:8: warning: return type defaults to 'int' [-Wimplicit-int]
   static DumpStack()
          ^~~~~~~~~
  edif.y: In function 'DumpStack':
  edif.y:3950:7: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
         if (cxt = FindContext(TokenType[(TSP + i) & TS_MASK]))
         ^~
  edif.y:3952:7: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
         else if (tok = FindToken(TokenType[(TSP + i) & TS_MASK]))
         ^~~~
  edif.y: In function 'Stack':
  edif.y:3926:1: warning: control reaches end of non-void function [-Wreturn-type]
   }
   ^
  edif.y: In function 'DumpStack':
  edif.y:3968:1: warning: control reaches end of non-void function [-Wreturn-type]
   }
   ^

To manage notifications about this bug go to:
https://bugs.launchpad.net/pcb/+bug/1659061/+subscriptions