[Pcb-bugs] [ pcb-Patches-3024814 ] Fix segfault on unnamed element attribute editing

[SourceForge.net <no...@so...>]

Patches item #3024814, was opened at 2010-07-03 09:10
Message generated for change (Comment added) made by djdelorie
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=538813&aid=3024814&group_id=73743

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Richard Barlow (richardbarlow)
>Assigned to: DJ Delorie (djdelorie)
Summary: Fix segfault on unnamed element attribute editing

Initial Comment:
When attempting to edit the attributes on an unnamed element PCB segfaults. This can be reproduced with the following steps:

1) Insert new element into layout
2) Edit>Edit attributes of>Element
3) Click on element just inserted

This occurs due to the new element not having a name, PCB attempts to use the name in the title of the attribute editing window and dereferences a null pointer. The attached patch checks for the null pointer and uses the text '[unnamed]' in the window title if no name is present.

----------------------------------------------------------------------

>Comment By: DJ Delorie (djdelorie)
Date: 2010-08-15 02:10

Message:
Fixed in GIT commit fcb24561236102bbb7a7e891b97cdc6f38ea5a47
(sorry, didn't see your patch)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=538813&aid=3024814&group_id=73743