[Patchanim-commit] SF.net SVN: patchanim: [38] trunk/patchanim/src/com/mebigfatguy/patchanim

[<dbr...@us...>]

Revision: 38
          http://patchanim.svn.sourceforge.net/patchanim/?rev=38&view=rev
Author:   dbrosius
Date:     2008-01-26 20:31:55 -0800 (Sat, 26 Jan 2008)

Log Message:
-----------
findbugs fixes

Modified Paths:
--------------
    trunk/patchanim/src/com/mebigfatguy/patchanim/PatchAnimDocument.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/ActivePatchChangedEvent.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/DocumentChangedEvent.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JColorControlPatchPanel.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimFrame.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimPanel.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchControlPanel.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchListPanel.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchSamplePanel.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JTestFrame.java
    trunk/patchanim/src/com/mebigfatguy/patchanim/surface/Coordinate.java

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/PatchAnimDocument.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/PatchAnimDocument.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/PatchAnimDocument.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -26,6 +26,8 @@
 
 public class PatchAnimDocument implements Serializable {
 	
+	private static final long serialVersionUID = -587863884486252874L;
+	
 	private boolean dirty;
 	private List<CombinedPatch> patches;
 	private int width;

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/ActivePatchChangedEvent.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/ActivePatchChangedEvent.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/ActivePatchChangedEvent.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -23,6 +23,8 @@
 import com.mebigfatguy.patchanim.surface.CombinedPatch;
 
 public class ActivePatchChangedEvent extends EventObject {
+	private static final long serialVersionUID = -6329025951907079541L;
+	
 	private CombinedPatch patch;
 	
 	public ActivePatchChangedEvent(Object src, CombinedPatch activePatch) {

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/DocumentChangedEvent.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/DocumentChangedEvent.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/DocumentChangedEvent.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -23,6 +23,8 @@
 import com.mebigfatguy.patchanim.PatchAnimDocument;
 
 public class DocumentChangedEvent extends EventObject {
+	private static final long serialVersionUID = 7694516648407911200L;
+	
 	private PatchAnimDocument document;
 	
 	public DocumentChangedEvent(Object src, PatchAnimDocument d) {

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JColorControlPatchPanel.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JColorControlPatchPanel.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JColorControlPatchPanel.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -42,6 +42,8 @@
 
 public class JColorControlPatchPanel extends JPanel implements PatchDecorator {
 	
+	private static final long serialVersionUID = -2524694507912574529L;
+	
 	private PatchCoords coords;
 	private PatchColor color;
 	private JPatchSamplePanel sample;
@@ -67,6 +69,7 @@
 			
 		colorLabel = new JLabel(rb.getString(PatchAnimBundle.COLOR));
 		colorField = new JTextField(new DoubleDocument(), "", 4);
+		colorLabel.setLabelFor(colorField);
 		
 		add(Box.createVerticalGlue());
 		JPanel p = new JPanel();

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimFrame.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimFrame.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimFrame.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -20,6 +20,8 @@
 
 import java.awt.BorderLayout;
 import java.awt.Container;
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
 import java.awt.event.WindowAdapter;
 import java.awt.event.WindowEvent;
 import java.util.ResourceBundle;
@@ -34,6 +36,8 @@
 
 public class JPatchAnimFrame extends JFrame {
 	
+	private static final long serialVersionUID = -4610407923936772733L;
+	
 	private JMenuItem newItem;
 	private JMenuItem openItem;
 	private JMenuItem closeItem;
@@ -64,7 +68,7 @@
 		pack();
 	}
 	
-	public void initMenus() {
+	private void initMenus() {
 		ResourceBundle rb = PatchAnimBundle.getBundle();
 		JMenuBar mb = new JMenuBar();
 		JMenu fileMenu = new JMenu(rb.getString(PatchAnimBundle.FILE));
@@ -96,5 +100,12 @@
 				System.exit(0);
 			}
 		});
+		
+		quitItem.addActionListener(new ActionListener() {
+			public void actionPerformed(ActionEvent ae) {
+				dispose();
+				System.exit(0);
+			}
+		});
 	}
 }

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimPanel.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimPanel.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchAnimPanel.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -29,11 +29,9 @@
 
 public class JPatchAnimPanel extends JPanel {
 
+	private static final long serialVersionUID = 7719900566976553103L;
 	private JPatchControlPanel ctrl;
 	private JPatchSamplePanel sample;
-	private JColorControlPatchPanel redPatch;
-	private JColorControlPatchPanel greenPatch;
-	private JColorControlPatchPanel bluePatch;
 	
 	public JPatchAnimPanel() {
 		initComponents();
@@ -63,9 +61,9 @@
 		q = new JPanel();
 		{
 			q.setLayout(new BoxLayout(q, BoxLayout.X_AXIS));
-			redPatch = new JColorControlPatchPanel(PatchColor.Red);
-			greenPatch = new JColorControlPatchPanel(PatchColor.Green);
-			bluePatch = new JColorControlPatchPanel(PatchColor.Blue);
+			JColorControlPatchPanel redPatch = new JColorControlPatchPanel(PatchColor.Red);
+			JColorControlPatchPanel greenPatch = new JColorControlPatchPanel(PatchColor.Green);
+			JColorControlPatchPanel bluePatch = new JColorControlPatchPanel(PatchColor.Blue);
 	
 			q.add(Box.createHorizontalGlue());
 			q.add(redPatch);

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchControlPanel.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchControlPanel.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchControlPanel.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -37,8 +37,6 @@
 import javax.swing.JPanel;
 import javax.swing.JTextField;
 import javax.swing.SwingUtilities;
-import javax.swing.event.DocumentEvent;
-import javax.swing.event.DocumentListener;
 
 import com.mebigfatguy.patchanim.AnimationType;
 import com.mebigfatguy.patchanim.OutOfBoundsColor;
@@ -47,6 +45,8 @@
 
 public class JPatchControlPanel extends JPanel {
 
+	private static final long serialVersionUID = -5968231995166721151L;
+	
 	private PatchAnimDocument document;
 	private JTextField widthField;
 	private JTextField heightField;

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchListPanel.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchListPanel.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchListPanel.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -40,6 +40,8 @@
 import com.mebigfatguy.patchanim.surface.CombinedPatch;
 
 public class JPatchListPanel extends JPanel {
+	private static final long serialVersionUID = -6673383252840039387L;
+	
 	private JList patchList;
 	private PatchListModel patchListModel;
 	private JButton addButton;

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchSamplePanel.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchSamplePanel.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JPatchSamplePanel.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -38,6 +38,8 @@
 import com.mebigfatguy.patchanim.surface.PatchGenerator;
 
 public class JPatchSamplePanel extends JPanel {
+	private static final long serialVersionUID = 8057501623261814175L;
+	
 	private static final int SAMPLE_SIZE = 200;
 	private PatchColor color;
 	private Color rgb;

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JTestFrame.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JTestFrame.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/gui/JTestFrame.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -41,6 +41,8 @@
 
 public class JTestFrame extends JFrame {
 	
+	private static final long serialVersionUID = -7975149184522257748L;
+	
 	private Thread animThread = null;
 	private TestPanel testPanel = null;
 	private int tweenCount;
@@ -163,6 +165,8 @@
 	}
 	
 	class TestPanel extends JPanel {
+		private static final long serialVersionUID = 6268304008663415749L;
+
 		public TestPanel() {
 			Dimension d = new Dimension(width, height);
 			setMinimumSize(d);

Modified: trunk/patchanim/src/com/mebigfatguy/patchanim/surface/Coordinate.java
===================================================================
--- trunk/patchanim/src/com/mebigfatguy/patchanim/surface/Coordinate.java	2008-01-27 04:21:18 UTC (rev 37)
+++ trunk/patchanim/src/com/mebigfatguy/patchanim/surface/Coordinate.java	2008-01-27 04:31:55 UTC (rev 38)
@@ -22,6 +22,8 @@
 
 public class Coordinate implements Serializable {
 	
+	private static final long serialVersionUID = 5211344767856486552L;
+	
 	private double x, y, color;
 	
 	public Coordinate(double xPos, double yPos, double colorVal) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.