#1570 Adding entry while "last find results" is active always causes crash

[wralb]

I've been having the odd crash during my daily use of Password Safe on windows for (literally) decades. I've had time over the holiday to isolate simple reproducible steps below.

Using Windows 11; Password Safe V3.61 64 bit; psafe3 files stored on CIFS share

1. Create new safe e.g. psafe.psafe3
2. CTL-A - Add entry [Group]=t, [Title]="test1" (any credentials)
3. CTL-A - Add entry [Group]=t, [Title]="test2" (any credentials)
4. CTLF-F - test1 (i.e. find test1)
5. CTL-K (last find results)
6. CTL-A - Add entry [Group]=t, [Title]="test3"(any credentials)
7. CRASH

Notes:

1. Other actions such as "Duplicate" also cause a crash while "last find results" is active.
2. This has occurred with many versions of Password Safe in the past
3. Data is not lost when the crash occurs as the new entry appears in the DB after restart of PasswordSafe.

[A M]

Nice report! It certainly happens locally on a debug build.

pwsafe\src\ui\Windows\MainEdit.cpp
Line: 182

This is the assertion.

    // Now select item
    DisplayInfo pdi = GetEntryGUIInfo(iter->second);
    ASSERT(pdi->listindex != -1);
    SelectEntry(pdi->listindex);

Looks like the problem is that the newly created entry does not become visible because of the active last find results.

[Rony Shapiro]

Indeed - the detailed report is much appreciated. I hope to work on it around the coming weekend, unless someone else wants to take ownership.

[Rony Shapiro]

(easier that I thought)
Fixed in commit 751b54b8f, will be in next release.

[wralb]

Excellent! Thank you.

My main Password Safe file has grown to over 750 entries over 20 years of use so I am habitually typing CTL-K to make things easier to see; this will save me from forgetting to go back to the full list to manage entries.