Menu

#1523 Version 3.53 Has Small Icons on High DPI Monitors

Next release
closed
DPI (1)
Medium
2020-10-09
2020-09-20
Bill
No

Version 3.53 has very small icons on high DPI monitors. This also includes version 3.54beta as discussed at https://sourceforge.net/p/passwordsafe/discussion/134801/thread/3dd0ca5850/.

The 3.54 beta helps with the icons in the tree view, but other parts continue to have small icons and generally small sizes. See attachment for image (in the attachment, I deleted some parts of the filename and the text of the tree categories-- they look okay), and I will describe the areas where I see DPI issues, starting from the top of the window:

  • The menu text looks okay (e.g. "File", "Edit", etc.)
  • The next line of icons appears to have been scaled up, but the vertical space allocated to those icons has not been increased, so the bottom of those icons is cut off.
  • The next line of icons has not been scaled up.
  • The icons within the tree view look okay
  • The search box line has not been scaled up.
  • The bottom status line ("https://pwsafe.org", etc.) looks okay.

The "Enter Safe Combination" window looks okay.

1 Attachments

Related

Bugs: #1524

Discussion

  • MrMe

    MrMe - 2020-09-21

    I'm using a 2K screen. Here are a few pictures of what I see using v3.54.0dpiaware-beta.

    Note: I have "Override high DPI scaling behaviour" set to "System (Enhanced)" in Compatibility, and v3.53 is works fine in every way on my 2K screen with this Compatibility setting.

    1. The image and text on the Enter Safe Combination dialog doesn't scale like in v3.53, so text are tiny for the v3.54.0dpiaware-beta. See figure-1 (v3.54.0dpiaware) vs.figure-3 (v3.53)

    2. When the v3.54.0dpiaware-beta first opens the database, the menu and dragbar icons are messed up as seen in figure-2, and after I minimize and maximize the program window and adjust window size, the icons are okay as seen figure-4. FYI, figure 4 is also how v3.53 would have opened the database.

     
  • Rony Shapiro

    Rony Shapiro - 2020-09-21

    Thanks. Based on your feedback I've updated the beta files - issues should be addressed.

    Please check the menus as well as the status bar with a filter applied.

     
    • Bill

      Bill - 2020-09-21

      Thanks for the quick updates!

      I think that I reveiwed everything that was available to me, and hopefully this is viewed as trying to be helpful rather than trying to be picky! :)

      When I tried the updated version, it looks much better. All the items I described in my initial description above have been resolved. I'm going to describe everything that I see. Several of the items are likely unimportant and could be ignored, but I wanted to be thorough. The unimportant ones could be ignored without any sort of usability issue.

      As I'm going through all items, I find the following:

      • I can't get a screen shot of this, but on the menu items (e.g. the "File" menu from the main window), the icons to the left of the words overlap with the word, and they are a bit taller than the word. For example, the folder icon that is supposed to be to the left of "New..." is too wide, and it goes under the letter "N". The also applies to the sub-menus like "File">"Export To". And, it applies to all menus.
      • An unimportant related issue is that the menu icon is taller than the word "New...". Perhaps it could be scaled to be the same height as the word in some way? (Again, not important.)
      • The search box (green at the bottom of the "main window") is now narrow. This isn't a big issue, but it looks narrower than expected.
      • In the "Add Entry" window, the blue question mark icons on the right are small as is the icon on the button to the right of "Generate" near the middle of the window. (All tabs other than "Basic" have no issues.) The same is true for the "Edit Entry" window which looks effectively identical. This is also true for the "Generate Password" windows (Ctrl+P or Manage>Generate Password).
      • The "Delete Confirmation" window when choosing to delete an entry has more space than required, but that is also not important.
      • Similar to the small blue icons in the "add entry" window, the "Options" window has small blue question mark icons. The same is true on all of the options tabs beyond backup, too. (I didn't make a screen shot for each one since it is the same issue, but if it is helpful, I can.)
      • The keyboard icon on the "Compare" window is small. (And unimportant, but there is a lot of empty space on that window.) The same is true on the "Merge" window. The same is true on the "Synchronize" window. The same is true for the "Change Safe Combination" window.
      • The red font on the bottom of the "Synchronize" window is very small. (And, I confirmed that all of my font size options are set to 11 point which should be larger than that.) The same is true for the "Export to plaintext" and the "Export to XML" windows.
      • (Mostly unimportant) The font size on the "Properties" window is a bit small.
      • FYI, all items under View>Report are grayed out for me, so I could not check them.
      • For the "Password Policies" window, the text at the top and middle of the window is small along with the button text ("Available Password Policies:" and "Selected policy details:"). And, the icon next to the "Test Selected Policy" text box is small.
      • Note that under "Customize Toolbar" everything looks good including the fact that the icon does not go under the text.
       
    • MrMe

      MrMe - 2020-09-22

      Hi Rony,

      I'm testing using "Override high DPI scaling behaviour" set to "System (Enhanced)" in Compatibility for pwsafe.exe and in my Windows Settings > System under 'Scale and Layout', I am using Windows recommended percentage of 200% for 'size of text, apps and and other items'. I also configure font size for Tree/List, Add/Edit, Password, Notes, etc. to 11 or 12 pt.

      On my 2K screen, the updated beta files unfortunately still behave like in Figure-1 and Figure-2.

      I do not see many of the issues Bill reported for the updated beta version in his testing. The main dialogs with text input fields that are not scaling or have tiny images that I've seen so far are:
      1) Any that require the safe password. For example Manage>Change Safe Combination...
      2) Create Shortcut
      3) The Password Policy dialogs and text field have tiny text
      4) The ? on the 'Display Subset of Password' dialog are tiny
      5) Editing Name and Description input fields in File>Properties
      6) Manage>Generate Password

      What's interesting is that v3.53 doesn't have any of the above issues on my 2K screen, so I'm not sure if any effort to make high dpi changes are necessary if Windows scaling is properly configured by the user.

      Minor Issues:
      1) The M in AM or PM is partially cutoff in the last clipboard action of the status bar, so that field may need to be increased a little bit taking pixels from the status bar first field. FYI...v3.53 does have this issue.

       
  • Rony Shapiro

    Rony Shapiro - 2020-09-21

    Couldn't ask for better input - many thanks!
    Don't expect to have much time to work on this before the weekend.
    I'll update here when I have a new version ready.

     
    • MrMe

      MrMe - 2020-09-21

      Hi Bill,

      1. Are you using "Override high DPI scaling behaviour" set to "System (Enhanced)" in Compatibility for pwsafe.exe?
      2. In Windows Settings > System under 'Scale and Layout', are you using the Windows recommended percentage for 'size of text, apps and and other items'
       
      • Bill

        Bill - 2020-09-21

        For 1, I didn't make a change to the unzipped file for testing. So, I don't think so. (I did make that change while testing before.)
        For 2, on one monitor, I use the windows-recommended scaling (150% on a large monitor) and on the other I set it lower (200% when it recommends 300% on my laptop monitor).

         
        • MrMe

          MrMe - 2020-09-22

          Then, I would recommend testing with "Override high DPI scaling behaviour" set to "System (Enhanced)" in Compatibility for pwsafe.exe

           
  • Murad Khan

    Murad Khan - 2020-09-21

    You guys are both amazing. I enjoyed y'alls interchange in regards to this request from Mr.Bill.

     
  • Rony Shapiro

    Rony Shapiro - 2020-09-26

    Hi,

    I've uploaded a new version of the "DPI Beta" to https://sourceforge.net/projects/passwordsafe/files/PreReleases/3.54.0dpiaware-beta/
    This should address most of the issues raised here. It's probably not perfect, question is if it's Gooud Enough for a formal release?

     
    • Bill

      Bill - 2020-09-26

      I think that it looks near-perfect, and definitely good enough for a formal release since it makes the visuals so much better for high DPI monitors.

      Almost all of the items I listed last week are resolved. And, I would say that all of the most important ones are resolved.

      I'm again hoping that the list below is considered as helpful and not nit-picky.

      • The on-screen keyboard icon appears to be small. I thin that it is small everywhere it is used. I found it on:
        • The unlock database window
        • The merge database window
        • The compare database window
        • The synchronize database window
        • The change to R-W window
        • The export to XML window
        • The export to plain text window
        • The change safe combination window
      • The minor note that the search box is narrow remains.
       
  • MrMe

    MrMe - 2020-09-27

    Hi Rony,

    I am now testing this using "Override high DPI scaling behaviour" set to "Application" in Compatibility for pwsafe.exe (I believe also that Windows default to Application if user doesn't change Compatibility settings for the executable). Also my font size for Tree/List, Add/Edit, Password, Notes and Virtual Keyboard is set to 11pt.

    This build is now quite a bit better on my 2K screen. I'd say it's almost ready for formal release. Please see some comments in attached picture.

    Can I also recommend building the executable with Tree/List, Add/Edit, and Notes font set to 'Segoe UI Symbol', Regular, 11 pt with Password and Virtual Keyboard font set to 'Consolas', Regular, 11pt. I have been using this setup for years and it has some good benefits and has worked very well in all version of Windows since Windows 7.

    I also mentioned in my comments being able to better space the tool bar icons. Maybe a 5 pixel (or whatever makes sense) spacer can be introduced in customize mail tool bar that the user could use to do this themselves.

     
    • MrMe

      MrMe - 2020-09-27

      Hi Rony,

      A couple more issues I've seen.

      1. The find bar font for number of matches found and other text is tiny
      2. This one is not really related to dpi awareness, but something I never noticed before that I'll mention here. For any Export of items (e.g. File> Export to>XML format) where the passwprd needs to be entered, there is no checkbox to show password like is seen when changing safe from R-O ro R/W or when changing safe password.
       
  • Rony Shapiro

    Rony Shapiro - 2020-09-27

    Cool. Just uploaded the last (hopefully) update. This should fix the following:

    • Width of the find text window
    • Size of the virtual keyboard graphic
    • Size of the Yubikey graphic

    Button spacing and font of find result are a bit tricky to fix w/o a high res monitor.
    Default font changes - will consider in main branch, as this is orthogonal to the DPI issue. Likewise the missing "Show password" checkboxes.

     

    Last edit: Rony Shapiro 2020-09-27
    • Bill

      Bill - 2020-09-27

      Thanks for this update. The find text window looks good. The virtual keyboard graphic may be a bit larger, but it still seems on the small side (I would say that it is not something that would hold back release). I don't know where the Yubikey graphic is. I've attahed a few screenshots for the keyboard image.

       
    • MrMe

      MrMe - 2020-09-27

      Okay, thanks.

      I will test later today and provide feedback.

      Wouldn't having a spacer option (maybe a small and medium) in Manage>'Customize Main Toolbar' give user the ability to customize this button spacing themselves.

      Not sure if this would work, but regarding fonts used throughout the program, for example, any user input textbox, find results etc., I was thinking a solution could be to make those use the font and font size configured for the Add/Edit font, which is the font size that the user cannot make too large otherwise it would not fit the Add entry username text box and from what I can tell as a Password Safe user, all other textboxes/textareas appears to be the same height of the Add entry username textbox or greater.

       
      • MrMe

        MrMe - 2020-09-27

        Hello Rony,

        As Bill mentioned, in this build the size of the virtual keyboard graphic is still small, but it's not a deal breaker.

        To answer your question, I would agree that it is good enough for a formal release.

         
  • Rony Shapiro

    Rony Shapiro - 2020-09-28
    • status: open --> pending
    • assigned_to: Rony Shapiro
     
  • Rony Shapiro

    Rony Shapiro - 2020-09-28

    Fixed in commit 0b63d2cb5, will be in next release.

     
  • Rony Shapiro

    Rony Shapiro - 2020-10-09
    • Status: pending --> closed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.