Entry with reoccuring expiration is red even after password change
Popular easy-to-use and secure password manager
Brought to you by:
ronys
Menu
▾
▴
2 Attachments
#1497 Entry with reoccuring expiration is red even after password change
The attached picture show-password-not-changed.PNG shows the "Dates and TImes" tab of a password safe entry "domain" that expires on 2019-09-10 and was last changed on 2019-06-17. The red square above the entry is from the main Password Safe window and is, I believe, marking an entry with an expired password. But picture show-password-changed.PNG shows the "Additional" tab for the same entry and shows that the entry had its password set on 2019-09-09. The "Basic" tab shows the new password.
Version V3.49.01 64-bit on Windows 10.
The password was set before the expiration date, and the expiration date has passed, so it should be marked red - no problem here.
The descrepency between the password history and the Password Last Changed value is more interesting: I'd expect the history value to be older than the Last Changed value, not newer. Will look into this.
I use password expiration for passwords that must be changed every 'n' days. To avoid lock out, I try to change the password before it expires. So, my expectation is that setting the password will reset the expiration date to the current date and give me another 'n' days.
Fixed in commit 8ceff45f3, will be in next release.
There's something odd going on here.
v3.51 (g18fb9761e+ 64-bit Built on Dec 26 2019 19:58:34) seems to have introduced that bug (for me) rather than fixing it!
I'm using 64-bit Password Safe on 64-bit Windows 7 SP1
I have several database entries with recurring expiry dates, typically 365 days, and I usually generate new passwords before the expiry date, and all versions up to and including 3.50 have worked as expected, resetting the expiry date (to 365 days in the future) when I generated a password.
However v3.51 does not change the expiry date if I generate a new password.
Steps to reproduce the problem, with Windows 7 SP1 64-bit and Windows 10 64-bit.
For all tests:
- Clock synchronisation (with internet time server and/or VirtualBox host) is disabled, because I'm going to adjust the clock date manually
- The PC is configured with date format yyyy-mm-dd
- Password Safe uses all default settings. (I deleted the config file before starting the tests)
- All passwords are randomly generated using the Generate button
Set the computer's date to 2019-01-01
Create a new database
Manage, Options, Password History, Save 3 previous passwords per entry
Create new entry (title, password, no other fields), with Password Expiry in 90 days, Recurring.
Check password expiry date is 2019-04-01
Exit Password Safe.
Adjust the computer date/time forward by 1 month, to 2019-02-01
Run Password Safe and open the database
Edit the entry, Generate a new password, and click OK to close the Edit Entry dialog.
Edit/view the entry again (and/or using List view), check the Dates and Times tab - Password Modified date is 2019-02-01 (as expected), but Password Expiry is 2019-04-01, when it should be 2019-05-02 (90 days after Modified date 2019-02-01).
However if I then generate another password, the expiry date changes to 2019-05-02
I ran the above tests with v3.49.1 and 3.50, and both of those versions worked OK, resetting the expiry date. It's only v3.51 that has the problem.
I can also reproduce the problem using my normal database and configuration, and no clock trickery (which is how I noticed it in the first place). For example I have an entry with an expiry date of 365 days recurring, password last changed 2019-03-02 and thus expiring 2020-03-01. If I generate a new password today with v3.51, the password modification date becomes 2019-12-28, but the expiry date does not change (unless I generate a second password today). If I do the same thing with v3.50, the expiry date is updated correctly.
I have noticed the same. OK in 3.48, broken in 3.51.
I've downgraded from 3.51 to 3.50 cause of this effect.
( Otherwhise the "reds" would flood me and my file ;-). )
And in consequence I'd to reset the meanwhile changed, but nevertheless red, items again, because they remained red after the downgrade.
I think that the title of this bug is misleading.
I believe that the title of bug 1503 is more accurate: "Recurring Expiration Date Not Updated on Password Change."
Pre-release V3.5.2pre (gdc336b216+) 64-bit built on Apr 10 2020 11:22:14 - from https://sourceforge.net/p/passwordsafe/bugs/1512/#485d - fixes the problems I described above ( https://sourceforge.net/p/passwordsafe/bugs/1497/#2453 )