#1217 Adding a new group at root level not possibel after item selected

[Bogdan Hlevca]

Adding a new group at root level is possible only when opening the application and have no group or item selected.

After selecting a group or an item in a group adding new groups is possible only as a nested (sub) group. I could not find a way to remove completely the selection
except by restarting the program. This should be fixed.

[DrK]

I can't reproduce this on Windows with the latest release.

1. Select a Group and any new group via "Edit menu->Add Group" or "Right click context menu->Add Group" will be a subgroup of it (this is correct behaviour).
2. Select an item at root level and any new group via "Edit menu->Add Group" or "Right click context menu->Add Group" will be in the root.
3. "Right click contect menu->Add Group" in the 'white space' below the last group/item in the tree display will also create a root level group.

There is no mechanism to unselect an item and you do not need to restart PasswordSafe to add a root level group.

[Bogdan Hlevca]

I did not test in Windows, but on Linux it does not work the way you describe it. I suggest that you test it on Linux too.

Your #3 Click in the white space below does not work on Linux. Therefore as I explained when filing the bug it is not possible to add a root group after something was selected. The context menu (I call it floating menu) appears on Linux only if you right click an item.

If you want to have it working on Linux then I think that there are a few options:
1) find the mechanism to enable a floating menu when clicking the white space
2) add a mechanism to deselect
3) add group could ask if you want a child group or a root group.

Currently, on Linux (on KDE) restarting the application is the only option for adding a root level group after something was selected.

As a side note unrelated to this issue, it would be nice if you let us choose monochromatic icons. On my 10-bit/channel system the icons look really ugly. They are fine on 8-bit/channel colour depth (or better known as 24 bit True colours)

[DrK]

Sorry, you didn't specify your environment and so I assumed, incorrectly, it was Windows.

I only work on that version but I will make a Linux developer aware of your issue and hopefully they can make the different versions compatible so that users can switch between environments without having to learn different techniques.

[JP Vossen]

This works for me on Linux Mint 17 using PWS 0.97 and "Edit > Add Group". Right-clicking white-space does nothing (no menu, nothing). HOWEVER, you have to select a top-level item, NOT a top-level group, else you get a sub-group (as expected).

[Bogdan Hlevca]

Yes, it workls that way in Opensuse too, but it is counterintuitive and wrong. The standard way of doing this type of operations is the way it is done in Windows. In addition, it should be consistent with the other operations.

[JP Vossen]

I'm not sure I follow you. In particular, at the top you say "Adding a new group at root level is possible only when opening the application and have no group or item selected." but that is not what I see. You can do it, you just have to select any random item that is not a group or else you get a sub-group with make perfect sense to me.

I do not agree that the Windows way is the "right" way, but I do agree that PWS should be consistent and that the Windows version came first and is thus probably the best reference.

[Bogdan Hlevca]

There is not much to follow. I agree that it is possible, but in a quirky way. I can envision even more complicated and unatural ways to do things, Perhaps now the title is a little misleading, However, as you admitted, the UI needs to behave consistenly across the plaftforms and consistently with its own rules.
Selecting a top element in a top group is not the best way to create a new group in the root. The way PWS does it in Windoes is the right way. Any file manager will behave the same way, you point your mouse pointer in the space where you want to create a new item. I don't want to create a new group in the first item of a random top group. This is plain wrong.

This is still a bug, even though it can be described as a bug of style rather than a bug of functionality.

Note: Just fixed the numeroud typos in my previous post

[JP Vossen]

I can't argue with that. Perhaps the bug is better described as a missing right-click menu then? That is certainly missing, and while I personally don't care, you make a good case for it. :-)

[rafaelx]

The current implementation makes use of an item specific event handler (EVT_TREE_ITEM_MENU), so that a context menu gets only shown if a tree item gets a right-click. Unfortunately, due to a bug in the Wx framework, the event handler of type EVT_CONTEXT_MENU doesn't work, if clicking on an empty area of the item tree.

A clean solution could be provided with Wx version 3.1.1 to get the same behavior as the Windows version has without introducing any workarounds.

[rafaelx]

Resolved by 06403ca63d93e7300cd2862cfe055af15ab5a186.

[rafaelx]

Fix released with 1.09.

Remark: Issue 619.