#1048 Empty diamond icon in group with dragged entries.

v1.0_(example)
closed
5
2013-01-09
2012-07-01
mikamves
No

When I create a new group and move some existing entries (by dragging) from other group to new one then diamond is still empty. It will fill only when I create a total new entry in new group. I checked this few times. I use 3.29 release on Windows 7 Ultimate SP1 x86.

Discussion

  • N VENKATA SAI PRAVEEN

    This is interesting ..I would like to fix this bug..Can you assign it to me ?

     
  • Rony Shapiro

    Rony Shapiro - 2012-07-21

    Hi nsiapraveen,

    Thanks for offering to help - please let me know if you've any questions re the development environment, committing the fix, etc.

    Rony

     
  • N VENKATA SAI PRAVEEN

    Thank u Ronys ! I have started my work !!

     
  • N VENKATA SAI PRAVEEN

    Hello, I am working on the code but would like some help. Can you suggest specific files in the code related to the bug ??

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-16

    src/ui/Windows/PWTreeCtrl.cpp is where you want to look.
    The (empty) diamond is CPWTreeCtrl::(EMPTY_)GROUP
    The function called when moving an item is CPWTreeCtrl::MoveItem()

    Rony

     
  • Bharat

    Bharat - 2012-08-21

    In the CPWTreeCtrl::MoveItem() even if the CPWTreeCtrl::GROUP is being set as the image for the hitemDrop but the change wont be reflected in the UI. How does the UI get updated?

     
  • Bharat

    Bharat - 2012-08-21

    Problem is here: m_pDbx->IsEmptyGroup(StringX(group)) is returning true for a group when dragged into and false when Adding an Entry happens. Any ideas on where to look to make this become false?

     
  • N VENKATA SAI PRAVEEN

    I am working on another bug and may not get enough time for this one...Can you assign this bug to another guy who is willing to work on this one ??

     
  • Bharat

    Bharat - 2012-08-21

    Hi Rony,
    I would like to take over from Praveen. The bug is fixed. The call to PWScore::RemoveEmptyGroup had to be made when a drag and drop occurs so that the status of the final group will be removed from list of empty groups in PWScore. This was being called when "Add Entry" was made and was missing during the drag operation.
    This addition was in PWTreeCtrl::OnDrop(). This appeared better place to call it than MoveItem which OnDrop calls.

    //Added code to make sure that the folder on which drag is performed will
    //be removed from the vector of empty groups
    PWScore pcore = (PWScore )m_pDbx->GetCore();
    StringX sxGroup(GetGroup(hitemDrop));
    if (pcore->IsEmptyGroup(sxGroup)) {
    pcore->RemoveEmptyGroupWhenDragged(sxGroup);
    }

    //Where RemoveEmptyGroupWhenDragged is a public function added to access private member //function RemoveEmptyGroup
    bool PWScore::RemoveEmptyGroupWhenDragged(const StringX &sxEmptyGroup)
    {
    return RemoveEmptyGroup(sxEmptyGroup);
    }

    I dont know how to add this as a patch. Help please!

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-22

    Thanks. The patch still needs some work - comments sent separately.

    Rony

     
  • Rony Shapiro

    Rony Shapiro - 2012-08-23

    Fix based committed in revision 5040. Thanks!

     
  • Rony Shapiro

    Rony Shapiro - 2013-01-09
    • status: pending --> closed
    • milestone: --> v1.0_(example)
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks