From: D M G. <dm...@uv...> - 2009-11-10 22:37:23
|
hi everybody, i am reverting to revision 1118. The reason is that the current errors have stayed for too long, and people can't compile the HEAD. Also, let us create a new directory for these files, since we should really try to keep libpano a library (and remove in the future the tools directory in its entirety). deleting tools/mpremap Deleting tools/mpremap.c Deleting tools/mpremap.rc Deleting tools/mpremap.vcproj Deleting tools/ppmstream.c Deleting tools/ppmstream.h Deleting tools/preprocess.c Deleting tools/spline.c Deleting tools/string2.c Deleting tools/string2.h -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: dmg <dm...@uv...> - 2009-11-10 22:49:27
|
Sorry, I went one commit too far. Reverting revert of 1120. On Tue, Nov 10, 2009 at 2:37 PM, D M German <dm...@uv...> wrote: > > hi everybody, > > i am reverting to revision 1118. The reason is that the current errors > have stayed for too long, and people can't compile the HEAD. > > Also, let us create a new directory for these files, since we should > really try to keep libpano a library (and remove in the future the tools > directory in its entirety). > > deleting tools/mpremap > Deleting tools/mpremap.c > Deleting tools/mpremap.rc > Deleting tools/mpremap.vcproj > Deleting tools/ppmstream.c > Deleting tools/ppmstream.h > Deleting tools/preprocess.c > Deleting tools/spline.c > Deleting tools/string2.c > Deleting tools/string2.h > > > -- > -- > Daniel M. German > http://turingmachine.org/ > http://silvernegative.com/ > dmg (at) uvic (dot) ca > replace (at) with @ and (dot) with . > > -- --dmg --- Daniel M. German http://turingmachine.org |
From: Jim W. <jwa...@ph...> - 2009-11-12 00:31:13
|
Would have been nice to discuss these errors. I'll add MPRemap to a new directory. -- Jim Watters http://photocreations.ca D M German wrote: > hi everybody, > > i am reverting to revision 1118. The reason is that the current errors > have stayed for too long, and people can't compile the HEAD. > > Also, let us create a new directory for these files, since we should > really try to keep libpano a library (and remove in the future the tools > directory in its entirety). > > deleting tools/mpremap > Deleting tools/mpremap.c > Deleting tools/mpremap.rc > Deleting tools/mpremap.vcproj > Deleting tools/ppmstream.c > Deleting tools/ppmstream.h > Deleting tools/preprocess.c > Deleting tools/spline.c > Deleting tools/string2.c > Deleting tools/string2.h |
From: D M G. <dm...@uv...> - 2009-11-12 04:25:25
|
Jim Watters twisted the bytes to say: Hi Jim, Jim> Would have been nice to discuss these errors. Jim> I'll add MPRemap to a new directory. I have rebased and recommitted your changes that were not part of adding MPRremap. I agree we should have discussed them before. I looked at them and the problem is these two deltas: sys_ansy.* should have simple ansi c functions. I don't understand why you were adding these two functions to it. They should go to another of the "sys_*" files that deals with these interfaces. Can you explain us their rational? ---------------------------------------------------------------------- dmg@phosphorus:~/hacking/libpano.clean/libpano$ diff sys_ansi.h ../other/ 43a44,46 > void SetWindowOwner(HWND Owner); > void CenterDialog(HWND hDlg); > dmg@phosphorus:~/hacking/libpano.clean/libpano$ diff sys_ansi.c ../other/ 27a28,29 > void SetWindowOwner(HWND Owner) {return;} > void CenterDialog(HWND hDlg) {return;} ---------------------------------------------------------------------- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: Jim W. <jwa...@ph...> - 2009-11-12 05:02:38
|
Daniel, Thank you. When I cleaned up the .def files I commented out many functions. These two are needed by the plugins and could not be removed. But if a command (ansi ) version was created then there was a linking error of these two functions not existing. They already existed in sys_win. I was just trying to create empty functions that allowed building on Windows both a CMD and GUI version. I believe instead of "HWND" "void *" should have been used. This is all because I was trying to maintain building both static and dynamic link libraries of libpano. I build with sys_ansi for the CMD line tools, and sys_win for the plugins with GUI. Jim D M German wrote: > Jim Watters twisted the bytes to say: > > Hi Jim, > > > Jim> Would have been nice to discuss these errors. > Jim> I'll add MPRemap to a new directory. > > I have rebased and recommitted your changes that were not part of adding > MPRremap. I agree we should have discussed them before. > > I looked at them and the problem is these two deltas: > > sys_ansy.* should have simple ansi c functions. I don't understand why > you were adding these two functions to it. They should go to another of > the "sys_*" files that deals with these interfaces. > > Can you explain us their rational? > > > ---------------------------------------------------------------------- > dmg@phosphorus:~/hacking/libpano.clean/libpano$ diff sys_ansi.h ../other/ > 43a44,46 > >> void SetWindowOwner(HWND Owner); >> void CenterDialog(HWND hDlg); >> > dmg@phosphorus:~/hacking/libpano.clean/libpano$ diff sys_ansi.c ../other/ > 27a28,29 > >> void SetWindowOwner(HWND Owner) {return;} >> void CenterDialog(HWND hDlg) {return;} >> > ---------------------------------------------------------------------- > > > -- > Daniel M. German > http://turingmachine.org/ > http://silvernegative.com/ > dmg (at) uvic (dot) ca > replace (at) with @ and (dot) with . -- Jim Watters http://photocreations.ca |
From: D M G. <dm...@uv...> - 2009-11-12 05:32:46
|
Hi Jim, Sure, that sounds good. Also, we could move them to the plugins, if they are only used by them. --dmg Jim> When I cleaned up the .def files I commented out many functions. These Jim> two are needed by the plugins and could not be removed. But if a Jim> command (ansi ) version was created then there was a linking error of Jim> these two functions not existing. Jim> They already existed in sys_win. I was just trying to create empty Jim> functions that allowed building on Windows both a CMD and GUI version. Jim> I believe instead of "HWND" "void *" should have been used. Jim> This is all because I was trying to maintain building both static and Jim> dynamic link libraries of libpano. I build with sys_ansi for the CMD Jim> line tools, and sys_win for the plugins with GUI. Jim> Jim -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . |
From: dmg <dm...@uv...> - 2009-11-12 05:38:45
|
Hi Jim, If we keep the functions in ansy_sys.c there should be a comment around them saying why they are there and why they are empty. --dmg |