Menu

Panotools::Script Merge Request #1: Verify nona-mask flag arguments before appending (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Josh wants to merge 2 commits from /u/just-josh/panotools/ to default, 2020-11-02

Some flags, such as -v and -c, are not paired with values.
There are already checks in place for them so that the following argument is not appended as a paired value.

Unfortunately, these checks do not account for flags such as --seam=blend.
As a result, subsequent flags are incorrectly parsed.

Commit Date  
[ce6ea6] (nona-mask-flag-parsing-fixtip) by just-josh

Remove -v and -c flag checks from nona-mask

They were implemented to insure that the following flag was not treated as an argument to the current one.

This is no longer needed since we now check if the next @ARGV element is a flag.

2020-11-02 18:08:05 Tree
[c3824d] by just-josh

Check if nona-mask flag arguments are flags

Some flags, such as -v and -c, are not paired with values.
There are already checks in place for them so that the following argument is not appended as a paired value.
Unfortunately, these checks do not account for flags such as `--seam=blend`.

2020-11-02 17:53:54 Tree

Discussion

  • Bruno Postle

    Bruno Postle - 2020-11-02
    • Status: open --> merged
     
  • Bruno Postle

    Bruno Postle - 2020-11-02

    Thanks changes seem good, committed

     

Log in to post a comment.

MongoDB Logo MongoDB