pagekit-devel — For PageKit Developers only.

Re: [Pagekit-devel] Suggestion for language localization

[Boris Z. <bo...@2b...>]

Hi Erik,

Am Mittwoch, 11. September 2002 12:32 schrieb Erik G=FCnther:
> We have had a site in fore different language so we know about language
> localization. In our experience having a template in fore different
> language don't work. We did instead build fore different templates tree
> that contained all the templates for one language.
>
> So our suggestion is to enable pagekit to use one or both the new ways
> to handle local View and local Content data.

Please let us do only one way, it is already a second choice.

>
>
> 1) As suggested for Content::XSLT. Use of foo.tmpl.se, foo.tmpl.fi osv.
>    Both the View and Content should use this language extensions. It
>    might be possible do have all Content data in separated trees in one
>    file but then again often there are several people editing the data
>    and you get a multi access problem.
>
>
> 2) Having separated trees for each language. Much like View function to
>    day but for language. This have to be done both for Content and View.

It is already possible for pkit to have some language trees if you only w=
ant=20
to choice the language from the prefered language in the http headers.

The hard part is if your header says 'se' but you prefer to read the site=
 in=20
'de' and store your wish in a session. And now think what happened if a p=
age=20
only exist in de and not in se.

Ofcourse this is only true if you also want different model_code for the =
pages=20
in different languages too. But this is implied by (2). And not by (1).

Sure 2 can also use only the View. Our layout is then: for (2)

View/Default/de/page.tmpl
View/Default/de/page2.tmpl
View/Default/de/page3.tmpl
View/Default/se/page.tmpl
View/Default/se/page2.tmpl
View/Default/se/page3.tmpl

and for (1)

View/Default/page.tmpl.de
View/Default/page.tmpl.se
View/Default/page2.tmpl.de
View/Default/page2.tmpl.se
View/Default/page3.tmpl.de
View/Default/page3.tmpl.se

for (1) it is possible(desired?) to omit .de if this is the default lang =
in=20
Config.xml

View/Default/page.tmpl
View/Default/page.tmpl.se
View/Default/page2.tmpl
View/Default/page2.tmpl.se
View/Default/page3.tmpl
View/Default/page3.tmpl.se

At this point i like (1) more, since it is not that easy to forget a need=
ed=20
template and someone is not tempted to add pictures and so on in a langua=
ge=20
tree.

>
>
> That Content should use these language extension are quite obvious. It
> contains localization data. The View should also have localization
> because of different layout. The layout can different because of the
> space a language takes or local demands (eg. Different requirements for
> payment) and remember many websites usage quite advanced layouts. Of
> cause if there aren't any Content or View in local language it should
> default to something, in the same way its done to day with pkit_lang.
>
> Both of the above structures are quite easy to implement and the second
> one is all ready done in pagekit. The first one Apache all ready does i=
n
> one module. It might be possible to use the same algorithm in pagekit.
>
> To keep all option open I suggest that both way are implemented and
> todays xml:lang stays.

--=20
Boris

[Pagekit-devel] Suggestion for language localization

[Erik <eri...@bo...>]

We have had a site in fore different language so we know about language
localization. In our experience having a template in fore different
language don't work. We did instead build fore different templates tree
that contained all the templates for one language.=20

So our suggestion is to enable pagekit to use one or both the new ways
to handle local View and local Content data.


1) As suggested for Content::XSLT. Use of foo.tmpl.se, foo.tmpl.fi osv.
   Both the View and Content should use this language extensions. It
   might be possible do have all Content data in separated trees in one
   file but then again often there are several people editing the data
   and you get a multi access problem.
  =20

2) Having separated trees for each language. Much like View function to
   day but for language. This have to be done both for Content and View.

    =20
That Content should use these language extension are quite obvious. It
contains localization data. The View should also have localization
because of different layout. The layout can different because of the
space a language takes or local demands (eg. Different requirements for
payment) and remember many websites usage quite advanced layouts. Of
cause if there aren't any Content or View in local language it should
default to something, in the same way its done to day with pkit_lang.

Both of the above structures are quite easy to implement and the second
one is all ready done in pagekit. The first one Apache all ready does in
one module. It might be possible to use the same algorithm in pagekit.

To keep all option open I suggest that both way are implemented and
todays xml:lang stays.=20

  =20
--=20

   /erikg=20
  =20
Erik G=FCnther                                     eri...@bo...
System Developer                                               Bokus AB
+46 (0)40 - 35 21 19                                           =20
 =20
Fortune:
Madness takes its toll.

[Pagekit-devel] doc fixes

[Boris Z. <bo...@2b...>]

Hi,

Add docs for <PKIT_ELSE>, <PKIT_IS_ERROR>, <PKIT_NOT_ERROR> and 
pkit_component_params_hashref
-- 
Boris

[Pagekit-devel] pkit_validate_input

[Boris Z. <bo...@2b...>]

Hi,

this patch let pagekit work with Data::FormValidator >= 1.11. Noticed by  

Paul G. Weiss

-- 
Boris

[Pagekit-devel] ANNOUNCE: PageKit 1.10

[Boris Z. <bo...@2b...>]

Hi,

i have just uploaded a new release of Apache::PageKit to CPAN. You can find it 
here in a short time.

http://www.cpan.org/authors/id/B/BO/BORISZ/

or more info from http://www.pagekit.org/

the whole Changelog is available here:
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/pagekit/Apache-PageKit/Changes?rev=1.169&content-type=text/vnd.viewcvs-markup

thanks for all the bugreports and feedback.


1.10
 	- Add a note to the docs, that some pages can not be protected
		(Boris Zentner, Rob Starkey)
	- Fix some links in the eg site to work in a different
		location (Boris Zentner)
	- Do not deliver a page direct if the client forget to add a '/'
		instead redirect to the right place. This is done to get
		relative links right. (Boris Zentner)
	- Prepare PageKit for W32 (Boris Zentner)
	- Avoid changing apr->filename and apr->path_info
		(Boris Zentner)
	- Fix warning, when the clients browser did not send a
		User-Agent header. (Boris Zentner)
	- Fix for startup when passed parameter should override
		PKIT_ROOT and PKIT_SERVER settings (TJ Mather)
	- Workaround another UTF conversion bug in perl 5.6.1
		(Boris Zentner, Gabriel Burca)
	- Fix docs for PKIT_HAVE_MESSAGES and PKIT_HAVE_NOT_MESSAGES
		(Boris Zentner)
	- Fix: pkit_edit translate & to &amp; since <textarea> holds
		#PCDATA, but we want it raw. (Boris Zentner)
	- Fix warning, when pkit_auth_session_key is called with a session
		without a user_id or the database can not provide a login
		or passwd. (Boris Zentner)
	- Fix: do NOT cache the page, that force us to login (Boris Zentner)
	- Fix warning, when a pkit_macro tag is used without the same
		parameter in the pkit_component tag (Boris Zentner)
	- Fix pkit_input_hashref for the case where you request the hash,
		change something and request the hash again. In error
		you get the old value(s) back. (Glenn Morgan)
	- Fix call pkit_on_error before the session data is saved. 
		So you can rollback the changes, even if your session
		data is in the same db with your application.
		(Boris Zentner)
	- Fix replace <PKIT_ERRORSTR> even inside pkit_message 
		strings. (Boris Zentner)
	- Use parameters for Apache::PageKit->startup if we can not
		find PKIT_ROOT and or PKIT_SERVER for 
		mod_perl >= 1.06 (Boris Zentner)
	- Add patch to use <PKIT_ERRORSPAN> and <PKIT_ERRORFONT>
		without a name attribute. (Boris Zentner)
	- Add: component subs are called with component-parameters.
		See pkit_component_params_hashref
		(Boris Zentner)
	! Component code is called inorder from top to the bottom
		(Boris Zentner)
	- Fix: bug, where path relative components are not listed 
		as an edit component. (Boris Zentner, Gabriel Burca)
	- Fix: A errormessage is fixed, that report file is out of
		the root_dir even if the file is not found.
		(Boris Zentner, Gabriel Burca)
	- Add new server option cookie_postfix. To name cookies just for the
                case, that multiple pkit applications run  in the same
                apache server. (Boris Zentner, David Raimbault)
	- Fix: write the session data and destroy the db connection
		even if an error transpires (Boris Zentner)
	- Fix: defer delivery of static pages if parameters are attached to
		the URI. This allows to login/logout even with a static
		default page (Boris Zentner)
	- Fix iconv conversion: it is perfect legal to convert an empty
		string '' to another charset (Boris Zentner)
	- Add new tags <PKIT_HAVE_MESSAGES> and <PKIT_HAVE_NOT_MESSAGES>
		(Boris Zentner, Sebastian Feuerstack)

-- 
Boris

[Pagekit-devel] add some docs

[Boris Z. <bo...@2b...>]

hi,
-- 
Boris

[Pagekit-devel] some links are not relative.

[Boris Z. <bo...@2b...>]

Hi,
this patch make the eg site easier to move around.
-- 
Boris

[Pagekit-devel] redirect, do not deliver

[Boris Z. <bo...@2b...>]

Hi,

this patch redirect to a url with a '/' in case the client forgot it and the 
url represents a directory on our server.

-- 
Boris

[Pagekit-devel] prepare PageKit for Win32

[Boris Z. <bo...@2b...>]

Hi,

The PageKit example site runs fine for me on W2k.

-- 
Boris

[Pagekit-devel] do not use r->filename and r->path_info

[Boris Z. <bo...@2b...>]

hi,

this patch avoid the use of r->filename and r->path_info. It did not work on 
Win32 and in one case not on unix.

this need some research.

-- 
Boris

[Pagekit-devel] fix warning, if client send no useragent header

[Boris Z. <bo...@2b...>]

Hi,
fix warning, if client send no useragent header.
-- 
Boris

[Pagekit-devel] workaround apr->filenname

[Boris Z. <bo...@2b...>]

Hi,
this patch delivers static pages instead let Apache do the job. This is done 
for W32 and for some wired cases where your default page is static and not 
addressed propper on unix. Then apache/mod_perl want to deliver 
http://xx.yy.zz/index.html/ instead of http://xx.yy.zz/index.html.
-- 
Boris

Re: [Pagekit-devel] PageKit startup fix

[Boris Z. <bo...@am...>]

Hi TJ,

> In my example, I had something like:
>
> PerlSetVar PKIT_ROOT /path/to/foo
>
> <LocationMatch "baz">
> 	PerlSetVar PKIT_ROOT /path/to/bar
> 	Apache::PageKit->startup("/path/to/bar","staging");
> </LocationMatch>
>

You are right, we need the patch. I was not aware of this.

Thanks for this example.

--
Boris

Re: [Pagekit-devel] PageKit startup fix

[T.J. M. <tjm...@tj...>]

On Sun, 4 Aug 2002, Boris Zentner wrote:

> Am Sonntag, 4. August 2002 00:51 schrieb T.J. Mather:
> > This patch fixes the case when you want to override the PKIT_ROOT and
> > PKIT_SERVER settings in a location/directory apache section by passing
> > the parameters directly to the startup method.  Note to Boris - this
> > has been checked into CVS.
> 
> But we do not want to override the of PKIT_ROOT abd PKIT_SERVER in 
> Apache::PageKit->startup, just supress the need to add the same parameters to 
> the startup method.

In my example, I had something like:

PerlSetVar PKIT_ROOT /path/to/foo

<LocationMatch "baz">
	PerlSetVar PKIT_ROOT /path/to/bar
	Apache::PageKit->startup("/path/to/bar","staging");
</LocationMatch>

However, with the latest version of PageKit (without the patch),
startup would use "/path/to/foo" NOT "/path/to/bar".  I think this
is because mod_perl, upon startup, doesn't recognize the per 
Location/Directory PerlSetVar directives, and instead takes
the global PerlSetVar.  So in this case I need to explicitly tell
startup to use "/path/to/bar" and NOT "/path/to/foo"

> PKIT_ROOT and PKIT_SERVER must be the sameas pkit_root and pkit_server from 
> the startup method. If they differ we use PKIT_ROOT var on every request and 
> the pkit_root parameter of the startup method on startup.

No doubt.  The reason we need this patch is because mod_perl looks
at the global PKIT_ROOT/SERVER at startup, but in the Directory/Location
sections at runtime.  I'm not sure if this is a mod_perl feature or bug,
I think I recall reading somewhere that this was a fundamental restriction
in mod_perl.

> For some versions of mod_perl Apache->server->dir_config('anything') returns a 
> false value in error. So for this mod_perl version we fall back to use 
> pkit_root.

Yes, I understood there logic here, if mod_perl VERSION < 1.26 then 
fallback to using passed paramters.  However mod_perl 1.26 dir_config 
doesn't work for Directory/Location sections, so I think that we should
allow the user to set the PKIT_ROOT/SERVER variables to the correct ones.

-TJ

Re: [Pagekit-devel] PageKit startup fix

[Boris Z. <bo...@gm...>]

Hi TJ,

Am Sonntag, 4. August 2002 00:51 schrieb T.J. Mather:
> This patch fixes the case when you want to override the PKIT_ROOT and
> PKIT_SERVER settings in a location/directory apache section by passing
> the parameters directly to the startup method.  Note to Boris - this
> has been checked into CVS.

But we do not want to override the of PKIT_ROOT abd PKIT_SERVER in 
Apache::PageKit->startup, just supress the need to add the same parameters to 
the startup method.

PKIT_ROOT and PKIT_SERVER must be the sameas pkit_root and pkit_server from 
the startup method. If they differ we use PKIT_ROOT var on every request and 
the pkit_root parameter of the startup method on startup.

For some versions of mod_perl Apache->server->dir_config('anything') returns a 
false value in error. So for this mod_perl version we fall back to use 
pkit_root.

Or im missing something?

>
> Index: lib/Apache/PageKit.pm
> ===================================================================
> RCS file: /cvsroot/pagekit/Apache-PageKit/lib/Apache/PageKit.pm,v
> retrieving revision 1.202
> diff -u -r1.202 PageKit.pm
> --- lib/Apache/PageKit.pm	31 Jul 2002 08:07:38 -0000	1.202
> +++ lib/Apache/PageKit.pm	3 Aug 2002 21:53:23 -0000
> @@ -48,8 +48,8 @@
>    my $s = Apache->server;
>
>    if ( defined $mod_perl::VERSION && $mod_perl::VERSION >= 1.26 ) {
> -    $pkit_root = $s->dir_config('PKIT_ROOT')   || $pkit_root || die
> "PKIT_ROOT is not defined! Put PerlSetVar PKIT_ROOT /your/root/path in your
> httpd.conf"; -    $server    = $s->dir_config('PKIT_SERVER') || $server   
> || die "PKIT_SERVER is not defined! Put PerlSetVar PKIT_SERVER servername
> in your httpd.conf"; +    $pkit_root ||= $s->dir_config('PKIT_ROOT')   ||
> die "PKIT_ROOT is not defined! Put PerlSetVar PKIT_ROOT /your/root/path in
> your httpd.conf"; +    $server    ||= $s->dir_config('PKIT_SERVER') || die
> "PKIT_SERVER is not defined! Put PerlSetVar PKIT_SERVER servername in your
> httpd.conf"; } else {
>      $pkit_root || die 'must specify $pkit_root variable in startup. 
> Usage: Apache::PageKit->startup($pkit_root, $server)'; $server    || die
> 'must specify $server variable in startup.  Usage:
> Apache::PageKit->startup($pkit_root, $server)';
>
> -TJ
> http://maxmind.com/
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Pagekit-devel mailing list
> Pag...@li...
> https://lists.sourceforge.net/lists/listinfo/pagekit-devel

-- 
Boris

Re: [Pagekit-devel] UTF-8 encoding/decoding in PKIT_ERRORSPAN

[Gabriel B. <gb...@2b...>]

On Wed, 31 Jul 2002, Boris Zentner wrote:

> Hi Gabriel,
>
> now i looked into your testcase. And it is a bug in perl itself. Unfortunely
> it shows his face in pagekit and not in HTML::Template as before.
>
> For the workaround i use a patched HTML::Template and perl 5.6.1.
>
> It works as expected with this patch.
>
> Please let me know if it works for you.

Yes, that fixes it. I thought internationalization was fairly mature
in perl. I guess not.

Thank you.

--
gburca dash pkit at 2b dot 2y dot net

[Pagekit-devel] PageKit startup fix

[T.J. M. <tjm...@tj...>]

This patch fixes the case when you want to override the PKIT_ROOT and 
PKIT_SERVER settings in a location/directory apache section by passing
the parameters directly to the startup method.  Note to Boris - this
has been checked into CVS.

Index: lib/Apache/PageKit.pm
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/lib/Apache/PageKit.pm,v
retrieving revision 1.202
diff -u -r1.202 PageKit.pm
--- lib/Apache/PageKit.pm	31 Jul 2002 08:07:38 -0000	1.202
+++ lib/Apache/PageKit.pm	3 Aug 2002 21:53:23 -0000
@@ -48,8 +48,8 @@
   my $s = Apache->server;
 
   if ( defined $mod_perl::VERSION && $mod_perl::VERSION >= 1.26 ) {
-    $pkit_root = $s->dir_config('PKIT_ROOT')   || $pkit_root || die "PKIT_ROOT is not defined! Put PerlSetVar PKIT_ROOT /your/root/path in your httpd.conf";
-    $server    = $s->dir_config('PKIT_SERVER') || $server    || die "PKIT_SERVER is not defined! Put PerlSetVar PKIT_SERVER servername in your httpd.conf";
+    $pkit_root ||= $s->dir_config('PKIT_ROOT')   || die "PKIT_ROOT is not defined! Put PerlSetVar PKIT_ROOT /your/root/path in your httpd.conf";
+    $server    ||= $s->dir_config('PKIT_SERVER') || die "PKIT_SERVER is not defined! Put PerlSetVar PKIT_SERVER servername in your httpd.conf";
   } else {
     $pkit_root || die 'must specify $pkit_root variable in startup.  Usage: Apache::PageKit->startup($pkit_root, $server)';
     $server    || die 'must specify $server variable in startup.  Usage: Apache::PageKit->startup($pkit_root, $server)';

-TJ
http://maxmind.com/

Re: [Pagekit-devel] UTF-8 encoding/decoding in PKIT_ERRORSPAN

[Boris Z. <bo...@gm...>]

Hi Gabriel,

now i looked into your testcase. And it is a bug in perl itself. Unfortunely 
it shows his face in pagekit and not in HTML::Template as before.

For the workaround i use a patched HTML::Template and perl 5.6.1.

It works as expected with this patch.

Please let me know if it works for you.

Thanks for the detailed report!

Am Samstag, 27. Juli 2002 23:20 schrieb Gabriel Burca:
> I've noticed that encoding conversion is not done properly when the
> content is inside PKIT_ERRORSPAN. The file.tmpl shown below should have
> two identical lines. When the content is inside PKIT_ERRORSPAN, instead
> of a single s/S/t/T with a comma under, I get 2 characters (just like
> looking at UTF-8 text with a non-compliant viewer and seeing the 2bytes
> it takes to encode 1 character).
>
> It almost looks like the text is being converted twice.
>
> Outside the PKIT_ERRORSPAN, conversion works properly.
>
>
> file.xml
> --------------------------------------
> <?xml version="1.0" encoding="utf-8"?>
> <content>
> 	<ro_char_set xml:lang="ro">
> 		scedil &#x15F;
> 		Scedil &#x15E;
> 		tcedil &#x163;
> 		Tcedil &#x162;
> 	</ro_char_set>
> </content>
>
>
> file.tmpl
> ---------------------------------------------------------------
> <PKIT_ERRORSPAN NAME="some_name>
> 	<CONTENT_VAR NAME="document('file.xml')//ro_char_set">
> </PKIT_ERRORSPAN>
> <p>
> 	<CONTENT_VAR NAME="document('file.xml')//ro_char_set">
>
>
> Config.xml
> ----------
> <GLOBAL
> ...
> 	default_input_charset = "UTF-8"
> 	default_output_charset = "UTF-8"
> />
>
>
>
> Regards,
> Gabriel Burca

-- 
Boris

[Pagekit-devel] doc fixes

[Boris Z. <bo...@gm...>]

Hi,

some doc fixes follow.
Changed files:
  Apache-PageKit/Changes
  Apache-PageKit/docsrc/reference.xml

Index: Apache-PageKit/Changes
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/Changes,v
retrieving revision 1.161
diff -u -r1.161 Changes
--- Apache-PageKit/Changes	31 Jul 2002 08:07:36 -0000	1.161
+++ Apache-PageKit/Changes	31 Jul 2002 08:15:29 -0000
@@ -2,6 +2,8 @@
 
 	For more details on migration, see migration/README
 1.10
+	- Fix docs for PKIT_HAVE_MESSAGES and PKIT_HAVE_NOT_MESSAGES
+		(Boris Zentner)
 	- Fix: pkit_edit translate & to &amp; since <textarea> holds
 		#PCDATA, but we want it raw. (Boris Zentner)
 	- Fix warning, when pkit_auth_session_key is called with a session
Index: Apache-PageKit/docsrc/reference.xml
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/docsrc/reference.xml,v
retrieving revision 1.58
diff -u -r1.58 reference.xml
--- Apache-PageKit/docsrc/reference.xml	28 Jul 2002 21:02:57 -0000	1.58
+++ Apache-PageKit/docsrc/reference.xml	31 Jul 2002 08:15:42 -0000
@@ -1102,6 +1102,9 @@
 get dispatched to the mypage method of the myclass class, and the <filename>View/Default/myclass/mypage.tmpl</filename> template and/or the <filename>Content/myclass/mypage.xml</filename> XML file.
      </para>
      <para>
+     Note: that no session and page_session data is available in this function for reading or writing.
+     </para>
+     <para>
 See also <link linkend="config.global.uri_prefix">uri_prefix</link>.
      </para>
     </refsect1>
@@ -2323,7 +2326,7 @@
      <refnamediv>
       <refname>PKIT_HAVE_MESSAGES</refname>
       <refpurpose>
-       Include the block between <PKIT_HAVE_MESSAGES> and </PKIT_HAVE_MESSAGES> only,
+       Include the block between &lt;PKIT_HAVE_MESSAGES&gt; and &lt;/PKIT_HAVE_MESSAGES&gt; only,
        if one or more messages are avail.
       </refpurpose>
      </refnamediv>
@@ -2344,7 +2347,7 @@
      <refsect1>
       <title>Description</title>
       <para>
-        Include the block between <PKIT_HAVE_MESSAGES> and </PKIT_HAVE_MESSAGES> only,
+        Include the block between &lt;PKIT_HAVE_MESSAGES&gt; and &lt;/PKIT_HAVE_MESSAGES&gt; only,
         if one or more messages are avail.
       </para>
      </refsect1>
@@ -2353,7 +2356,7 @@
      <refnamediv>
       <refname>PKIT_HAVE_NOT_MESSAGES</refname>
       <refpurpose>
-       Include the block between <PKIT_HAVE_NOT_MESSAGES> and </PKIT_HAVE_NOT_MESSAGES> only,
+       Include the block between &lt;PKIT_HAVE_NOT_MESSAGES&gt; and &lt;/PKIT_HAVE_NOT_MESSAGES&gt; only,
        if no messages are avail.
       </refpurpose>
      </refnamediv>
@@ -2368,7 +2371,7 @@
      <refsect1>
       <title>Description</title>
       <para>
-        Include the block between <PKIT_HAVE_NOT_MESSAGES> and </PKIT_HAVE_NOT_MESSAGES> only,
+        Include the block between &lt;PKIT_HAVE_NOT_MESSAGES&gt; and &lt;/PKIT_HAVE_NOT_MESSAGES&gt; only,
         if no messages are avail.
       </para>
      </refsect1>

-- 
Boris

[Pagekit-devel] Fix: do not allow cache of ... pages

[Boris Z. <bo...@gm...>]

Hi,

this patch prevents the client to cache a redirected login page for example.

Changed files:
  Apache-PageKit/Changes
  Apache-PageKit/lib/Apache/PageKit.pm

Index: Apache-PageKit/Changes
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/Changes,v
retrieving revision 1.160
diff -u -r1.160 Changes
--- Apache-PageKit/Changes	31 Jul 2002 08:00:50 -0000	1.160
+++ Apache-PageKit/Changes	31 Jul 2002 08:06:42 -0000
@@ -7,6 +7,7 @@
 	- Fix warning, when pkit_auth_session_key is called with a session
 		without a user_id or the database can not provide a login
 		or passwd. (Boris Zentner)
+	- Fix: do NOT cache the page, that force us to login (Boris Zentner)
 	- Fix warning, when a pkit_macro tag is used without the same
 		parameter in the pkit_component tag (Boris Zentner)
 	- Fix pkit_input_hashref for the case where you request the hash,
Index: Apache-PageKit/lib/Apache/PageKit.pm
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/lib/Apache/PageKit.pm,v
retrieving revision 1.201
diff -u -r1.201 PageKit.pm
--- Apache-PageKit/lib/Apache/PageKit.pm	28 Jul 2002 21:00:57 -0000	1.201
+++ Apache-PageKit/lib/Apache/PageKit.pm	31 Jul 2002 08:06:49 -0000
@@ -494,6 +494,7 @@
 #      my $referer = $apr->header_in('Referer');
 #      $referer =~ s(http://[^/]*/([^?]*).*?)($1);
       $pk->{page_id} = $apr->param('pkit_login_page') || 
$config->get_global_attr('login_page');
+      $pk->{browser_cache} = 'no';
     }
   }
 
@@ -510,8 +511,9 @@
 	# user is logged in, but has had inactivity period
 
 	# display verify password form
-	$pk->{page_id} = $config->get_global_attr('verify_page') ||
-	  $config->get_global_attr('login_page');
+	$pk->{page_id} = $config->get_global_attr('verify_page') || 
$config->get_global_attr('login_page');
+	$pk->{browser_cache} = 'no';
+
 	# pkit_done parameter is used to return user to page that they originally 
requested
 	# after login is finished
 	$output_param_object->param("pkit_done",$uri_with_query) unless 
$apr->param("pkit_done");
@@ -528,6 +530,8 @@
       if($config->get_global_attr('cookies_not_set_page')){
 	# display "cookies are not set" error page.
 	$pk->{page_id} = $config->get_global_attr('cookies_not_set_page');
+	$pk->{browser_cache} = 'no';
+
       } else {
 	# display login page with error message
 	$pk->{page_id} = $config->get_global_attr('login_page');
@@ -539,6 +543,8 @@
     if(defined($require_login) && $require_login =~ /^(yes|recent)$/){
       # this page requires that the user has a valid cookie
       $pk->{page_id} = $config->get_global_attr('login_page');
+      # do NOT cache this page other wise we end up on the loginpage instead 
of the page we want
+      $pk->{browser_cache} = 'no';
       $output_param_object->param("pkit_done",$uri_with_query) unless 
$apr->param("pkit_done");
       $model->pkit_gettext_message('This page requires a login.');
     }
@@ -685,7 +691,7 @@
   #$apr->no_cache(1) if $apr->param('pkit_logout') || 
$config->get_page_attr($pk->{page_id},'template_cache') eq 'no';
   # see http://support.microsoft.com/support/kb/articles/Q234/0/67.ASP
   # and http://www.pacificnet.net/~johnr/meta.html
-  my $browser_cache =  $config->get_page_attr($page_id,'browser_cache') || 
'yes';
+  my $browser_cache =  $pk->{browser_cache} || 
$config->get_page_attr($page_id,'browser_cache') || 'yes';
   $apr->header_out('Expires','-1') if $apr->param('pkit_logout') || 
$browser_cache eq 'no' || $apr->connection->user;
 
   my $default_output_charset = $view->{default_output_charset};

-- 
Boris

[Pagekit-devel] pkit_auth_session_key

[Boris Z. <bo...@gm...>]

Hi,

this patch fix some warnings that may occur in pkit_auth_session_key.

Changed files:
  Apache-PageKit/Changes
  Apache-PageKit/eg/Model/MyPageKit/Common.pm

Index: Apache-PageKit/Changes
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/Changes,v
retrieving revision 1.159
diff -u -r1.159 Changes
--- Apache-PageKit/Changes	28 Jul 2002 21:07:22 -0000	1.159
+++ Apache-PageKit/Changes	31 Jul 2002 08:00:14 -0000
@@ -4,6 +4,9 @@
 1.10
 	- Fix: pkit_edit translate & to &amp; since <textarea> holds
 		#PCDATA, but we want it raw. (Boris Zentner)
+	- Fix warning, when pkit_auth_session_key is called with a session
+		without a user_id or the database can not provide a login
+		or passwd. (Boris Zentner)
 	- Fix warning, when a pkit_macro tag is used without the same
 		parameter in the pkit_component tag (Boris Zentner)
 	- Fix pkit_input_hashref for the case where you request the hash,
Index: Apache-PageKit/eg/Model/MyPageKit/Common.pm
===================================================================
RCS file: /cvsroot/pagekit/Apache-PageKit/eg/Model/MyPageKit/Common.pm,v
retrieving revision 1.20
diff -u -r1.20 Common.pm
--- Apache-PageKit/eg/Model/MyPageKit/Common.pm	3 Apr 2002 13:31:14 -0000	1.20
+++ Apache-PageKit/eg/Model/MyPageKit/Common.pm	31 Jul 2002 08:00:14 -0000
@@ -108,11 +108,13 @@
 
   my $dbh = $model->dbh;
 
-  my $user_id = $ses_key->{user_id};
+  my $user_id = $ses_key->{user_id} or return;
 
   my $sql_str = "SELECT login, passwd FROM pkit_user WHERE user_id=?";
 
   my ($login, $epasswd) = $dbh->selectrow_array($sql_str,{},$user_id);
+  
+  return unless $login;
 
   # create a new hash and verify that it matches the supplied hash
   # (prevents tampering with the cookie)

-- 
Boris

[Pagekit-devel] fix:pkit_edit

[Boris Z. <bo...@gm...>]

Hi, htis patch fix pkit_edit. if your page includes   or similar.
--
Boris

[Pagekit-devel] fix: pkit_input_hashref

[Boris Z. <bo...@gm...>]

Hi,

this patch from Glenn Morgan fix the case where a input_hashref is requested 
twice or more with changes beten the requests send old data to you.

diff -ru Apache-PageKit-1.09_01.orig/Changes Apache-PageKit-1.09_01/Changes
--- Apache-PageKit-1.09_01.orig/Changes	Sun Jul 28 12:30:07 2002
+++ Apache-PageKit-1.09_01/Changes	Sun Jul 28 12:31:48 2002
@@ -2,6 +2,13 @@
 
 	For more details on migration, see migration/README
 1.10
+	- Fix pkit_input_hashref for the case where you request the hash,
+		change something and request the hash again. In error
+		you get the old value(s) back. (Glenn Morgan)
	- Fix call pkit_on_error before the session data is saved.
		So you can rollback the changes, even if your session
		data is in the same db with your application.
diff -ru Apache-PageKit-1.09_01.orig/docsrc/reference.xml Apache-PageKit-1.09_01/docsrc/reference.xml
--- Apache-PageKit-1.09_01.orig/docsrc/reference.xml	Sun Jul 28 12:29:44 2002
+++ Apache-PageKit-1.09_01/docsrc/reference.xml	Sun Jul 28 12:32:25 2002
@@ -1340,6 +1340,10 @@
 the parameters' values as values.  Note a multivalued parameters
 is returned as a reference to an array.
      </para>
+     <para>
+Note, that the values in this hash are <emphasis role="bold">readonly</emphasis>. 
+To modify something use $model-><literal>input</literal>( key => $value );.
+     </para>
     </refsect1>
    </refentry>
    <refentry id="model.api.fillinform">
Only in Apache-PageKit-1.09_01/docsrc: reference.xml.orig
diff -ru Apache-PageKit-1.09_01.orig/lib/Apache/PageKit/Model.pm Apache-PageKit-1.09_01/lib/Apache/PageKit/Model.pm
--- Apache-PageKit-1.09_01.orig/lib/Apache/PageKit/Model.pm	Sun Jul 28 12:29:44 2002
+++ Apache-PageKit-1.09_01/lib/Apache/PageKit/Model.pm	Sun Jul 28 12:32:57 2002
@@ -245,6 +245,15 @@
 # currently input_param is just a wrapper around $apr
 sub input {
   my $model = shift;
+  
+  if ( @_ > 1 && exists $model->{pkit_input_hashref} ) {
+    # insert something, we must update the hashref
+    my %params = @_;
+    while ( my ( $key, $value ) = each %params ) {
+      $model->{pkit_input_hashref}->{$key} = $value;
+    }
+  }
+
   if(wantarray){
     # deal with multiple value containing parameters
     my @list = $model->{pkit_pk}->{apr}->param(@_);
Only in Apache-PageKit-1.09_01/lib/Apache/PageKit: Model.pm.orig
diff -ru Apache-PageKit-1.09_01.orig/lib/Apache/PageKit.pm Apache-PageKit-1.09_01/lib/Apache/PageKit.pm
--- Apache-PageKit-1.09_01.orig/lib/Apache/PageKit.pm	Sun Jul 28 12:29:44 2002
+++ Apache-PageKit-1.09_01/lib/Apache/PageKit.pm	Sun Jul 28 12:32:44 2002
@@ -1460,6 +1460,8 @@
   David Christian
   Rob Starkey
   Anton Permyakov
+  Gabriel Burca
+  Glenn Morgan
   John Robinson
   Daniel Gardner
   Andy Massey
@@ -1468,7 +1470,6 @@
   John Moose
   Sheldon Hearn
   Vladimir Sekissov
-  Gabriel Burca
   Tomasz Konefal
   Michael Wojcikiewicz

--
Boris

[Pagekit-devel] fix: warnings with pkit_macro

[Boris Z. <bo...@gm...>]

Hi,
this patch fix the case where you use <pkit_macro ...> but missed the parameter 
in the <pkit_component ..> lin. This patch ignore this case and silently set the
content of your macro to ''.

diff -ru Apache-PageKit-1.09_01.orig/Changes Apache-PageKit-1.09_01/Changes
--- Apache-PageKit-1.09_01.orig/Changes	Sun Jul 28 12:38:10 2002
+++ Apache-PageKit-1.09_01/Changes	Sun Jul 28 12:39:05 2002
@@ -2,6 +2,8 @@
 
 	For more details on migration, see migration/README
 1.10
+	- Fix warning, when a pkit_macro tag is used without the same
+		parameter in the pkit_component tag (Boris Zentner)
 	- Fix pkit_input_hashref for the case where you request the hash,
 		change something and request the hash again. In error
 		you get the old value(s) back. (Glenn Morgan)
diff -ru Apache-PageKit-1.09_01.orig/lib/Apache/PageKit/View.pm Apache-PageKit-1.09_01/lib/Apache/PageKit/View.pm
--- Apache-PageKit-1.09_01.orig/lib/Apache/PageKit/View.pm	Sun Jul 28 12:38:10 2002
+++ Apache-PageKit-1.09_01/lib/Apache/PageKit/View.pm	Sun Jul 28 12:38:33 2002
@@ -370,8 +370,7 @@
     }
 
     my $template_ref = $view->_load_component($page_id, $component_id, $pkit_view, \%params);
-    push @{ $view->{component_ids_arrayref_with_params} }, [ $component_id => \%params ];
-    $$template_ref =~ s!<\s*PKIT_MACRO$key_value_pattern\s*/?>!$params{uc($+)}!egi if (keys %params);
+    $$template_ref =~ s!<\s*PKIT_MACRO$key_value_pattern\s*/?>!$params{uc($+)} || ''!egi if (keys %params);
     return $$template_ref;
   }
 }

-- 
--
Boris

Re: [Pagekit-devel] UTF-8 encoding/decoding in PKIT_ERRORSPAN

[Boris Z. <bo...@gm...>]

Hi Gabirel,

i have not tested your testcase (much thanks will do tomorrow). But im sure 
this is a bug in perl itself. Did you use the modified HTML::Template?

And im sure you use perl 5.6.1.  Did you?

Am Samstag, 27. Juli 2002 23:20 schrieb Gabriel Burca:
> I've noticed that encoding conversion is not done properly when the
> content is inside PKIT_ERRORSPAN. The file.tmpl shown below should have
> two identical lines. When the content is inside PKIT_ERRORSPAN, instead
> of a single s/S/t/T with a comma under, I get 2 characters (just like
> looking at UTF-8 text with a non-compliant viewer and seeing the 2bytes
> it takes to encode 1 character).
>
> It almost looks like the text is being converted twice.
>
> Outside the PKIT_ERRORSPAN, conversion works properly.
>
>
> file.xml
> --------------------------------------
> <?xml version="1.0" encoding="utf-8"?>
> <content>
> 	<ro_char_set xml:lang="ro">
> 		scedil &#x15F;
> 		Scedil &#x15E;
> 		tcedil &#x163;
> 		Tcedil &#x162;
> 	</ro_char_set>
> </content>
>
>
> file.tmpl
> ---------------------------------------------------------------
> <PKIT_ERRORSPAN NAME="some_name>
> 	<CONTENT_VAR NAME="document('file.xml')//ro_char_set">
> </PKIT_ERRORSPAN>
> <p>
> 	<CONTENT_VAR NAME="document('file.xml')//ro_char_set">
>
>
> Config.xml
> ----------
> <GLOBAL
> ...
> 	default_input_charset = "UTF-8"
> 	default_output_charset = "UTF-8"
> />
>
>
>
> Regards,
> Gabriel Burca

-- 
--
Boris