[Padict-developer] Re: strange things happen in SVN

[Thomas A. H. <th...@in...>]

* Benoit Cerrina <ben...@ya...> [20060223 00:49]:
> I'll try to avoid mixing reindenting and code changes.

Thanks, this will make reading the diffs easier.

> can't you set up the diff program you use with svn to ignore spaces once 
> and for all?

with bin/diff-wbB containing: exec diff -uwbB "$@"
I can use:
$ svn diff --diff-cmd "diff-wbB" -r690:691

But for getting machine readable diffs instead of human readable
diffs, you can't use that. But this doesn't matter if reindenting
and code changes aren't mixed.

> Regarding tabs I like to use them as they make looking at the code and 
> counting the indents easier than spaces and
> I think 4 is a reasonable size for them 8 is too big and people who use 
> that tend to mix space and tabs for indent
> which makes it extremely confusing as the code stop looking good 
> depending on the editor used.

"stop looking good depending on the editor used" is what I expect
with tabs of size 4.

> I really don't understand the last point.  When I diff using svn I get 
> the choice to use plain diff or a diff gui.  The diff gui can use the tab
> length that I like and when I use diff to produce unified diff, it looks 
> correct when looking at the diff in an editor (where the tabs length can 
> be set).

Of course one could do ":set ts=4" in vi, "less -x4" in less, look
at diffs/code only in these two programs (and not in plain shell or
in the mail program). And if everyone editing on PAdict files sets
his tab length to 4, it will not hurt when editing. But I can almost
promise that this will hurt someone sometime.


But to find an end for this boring discussion:
As long as the main crontributors are happy with this decision, it
is ok for me. If you can do more for PAdict (and thus for me) with
ts=4, then I don't want to stop you.

Thomas

-- 
Email: th...@in...
http://intevation.de/~thomas/