#10 new cygwin handling for v10.6 breaks use with cygwin p4

[Shaddy Baddah]

Hi. I noticed the changes in v10.6 to covert cygwin
paths to windows paths before calling p4. I use the
cygwin build of p4, and have a neat little environment
where I can use my unix SMB'ed filesystems
interchangably with unix and windows.

The new handling breaks this. Obviously the changes are
easily reverted, but I would suggest that the previous
handling be restored as normal, and a conditional be
added to specify the requirement for the conversion.
Here is my diff against CVS for the change.

diff -Naur p4.orig/p4.el p4/p4.el
--- p4.orig/p4.el 2004-06-12 09:15:00.000000000
+0800
+++ p4/p4.el 2004-06-15 16:19:05.280474400 +0800
@@ -133,7 +133,13 @@
(defcustom p4-cygpath-exec "cygpath" "Path to
cygpath binary on cygwin
systems."
:type 'string
+ :group 'p4)
+
+ (defcustom p4-use-cygpath nil "Use cygpath binary
on cygwin
+systems."
+ :type 'boolean
:group 'p4))
+
;; This is a string with default arguments to pass to "p4
diff",
;; "p4 diff2", "p4 describe", etc.
(defcustom p4-default-diff-options "-du"
@@ -3220,7 +3226,8 @@
name)))

(defun p4-cygpath (name)
- (if (memq system-type '(cygwin32))
+ (if (and p4-use-cygpath
+ (memq system-type '(cygwin32)))
(replace-in-string (exec-to-string (format "%s -w %
s" p4-cygpath-exec name)) "\n" "")
name))

[Shaddy Baddah]

Logged In: YES
user_id=133042

Sorry, the diff didn't come out right. Please find it as an
attachment.

[Shaddy Baddah]

Patch to p4el for option to use cygpath

[SourceForge Robot]

Logged In: YES
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

[Shaddy Baddah]

Logged In: YES
user_id=133042
Originator: YES

This patch hasn't really been integrated. Would appreciate a yay or neigh on its inclusion. Thanks in advance.

[Robert Stewart]

Logged In: YES
user_id=402463
Originator: NO

The new release will include customizable p4-use-cygpath defaulted to t. That way, the default behavior will be as before. You can set p4-use-cygpath to nil for your configuration.