#44 Do automatic revert -a before submit

[David Corbin]

Add a "pre-submit operation" to revert all unchange
files automatically when doing a submit.

Make this a preference. Default to disabled

[Boris Pruessmann]

Logged In: YES
user_id=227276

Please don't make this automatic. Instead, add a checkbox to the
submit dialog that says "Revert unchanged files before submit".
That's also the way that the new perforce client does this (p4v)

[David Corbin]

Logged In: YES
user_id=1805

Why does it matter if it's a preference? I have never seen
a reason to not do it. (Not that having the checkbox is a
bad idea).

[Paul Krause]

Logged In: YES
user_id=221319

I'm thinking that we could get the best of both worlds by
adding the check-box to the submit dialog, and pre-checking
it if the preference is enabled. Does that work for you guys?

Suggestions for the wording of the preference box are most
welcome. So far I've got "Revert unchanged files by default,"
which doesn't explain exactly what it does.

[David Corbin]

Logged In: YES
user_id=1805

How about this one.

1) We do the preference the way I would like it ("Revert
unchanged files", under submit options), which would happen
before the "Submit dialog" comes up.

2) When the dialog does come up, if you don't have this
option set, we provide a checkbox. The checkbox remembers
it's last state from one use to the next. This only happens
with the Submit (default) dialog, not the EditChangeSpec dialog.

[Johan Walles]

Logged In: YES
user_id=131866

What would be the downside of doing this? The reason I'm
asking is because if there's no downside to doing this,
there's no reason for this to be optional.