Menu ▾ ▴

#227 TShellItem should use tstring instead of TString

8
pending
Vidar Hasfjord
API (105)
1
2023-12-19
2023-06-20
Vidar Hasfjord
No

TShelItem is the only core OWL component that uses TString. Ideally, for consistency, it should be rewritten to use tstring instead, like all other components.

Also, after this change, TString is not used in the core, so can be moved to OCF where it is used.

Related

Commit: [r6749]
Commit: [r6750]
Wiki: OWLNext_Roadmap_and_Prereleases

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2023-06-20
    • status: open --> pending
     

  • Vidar Hasfjord

    Vidar Hasfjord - 2023-06-20

    This change has been made in Owlet [r6395]. In [r6396], TString, TUString and TSysStr were removed, as these classes are no longer used in the core.

    The changes in [r6395] have since been merged into the trunk [r6746], and TString and TUString have been moved to OCFNext [r6748].

    Further support for owl::tstring as well as std::filesystem::path as constructor and member function arguments (rather than C-strings) was added in [r6749], and this has been merged into Owlet [r6750].

     

    Related

    Commit: [r6395]
    Commit: [r6396]
    Commit: [r6746]
    Commit: [r6748]
    Commit: [r6749]
    Commit: [r6750]


    Last edit: Vidar Hasfjord 2023-12-19

  • Vidar Hasfjord

    Vidar Hasfjord - 2023-12-19
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,3 @@
 TShelItem is the only core OWL component that uses TString. Ideally, for consistency, it should be rewritten to use <tt>tstring</tt> instead, like all other components.
+
+Also, after this change, TString is not used in the core, so can be moved to OCF where it is used.
    • Group: Owlet --> 8
     

Anonymous
Anonymous

Add attachments
Cancel