Menu

#595 TTreeViewCtrl::HitTest fails (regression in 7.0.14)

7
closed
1
2025-02-19
2025-02-11
No

A regression was introduced in 7.0.14, as part of work on "Resolve compile-time warnings" [feature-requests:#248]. A change on the trunk related to "Make TTreeViewCtrl::HitTest consistent with similar methods" [feature-requests:#168] was inadvertently merged into the 7 branch [r7016].

Specifically, on the trunk (version 8) the info parameter of TTreeViewCtrl::HitTest has been changed to a reference [r5260], so on the trunk it is correct to take the address of the parameter when encoding the message arguments, but this does not apply to the old implementation on the 7 branch.

inline HTREEITEM
TTreeViewCtrl::HitTest(TTvHitTestInfo* info)
{
  return reinterpret_cast<HTREEITEM>(SendMessage(TVM_HITTEST, 0, TParam2(&info)));
}

This issue was reported by @juniordev. See [discussion:5b17b32d3e].

Related

Commit: [r5260]
Commit: [r7016]
Discussion: 5b17b32d3e
Discussion: Issue with TTreeViewCtrl::HitTest pointer passing
Feature Requests: #168
Feature Requests: #248
News: 2025/02/owlnext-7017-update
Wiki: OWLNext_Stable_Releases

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2025-02-11
    • status: open --> pending
    • assigned_to: Vidar Hasfjord
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2025-02-11

    This issue has now been fixed [r7492]. The fix was released in OWLNext 7.0.17.

     

    Related

    Commit: [r7492]


    Last edit: Vidar Hasfjord 6 days ago
  • Vidar Hasfjord

    Vidar Hasfjord - 2025-02-19
    • status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB