Menu

#574 Buffer overflow in TEdit::GetLine

6.44
closed
1
2024-09-20
2024-05-08
No

In TEdit::GetLine, the string null-terminator is written beyond the given buffer, if the line length equals or exceeds the buffer size. Note that EM_GETLINE in this case fills the whole buffer, and the count returned equals the buffer size.

Related

Discussion: Preparing updates for OWLNext 7.0, 6.44 and 6.36
News: 2024/05/owlnext-7014-64424-6369-updates
Wiki: OWLNext_Stable_Releases

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2024-05-27
    • assigned_to: Vidar Hasfjord
    • Group: unspecified --> 6.44
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2024-09-17
    • summary: Buffer overrun in TEdit::GetLine --> Buffer overflow in TEdit::GetLine
    • status: open --> pending
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2024-09-17

    This issue has now been fixed on the trunk [r7106], and the fix has been merged into 7.0 and 6.44 [r7107], as well as 6.36 [r7108]. Resolution: If the buffer is too small, the string is now truncated and false is returned (as per function documentation).

     

    Related

    Commit: [r7106]
    Commit: [r7107]
    Commit: [r7108]


    Last edit: Vidar Hasfjord 2024-09-17
  • Vidar Hasfjord

    Vidar Hasfjord - 2024-09-20
    • status: pending --> closed
     

Log in to post a comment.