#388 Problem with syntax highlighting in CoolPrj affecting OWLMaker

[Ognyan Chernokozhev]

Opening an .rc file in debug build of OWLMaker produces a lot of asserts while performing syntax highlighting.

[Ognyan Chernokozhev]

Here is the stack trace:

  OWLMaker.exe!_chvalidator(int c, int mask) Line 36
    OWLMaker.exe!fast_check(const int c, const int mask) Line 24
    OWLMaker.exe!isalnum(int c) Line 149
    OWLMaker.exe!xisalnum(int c) Line 152
    OWLMaker.exe!TRsrcSyntaxParser::ParseLine(unsigned long dwCookie, int nLineIndex, TCoolTextWnd::TTextBlock * pBuf, int & nActualItems) Line 503
    OWLMaker.exe!TCoolTextWnd::GetParseCookie(int lineIndex) Line 2138
    OWLMaker.exe!TCoolTextWnd::DrawLine(owl::TDC & dc, const owl::TRect & rect, int lineIndex) Line 2032
    OWLMaker.exe!TCoolTextWnd::Paint(owl::TDC & dc, bool erase, owl::TRect & rect) Line 1749

Looks like TRsrcSyntaxParser::ParseLine is trying to process wrongly terminated string, for example "POPUP "&Edit"НННээээ".

[Ognyan Chernokozhev]

Fixed in [r3944].
Traced the problem to a situation in which a variable nPos passes the end of the line, added a simple check to break out in this case.

[Vidar Hasfjord]

The fix was merged into 6.44 in [r3949].

[Vidar Hasfjord]

By the way, also see "Debug assertion fires in CoolPrj's TSyntaxParser for isalnum" [bugs:#285].

[Vidar Hasfjord]

This issue may also be related to [bugs:#154] "dumpstack.cpp crashes in CoolEdit" (now deleted).

Opening "owlcore/dumpstack.cpp" in OWLMaker crashes CoolEdit syntax highlighting.