Test Date: July 15, 2013
Test Time: 1:00 PM EDT
Tested Build: #1728 July 12, 2013 1:06:57 AM EDT
Client Browser: Mozilla Firefox 21.0 for Ubuntu Canonical - 1.0
Client OS.: Ubuntu 12.04 LTS, Processor:Intel® Core™ i5-3320M CPU @ 2.60GHz × 4, OS type: 64-bit
Dataset used: OSCAR testing dataset
Tested By: Alek Mirkin
Precondition:
1. OSCAR McMaster Test Version 12.1, system and DB up and running.
2. OSCAR user is register and have all rights login
Steps to reproduce the problem:
1. Launch the browser and open OSCAR McMaster site in the testing environment
2. Log In.
3. Select the Consultation Request Module.
4. From Consultation main page select the patient name.
5. Fill out Consultation Request form including “Appointment Notes” section
6. From top navigation bar select “Update Consultation Request & Print Preview” button.
--------------------------------------------------------
Expected Result:
Printable version of Consultation Request form should NOT contain “Appointment Notes” section.
--------------------------------------------------------
Observed:
Booking Consultation Request printable version have “Appointment notes” section
--------------------------------------------------------
Consultation Request and Print Preview screen shot
Hello Alek
I've tested on 12_1 and latest trunk, and it works fine.
Screenshot attached.
Can you verify on latest version of trunk.
I looked at the DEMO site for MFP and this issue exists. I just did that to make sure that I can re-create the issue that was logged at SFHC.
I also just checked the screen shot that Victor has provided and the appointment notes section is now empty in the Printed form (PDF).
From the expected behaviour in the issue, this is fixed.
Diff:
Victor. I think there is some confusion on the status of this ticket. I have been asked to re-open the issue as the team believes it is not fixed. It's marked closed in here in SF.
I looked for the commit and couldn't find it in Master. What's the commit/branch for this fix, or is it just locally now for you?
Hello Aron
As commented, I was unable to reproduce on 12-1 or trunk
Based on you comment 2 days ago I assumed it was fixed:
"From the expected behaviour in the issue, this is fixed."
If it is still an issue, please verify on latest trunk and provide more details
My comment before your screenshot says that I can still see the issue at MFP. Because of the screenshot you included after (without a comment), I assumed that you had fixed it locally. It appears now that you're saying that you can't see it.
If that is a screen shot of you not seeing the issue, I would suggest using the same environment as the clinic. From your screen shot it looks like you are running safari on a Mac and the clinics are running Win 7 / FF 22.0
If you can't recreate the issue locally, you might want to request an account on the DEMO at MFP. This issue was seen at both clinics.
Last edit: Aaron Toth 2013-08-09
Hello Aron.
Marked as pending-works-for-me.
My environment is:
OSX 10.8.4
Firefox 22.0
Please try to recreate off latest version of trunk, and provide details.
I can confirm the problem here on 12.1 build #199.
Up until this point Appointment Notes have not been a printable part of the output.
Observed:
Booking Consultation Request printable version have “Appointment notes” section
August 9, 013. 11:20 PM
Bug # 2700 still open. “Appointment Notes” section appear in the printable version of the Consultation Request form.
Verification Test: Live site StoneChurch, Build: 1740. Also tested on the last successful build: # 1750 Jenkins server.
Please see screenshot attachment.
Test result – Fail
Alek.
There is a defect that was fixed a short time ago that is contradictory to this defect.
This is the defect:
https://sourceforge.net/p/oscarmcmaster/bugs/2481/
Here is the fix:
https://source.oscartools.org:8080/#/c/6043/
The summary information is a bit cut off due to length, but if you look at the notes on the commit, as well as the commit itself, it will depict that Appointment Notes were required on print preview. This is were the code in question was introduced.
I've gone ahead and re-assigned this defect to Ning, so please work it out between you both as to desired behavior, and Ning will implement.
When printing consults, not via pdf, the notes entered in appointment notes on the consult are being printed. This should not occur.
The appointment notes on the consult are meant to be internal and private to the clinic only. (if that helps)
I don't see a fix id for this on gerrit.
I haven't pushed it yet
Randy Jonasz
Java Developer
Department of Family Medicine
McMaster University
175 Longwood Road South, Suite 201A
Hamilton ON L8P 0A1
T - 905.525.9140 x27735
F - 905.521.5594
http://fammed.mcmaster.ca
Follow us on Twitter: @McMasterFammed
There are too many gentlemen in England by five hundred
--Robert Burnam 1549
On Mon, Aug 26, 2013 at 12:44 PM, Luxford.ca xzithlan@users.sf.net wrote:
Related
Bugs:
#2700Had a conversation with Marc about this one and he asked me to reopen.
Given that there's a field on the consult print preview called "Appointment Notes" and the field on the consult form is also called "Appointment Notes", I would say that whatever's written in the field should appear on the print preview. The fact that there's nowhere to write internal notes should be considered a gap in functionality in my opinion.
Reading through the history of this ticket, I see that prior to a given commit, the appointment notes did not appear on the printout so someone might need to make a determination as to what was actually intended with the "Appointment Notes" field.