Re: [Osalp-dev] Source Code Compatibility

[Bruce F. <for...@tn...>]

Anthony Zawacki wrote:
> 
> Hello,
> 
> I am attempting to use osalp in an AIX-4.3.3 / Visual Age 5.0 environment.
> Recognizing that this isn't a supported configuration, I expected to need
> to work on the sourcecode to get everything to work right.
> 
> I thought I would share some observations as I've started looking through
> the source code.
> 
> o  Something is setting the command line parameters strangely, such as my
> flags to include -Wall even though I specified a different compiler (xlC).
> -Dinline=__inline even though it should be just inline, so I remove this
> -D.
> 
> o  Some places #include <map> while other places include "map.h".  These
> may or may not be the same files.  In my case, they are not.  (other stl
> classes have similar issues, such as set.)
> 
> o  Several places have code that looks like this:
> #if __GNUC__ >= 3
> using std::string;
> using std::list;
> using std::map;
> #endif
> 
> This should probably be something more generalized to the extent of having
> something like #define OSALP_NAMESPACES __GNUC__ >= 3 and then changing the
> using section to:
> #if OSALP_NAMESPACES
> using std::string;
> using std::list;
> using std::map;
> #endif
> 
> This would allow a configuration file to defile OSALP_NAMESPACES for a
> given platform/compiler.
> 
> Any thoughts or suggestions for this type of porting effort is appreciated.
> Does it make sense for me to continue down this route?
> 

I think these are all good suggestions. All STL references should be of
the
form <map> and not map.h. I will fix this in CVS and check in the
changes
tonite. 

As far as namespaces, I not not too sure if all compilers are at
namespaces
yet. If they are then we should just use them everywhere, otherwise I
agree
with your change.

As far as Makefile type stuff I am not an autoconf, automake expert by
any means so I am not too sure what the fix is. 

Any effort to port to other platforms is very wellcome.

Bruce Forsberg