From: <no...@so...> - 2001-10-24 23:49:38
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: Nobody/Anonymous (nobody) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 01:53:32
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open >Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) >Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 02:02:41
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 17:58:55
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 18:35:08
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 18:52:20
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 19:16:55
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-25 19:32:47
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-26 00:49:41
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2001-10-25 17:45 Message: Logged In: NO This is still wrong - BINDIR is set to e.g. ${exec_prefix}/bin so this is expanded correctly with the version in current CVS. Thanks for the ld thing - applied (along with most of the rest of this patch). 0.0.7 should be coming out soonish with these fixes (and some others ;) ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-26 00:59:53
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: H.J. Lu (hjl) Date: 2001-10-25 17:56 Message: Logged In: YES user_id=10 I don't see how it can happen. BTW, my new patch should replace the old one. It shouldn't be applied on the top of the old one. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2001-10-25 17:45 Message: Logged In: NO This is still wrong - BINDIR is set to e.g. ${exec_prefix}/bin so this is expanded correctly with the version in current CVS. Thanks for the ld thing - applied (along with most of the rest of this patch). 0.0.7 should be coming out soonish with these fixes (and some others ;) ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-26 01:15:35
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-25 18:11 Message: Logged In: YES user_id=53034 Your patch does : prefix=$(DESTDIR)@prefix@ exec_prefix=@exec_prefix@ .... -$(MKDIR_P) $(DESTDIR)$(BINDIR) The generated makefile looks like : prefix=$(DESTDIR)/usr exec_prefix=${prefix} BINDIR=${exec_prefix}/bin ... Now, surely $(BINDIR) will have the resolved value /tmp/somedir/usr/bin if DESTDIR=/tmp/somedir with you suggested change we try to install into /tmp/somedir/tmp/somedir/usr/bin, as DESTDIR is /tmp/somedir, and BINDIR is /tmp/somedir/usr/bin, given the above. This is wrong (and I have tested that this actually happens). I've applied all the working bits of your patch by hand. ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 17:56 Message: Logged In: YES user_id=10 I don't see how it can happen. BTW, my new patch should replace the old one. It shouldn't be applied on the top of the old one. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2001-10-25 17:45 Message: Logged In: NO This is still wrong - BINDIR is set to e.g. ${exec_prefix}/bin so this is expanded correctly with the version in current CVS. Thanks for the ld thing - applied (along with most of the rest of this patch). 0.0.7 should be coming out soonish with these fixes (and some others ;) ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-26 01:32:02
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: H.J. Lu (hjl) Date: 2001-10-25 18:28 Message: Logged In: YES user_id=10 You have to show me where is prefix=$(DESTDIR)@prefix@ exec_prefix=@exec_prefix@ in my second patch. As I said, please ignore my first one. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 18:11 Message: Logged In: YES user_id=53034 Your patch does : prefix=$(DESTDIR)@prefix@ exec_prefix=@exec_prefix@ .... -$(MKDIR_P) $(DESTDIR)$(BINDIR) The generated makefile looks like : prefix=$(DESTDIR)/usr exec_prefix=${prefix} BINDIR=${exec_prefix}/bin ... Now, surely $(BINDIR) will have the resolved value /tmp/somedir/usr/bin if DESTDIR=/tmp/somedir with you suggested change we try to install into /tmp/somedir/tmp/somedir/usr/bin, as DESTDIR is /tmp/somedir, and BINDIR is /tmp/somedir/usr/bin, given the above. This is wrong (and I have tested that this actually happens). I've applied all the working bits of your patch by hand. ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 17:56 Message: Logged In: YES user_id=10 I don't see how it can happen. BTW, my new patch should replace the old one. It shouldn't be applied on the top of the old one. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2001-10-25 17:45 Message: Logged In: NO This is still wrong - BINDIR is set to e.g. ${exec_prefix}/bin so this is expanded correctly with the version in current CVS. Thanks for the ld thing - applied (along with most of the rest of this patch). 0.0.7 should be coming out soonish with these fixes (and some others ;) ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |
From: <no...@so...> - 2001-10-26 01:51:38
|
Bugs item #474678, was opened at 2001-10-24 16:49 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Submitted By: H.J. Lu (hjl) Assigned to: John Levon (movement) Summary: Fix the installation. Initial Comment: This patch fixes the man page installation and also support the alternative destination. ---------------------------------------------------------------------- >Comment By: John Levon (movement) Date: 2001-10-25 18:51 Message: Logged In: YES user_id=53034 Argh, sorry. (it's late). Yes, your patch is fine (currently in CVS is slightly different, setting prefix, so we don't need to mention DESTDIR everywhere). thanks for your time, john ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 18:28 Message: Logged In: YES user_id=10 You have to show me where is prefix=$(DESTDIR)@prefix@ exec_prefix=@exec_prefix@ in my second patch. As I said, please ignore my first one. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 18:11 Message: Logged In: YES user_id=53034 Your patch does : prefix=$(DESTDIR)@prefix@ exec_prefix=@exec_prefix@ .... -$(MKDIR_P) $(DESTDIR)$(BINDIR) The generated makefile looks like : prefix=$(DESTDIR)/usr exec_prefix=${prefix} BINDIR=${exec_prefix}/bin ... Now, surely $(BINDIR) will have the resolved value /tmp/somedir/usr/bin if DESTDIR=/tmp/somedir with you suggested change we try to install into /tmp/somedir/tmp/somedir/usr/bin, as DESTDIR is /tmp/somedir, and BINDIR is /tmp/somedir/usr/bin, given the above. This is wrong (and I have tested that this actually happens). I've applied all the working bits of your patch by hand. ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 17:56 Message: Logged In: YES user_id=10 I don't see how it can happen. BTW, my new patch should replace the old one. It shouldn't be applied on the top of the old one. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2001-10-25 17:45 Message: Logged In: NO This is still wrong - BINDIR is set to e.g. ${exec_prefix}/bin so this is expanded correctly with the version in current CVS. Thanks for the ld thing - applied (along with most of the rest of this patch). 0.0.7 should be coming out soonish with these fixes (and some others ;) ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 12:32 Message: Logged In: YES user_id=10 Ooops. A new patch. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 12:16 Message: Logged In: YES user_id=53034 I have no recollection of changing anything that matters. My generated makefiles with my version look like : prefix=$(DESTDIR)/usr/local exec_prefix=${prefix} which is obviously correct. moz dae 216 autoconf --version Autoconf version 2.13 moz oprofile-0.0.7cvs 231 make --version GNU Make version 3.79.1 I get this with both CVS's makefiles, and a dist tarball generated from current CVS. I'm at a loss why you are seeing different results. This implies that your version of make, seeing : prefix=$(DESTDIR)/usr/local exec_prefix=$(DESTDIR)${prefix} sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how that is possible, or makes any sense in fact. What am I missing ? ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 11:52 Message: Logged In: YES user_id=10 That is not what I see in 0.0.6: mkdir -p /var/tmp/oprofile-root/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755 /var/tmp/oprofile-root/usr/bin/$f; \ done You must have changed something. Talking about the kernel module, I think there should be a separate self-contained directory just for the kernel module. I have to rebuild the kernel module when I upgrade my kernel. But there is no need to rebuild the user space stuff. ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-25 11:35 Message: Logged In: YES user_id=53034 OK, I see - it is a temp. install directory. However, your patch is broken giving things like : make install DESTDIR=/tmp/tmpmake mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin for f in oprofiled op_start op_dump op_stop op_help; do \ cp $f /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755 /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \ done In fact, only the prefix line needs to change. I'm checking this in now. Note that the module still gets installed into /lib/modules/<whatever> ---------------------------------------------------------------------- Comment By: H.J. Lu (hjl) Date: 2001-10-25 10:55 Message: Logged In: YES user_id=10 DESTDIR is usful when you build rpm. It is mainly for packaging purpose. It has nothing to do with --prefix. You do # make install DESTDIR=/var/tmp/foobar ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 19:02 Message: Logged In: YES user_id=53034 H.J., actually I don't get what this DESTDIR thing is supposed to do. What is wrong with --prefix option ? thanks ---------------------------------------------------------------------- Comment By: John Levon (movement) Date: 2001-10-24 18:53 Message: Logged In: YES user_id=53034 Hi, H.J, thanks for the patch. I'd already fixed the manpage thing, I will apply your patch. ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191 |