[ oprofile-Bugs-474678 ] Fix the installation.

[<no...@so...>]

Bugs item #474678, was opened at 2001-10-24 16:49
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191

Category: None
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Submitted By: H.J. Lu (hjl)
Assigned to: John Levon (movement)
Summary: Fix the installation.

Initial Comment:
This patch fixes the man page installation and
also support the alternative destination.

----------------------------------------------------------------------

>Comment By: John Levon (movement)
Date: 2001-10-25 12:16

Message:
Logged In: YES 
user_id=53034

I have no recollection of changing anything that matters.

My generated
makefiles with my version look like :

prefix=$(DESTDIR)/usr/local
exec_prefix=${prefix}

which is obviously correct.

moz dae 216 autoconf --version
Autoconf version 2.13
moz oprofile-0.0.7cvs 231 make --version
GNU Make version 3.79.1

I get this with both CVS's makefiles, and a dist tarball
generated from current CVS.

I'm at a loss why you are seeing different results. This
implies that your version of make, seeing :

prefix=$(DESTDIR)/usr/local
exec_prefix=$(DESTDIR)${prefix}

sets $exec_prefix to $(DESTDIR)/usr/local. I don't see how
that is possible, or makes any sense in fact.

What am I missing ?

----------------------------------------------------------------------

Comment By: H.J. Lu (hjl)
Date: 2001-10-25 11:52

Message:
Logged In: YES 
user_id=10

That is not what I see in 0.0.6:

mkdir -p /var/tmp/oprofile-root/usr/bin
for f in oprofiled op_start op_dump op_stop op_help; do \
        cp $f /var/tmp/oprofile-root/usr/bin/$f && chmod 755
/var/tmp/oprofile-root/usr/bin/$f; \
done

You must have changed something. 

Talking about the kernel module,  I think there should be a
separate self-contained directory just for the kernel
module.
I have to rebuild the kernel module when I upgrade my
kernel.
But there is no need to rebuild the user space stuff.

----------------------------------------------------------------------

Comment By: John Levon (movement)
Date: 2001-10-25 11:35

Message:
Logged In: YES 
user_id=53034

OK, I see - it is a temp. install directory.

However, your patch is broken giving things like :

make install DESTDIR=/tmp/tmpmake
mkdir -p /tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin
for f in oprofiled op_start op_dump op_stop op_help; do \
        cp $f
/tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f && chmod 755
/tmp/tmpmake/tmp/tmpmake/tmp/tmpmake/usr/bin/$f; \
done

In fact, only the prefix line needs to change.

I'm checking this in now. Note that the module still gets
installed into /lib/modules/<whatever>


----------------------------------------------------------------------

Comment By: H.J. Lu (hjl)
Date: 2001-10-25 10:55

Message:
Logged In: YES 
user_id=10

DESTDIR is usful when you build rpm. It is mainly for
packaging
purpose. It has nothing to do with --prefix. You do

# make install DESTDIR=/var/tmp/foobar

----------------------------------------------------------------------

Comment By: John Levon (movement)
Date: 2001-10-24 19:02

Message:
Logged In: YES 
user_id=53034

H.J., actually I don't get what this DESTDIR thing is
supposed to do. What is wrong with --prefix option ?

thanks

----------------------------------------------------------------------

Comment By: John Levon (movement)
Date: 2001-10-24 18:53

Message:
Logged In: YES 
user_id=53034

Hi, H.J, thanks for the patch.

I'd already fixed the manpage thing, I will apply your
patch.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=116191&aid=474678&group_id=16191