Re: [oprof-cvs] CVS: oprofile/libpp merge_spec.cpp,NONE,1.1.2.1 merge_spec.h,NONE,1.1.2.1 Makefile.am,1.1.2.2,1.1.2.3 parse_cmdline.cpp,1.1.2.3,1.1.2.4 parse_cmdline.h,1.1.2.3,1.1.2.4

[John L. <le...@mo...>]

On Wed, Apr 23, 2003 at 03:00:43PM -0700, Philippe Elie wrote:

> list<list<string> > partition_files(list<string> const & filename,
> 				    bool merge_cpu, bool merge_lib,
> 				    bool merge_tid, bool merge_tgid,
> 				    bool merge_unitmask)

Generally I prefer simple one-use structs instead of lots of parameters.

Simply because it's harder to read and work out what's going on. So we
shoould just have a

struct merge_options {
	bool cpu;
	bool lib;
	...
};

and pass a const & to that in.

(I suppose I should just be adding FIXMEs myself)

regards
john